[PATCH 02/26] configure: drop unused variables for xts

Paolo Bonzini posted 22 patches 4 years, 8 months ago
[PATCH 02/26] configure: drop unused variables for xts
Posted by Paolo Bonzini 4 years, 8 months ago
All XTS configuration uses qemu_private_xts.  Drop other variables as
they have only ever been used to generate the summary (which has since
been moved to meson.build).

Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
 configure | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/configure b/configure
index 8dcb9965b2..44c413e9b8 100755
--- a/configure
+++ b/configure
@@ -406,9 +406,7 @@ gtk="auto"
 tls_priority="NORMAL"
 gnutls="$default_feature"
 nettle="$default_feature"
-nettle_xts="no"
 gcrypt="$default_feature"
-gcrypt_xts="no"
 qemu_private_xts="yes"
 auth_pam="$default_feature"
 vte="$default_feature"
@@ -2897,7 +2895,6 @@ int main(void) {
 }
 EOF
         if compile_prog "$nettle_cflags" "$nettle_libs" ; then
-            nettle_xts=yes
             qemu_private_xts=no
         fi
     fi
@@ -2938,7 +2935,6 @@ int main(void) {
 }
 EOF
         if compile_prog "$gcrypt_cflags" "$gcrypt_libs" ; then
-            gcrypt_xts=yes
             qemu_private_xts=no
         fi
     elif test "$gcrypt" = "yes"; then
-- 
2.31.1



Re: [PATCH 02/26] configure: drop unused variables for xts
Posted by Philippe Mathieu-Daudé 4 years, 8 months ago
On 6/8/21 1:22 PM, Paolo Bonzini wrote:
> All XTS configuration uses qemu_private_xts.  Drop other variables as
> they have only ever been used to generate the summary (which has since
> been moved to meson.build).
> 
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
>  configure | 4 ----
>  1 file changed, 4 deletions(-)

Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>


Re: [PATCH 02/26] configure: drop unused variables for xts
Posted by Daniel P. Berrangé 4 years, 7 months ago
On Tue, Jun 08, 2021 at 01:22:37PM +0200, Paolo Bonzini wrote:
> All XTS configuration uses qemu_private_xts.  Drop other variables as
> they have only ever been used to generate the summary (which has since
> been moved to meson.build).
> 
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
>  configure | 4 ----
>  1 file changed, 4 deletions(-)

Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>


Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|


Re: [PATCH 02/26] configure: drop unused variables for xts
Posted by Richard Henderson 4 years, 8 months ago
On 6/8/21 4:22 AM, Paolo Bonzini wrote:
> All XTS configuration uses qemu_private_xts.  Drop other variables as
> they have only ever been used to generate the summary (which has since
> been moved to meson.build).
> 
> Signed-off-by: Paolo Bonzini<pbonzini@redhat.com>
> ---
>   configure | 4 ----
>   1 file changed, 4 deletions(-)

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>

r~