[PATCH v4 0/2] Gitlab: Add issue templates

John Snow posted 2 patches 2 years, 10 months ago
Test checkpatch passed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20210607153155.1760158-1-jsnow@redhat.com
.gitlab/issue_templates/bug.md             | 64 ++++++++++++++++++++++
.gitlab/issue_templates/feature_request.md | 32 +++++++++++
2 files changed, 96 insertions(+)
create mode 100644 .gitlab/issue_templates/bug.md
create mode 100644 .gitlab/issue_templates/feature_request.md
[PATCH v4 0/2] Gitlab: Add issue templates
Posted by John Snow 2 years, 10 months ago
Add "Bug" and "Feature Request" templates to the Gitlab interface to
help improve the quality of newly reported issues.

To see what this looks like, I've temporarily allowed my Gitlab fork to
diverge with these files merged.  See my fork's "new issue" page to see
it in action: https://gitlab.com/jsnow/qemu/-/issues/new?issue

(It's outdated a bit for V4, but you get the idea.)

These patches do not add a "default" template, the user still has to
select one from the list. I recommend that someone with permissions
updates the default template:

1. https://gitlab.com/qemu-project/qemu/edit
2. ctrl+f "Default description template for issues"
3. Update the default to the (suggested) below:

```
<!-- Select "Type: Issue" and choose one of the Description templates above. -->
```

We can use this cover letter to discuss/review the wording on that
default template which exists outside of repository data.

V4:
 - Change the "build on master" to be more of a nudge than a mandate,
   with improved instructions (stefanha, danpb)

V3:
 - Add pointer to https://www.qemu.org/download/#source
 - Add pointer to https://www.qemu.org/contribute/security-process/
 - Remove blurb covering tracing instructions.

V2:
- Updated both templates based on feedback from Peter, Daniel, and
  Thomas.

John Snow (2):
  GitLab: Add "Bug" issue reporting template
  GitLab: Add "Feature Request" issue template.

 .gitlab/issue_templates/bug.md             | 64 ++++++++++++++++++++++
 .gitlab/issue_templates/feature_request.md | 32 +++++++++++
 2 files changed, 96 insertions(+)
 create mode 100644 .gitlab/issue_templates/bug.md
 create mode 100644 .gitlab/issue_templates/feature_request.md

-- 
2.31.1



Re: [PATCH v4 0/2] Gitlab: Add issue templates
Posted by Stefan Hajnoczi 2 years, 10 months ago
On Mon, Jun 07, 2021 at 11:31:53AM -0400, John Snow wrote:
> Add "Bug" and "Feature Request" templates to the Gitlab interface to
> help improve the quality of newly reported issues.
> 
> To see what this looks like, I've temporarily allowed my Gitlab fork to
> diverge with these files merged.  See my fork's "new issue" page to see
> it in action: https://gitlab.com/jsnow/qemu/-/issues/new?issue
> 
> (It's outdated a bit for V4, but you get the idea.)
> 
> These patches do not add a "default" template, the user still has to
> select one from the list. I recommend that someone with permissions
> updates the default template:
> 
> 1. https://gitlab.com/qemu-project/qemu/edit
> 2. ctrl+f "Default description template for issues"
> 3. Update the default to the (suggested) below:
> 
> ```
> <!-- Select "Type: Issue" and choose one of the Description templates above. -->
> ```
> 
> We can use this cover letter to discuss/review the wording on that
> default template which exists outside of repository data.
> 
> V4:
>  - Change the "build on master" to be more of a nudge than a mandate,
>    with improved instructions (stefanha, danpb)
> 
> V3:
>  - Add pointer to https://www.qemu.org/download/#source
>  - Add pointer to https://www.qemu.org/contribute/security-process/
>  - Remove blurb covering tracing instructions.
> 
> V2:
> - Updated both templates based on feedback from Peter, Daniel, and
>   Thomas.
> 
> John Snow (2):
>   GitLab: Add "Bug" issue reporting template
>   GitLab: Add "Feature Request" issue template.
> 
>  .gitlab/issue_templates/bug.md             | 64 ++++++++++++++++++++++
>  .gitlab/issue_templates/feature_request.md | 32 +++++++++++
>  2 files changed, 96 insertions(+)
>  create mode 100644 .gitlab/issue_templates/bug.md
>  create mode 100644 .gitlab/issue_templates/feature_request.md
> 
> -- 
> 2.31.1
> 
> 

Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
Re: [PATCH v4 0/2] Gitlab: Add issue templates
Posted by John Snow 2 years, 10 months ago
On 6/7/21 11:31 AM, John Snow wrote:
> Add "Bug" and "Feature Request" templates to the Gitlab interface to
> help improve the quality of newly reported issues.
> 
> To see what this looks like, I've temporarily allowed my Gitlab fork to
> diverge with these files merged.  See my fork's "new issue" page to see
> it in action: https://gitlab.com/jsnow/qemu/-/issues/new?issue
> 
> (It's outdated a bit for V4, but you get the idea.)
> 
> These patches do not add a "default" template, the user still has to
> select one from the list. I recommend that someone with permissions
> updates the default template:
> 
> 1. https://gitlab.com/qemu-project/qemu/edit
> 2. ctrl+f "Default description template for issues"
> 3. Update the default to the (suggested) below:
> 
> ```
> <!-- Select "Type: Issue" and choose one of the Description templates above. -->
> ```
> 
> We can use this cover letter to discuss/review the wording on that
> default template which exists outside of repository data.
> 
> V4:
>   - Change the "build on master" to be more of a nudge than a mandate,
>     with improved instructions (stefanha, danpb)
> 
> V3:
>   - Add pointer to https://www.qemu.org/download/#source
>   - Add pointer to https://www.qemu.org/contribute/security-process/
>   - Remove blurb covering tracing instructions.
> 
> V2:
> - Updated both templates based on feedback from Peter, Daniel, and
>    Thomas.
> 
> John Snow (2):
>    GitLab: Add "Bug" issue reporting template
>    GitLab: Add "Feature Request" issue template.
> 
>   .gitlab/issue_templates/bug.md             | 64 ++++++++++++++++++++++
>   .gitlab/issue_templates/feature_request.md | 32 +++++++++++
>   2 files changed, 96 insertions(+)
>   create mode 100644 .gitlab/issue_templates/bug.md
>   create mode 100644 .gitlab/issue_templates/feature_request.md
> 

Gentle ping. I do not know whose jurisdiction this falls under.

--js


Re: [PATCH v4 0/2] Gitlab: Add issue templates
Posted by Thomas Huth 2 years, 10 months ago
On 15/06/2021 02.03, John Snow wrote:
> On 6/7/21 11:31 AM, John Snow wrote:
>> Add "Bug" and "Feature Request" templates to the Gitlab interface to
>> help improve the quality of newly reported issues.
>>
>> To see what this looks like, I've temporarily allowed my Gitlab fork to
>> diverge with these files merged.  See my fork's "new issue" page to see
>> it in action: https://gitlab.com/jsnow/qemu/-/issues/new?issue
>>
>> (It's outdated a bit for V4, but you get the idea.)
>>
>> These patches do not add a "default" template, the user still has to
>> select one from the list. I recommend that someone with permissions
>> updates the default template:
>>
>> 1. https://gitlab.com/qemu-project/qemu/edit
>> 2. ctrl+f "Default description template for issues"
>> 3. Update the default to the (suggested) below:
>>
>> ```
>> <!-- Select "Type: Issue" and choose one of the Description templates 
>> above. -->
>> ```
>>
>> We can use this cover letter to discuss/review the wording on that
>> default template which exists outside of repository data.
>>
>> V4:
>>   - Change the "build on master" to be more of a nudge than a mandate,
>>     with improved instructions (stefanha, danpb)
>>
>> V3:
>>   - Add pointer to https://www.qemu.org/download/#source
>>   - Add pointer to https://www.qemu.org/contribute/security-process/
>>   - Remove blurb covering tracing instructions.
>>
>> V2:
>> - Updated both templates based on feedback from Peter, Daniel, and
>>    Thomas.
>>
>> John Snow (2):
>>    GitLab: Add "Bug" issue reporting template
>>    GitLab: Add "Feature Request" issue template.
>>
>>   .gitlab/issue_templates/bug.md             | 64 ++++++++++++++++++++++
>>   .gitlab/issue_templates/feature_request.md | 32 +++++++++++
>>   2 files changed, 96 insertions(+)
>>   create mode 100644 .gitlab/issue_templates/bug.md
>>   create mode 100644 .gitlab/issue_templates/feature_request.md
>>
> 
> Gentle ping. I do not know whose jurisdiction this falls under.

I assume this should be merged by someone who has maintainer rights in the 
qemu-project on gitlab (for also updating the default template)?

  Thomas


Re: [PATCH v4 0/2] Gitlab: Add issue templates
Posted by John Snow 2 years, 10 months ago
Alex, do you want to stage this one with your test pulls? (You could 
amend patch #2 with your suggestion when you do?)

On 6/15/21 4:26 AM, Thomas Huth wrote:
> On 15/06/2021 02.03, John Snow wrote:
>> On 6/7/21 11:31 AM, John Snow wrote:
>>> Add "Bug" and "Feature Request" templates to the Gitlab interface to
>>> help improve the quality of newly reported issues.
>>>
>>> To see what this looks like, I've temporarily allowed my Gitlab fork to
>>> diverge with these files merged.  See my fork's "new issue" page to see
>>> it in action: https://gitlab.com/jsnow/qemu/-/issues/new?issue
>>>
>>> (It's outdated a bit for V4, but you get the idea.)
>>>
>>> These patches do not add a "default" template, the user still has to
>>> select one from the list. I recommend that someone with permissions
>>> updates the default template:
>>>
>>> 1. https://gitlab.com/qemu-project/qemu/edit
>>> 2. ctrl+f "Default description template for issues"
>>> 3. Update the default to the (suggested) below:
>>>
>>> ```
>>> <!-- Select "Type: Issue" and choose one of the Description templates 
>>> above. -->
>>> ```
>>>
>>> We can use this cover letter to discuss/review the wording on that
>>> default template which exists outside of repository data.
>>>
>>> V4:
>>>   - Change the "build on master" to be more of a nudge than a mandate,
>>>     with improved instructions (stefanha, danpb)
>>>
>>> V3:
>>>   - Add pointer to https://www.qemu.org/download/#source
>>>   - Add pointer to https://www.qemu.org/contribute/security-process/
>>>   - Remove blurb covering tracing instructions.
>>>
>>> V2:
>>> - Updated both templates based on feedback from Peter, Daniel, and
>>>    Thomas.
>>>
>>> John Snow (2):
>>>    GitLab: Add "Bug" issue reporting template
>>>    GitLab: Add "Feature Request" issue template.
>>>
>>>   .gitlab/issue_templates/bug.md             | 64 ++++++++++++++++++++++
>>>   .gitlab/issue_templates/feature_request.md | 32 +++++++++++
>>>   2 files changed, 96 insertions(+)
>>>   create mode 100644 .gitlab/issue_templates/bug.md
>>>   create mode 100644 .gitlab/issue_templates/feature_request.md
>>>
>>
>> Gentle ping. I do not know whose jurisdiction this falls under.
> 
> I assume this should be merged by someone who has maintainer rights in 
> the qemu-project on gitlab (for also updating the default template)?
> 
>   Thomas
> 
> 


Re: [PATCH v4 0/2] Gitlab: Add issue templates
Posted by Alex Bennée 2 years, 10 months ago
John Snow <jsnow@redhat.com> writes:

> Add "Bug" and "Feature Request" templates to the Gitlab interface to
> help improve the quality of newly reported issues.
>
> To see what this looks like, I've temporarily allowed my Gitlab fork to
> diverge with these files merged.  See my fork's "new issue" page to see
> it in action: https://gitlab.com/jsnow/qemu/-/issues/new?issue
>
> (It's outdated a bit for V4, but you get the idea.)
>
> These patches do not add a "default" template, the user still has to
> select one from the list. I recommend that someone with permissions
> updates the default template:
>
> 1. https://gitlab.com/qemu-project/qemu/edit
> 2. ctrl+f "Default description template for issues"
> 3. Update the default to the (suggested) below:

Queued to testing/next, thanks.

-- 
Alex Bennée