softfloat: Improve denormal handling

[PATCH 07/11] target/rx: Use FloatRoundMode in helper_set_fpsw

Posted by Richard Henderson 4 years, 8 months ago

Use the proper type for the roundmode array.

Cc: Philippe Mathieu-Daudé <f4bug@amsat.org>
Cc: Yoshinori Sato <ysato@users.sourceforge.jp>
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
 target/rx/op_helper.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/target/rx/op_helper.c b/target/rx/op_helper.c
index 2139def3b2..b1772e9538 100644
--- a/target/rx/op_helper.c
+++ b/target/rx/op_helper.c
@@ -120,7 +120,7 @@ static void update_fpsw(CPURXState *env, float32 ret, uintptr_t retaddr)
 
 void helper_set_fpsw(CPURXState *env, uint32_t val)
 {
-    static const int roundmode[] = {
+    static const FloatRoundMode roundmode[] = {
         float_round_nearest_even,
         float_round_to_zero,
         float_round_up,
-- 
2.25.1

Re: [PATCH 07/11] target/rx: Use FloatRoundMode in helper_set_fpsw

Posted by Yoshinori Sato 4 years, 8 months ago

On Thu, 27 May 2021 13:14:01 +0900,
Richard Henderson wrote:
> 
> Use the proper type for the roundmode array.
> 
> Cc: Philippe Mathieu-Daudé <f4bug@amsat.org>
> Cc: Yoshinori Sato <ysato@users.sourceforge.jp>
> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>

Reviewd-by: Yoshinori Sato <ysato@users.sourceforge.jp>

> ---
>  target/rx/op_helper.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/target/rx/op_helper.c b/target/rx/op_helper.c
> index 2139def3b2..b1772e9538 100644
> --- a/target/rx/op_helper.c
> +++ b/target/rx/op_helper.c
> @@ -120,7 +120,7 @@ static void update_fpsw(CPURXState *env, float32 ret, uintptr_t retaddr)
>  
>  void helper_set_fpsw(CPURXState *env, uint32_t val)
>  {
> -    static const int roundmode[] = {
> +    static const FloatRoundMode roundmode[] = {
>          float_round_nearest_even,
>          float_round_to_zero,
>          float_round_up,
> -- 
> 2.25.1
> 
>

Re: [PATCH 07/11] target/rx: Use FloatRoundMode in helper_set_fpsw

Posted by Philippe Mathieu-Daudé 4 years, 8 months ago

On 5/27/21 6:14 AM, Richard Henderson wrote:
> Use the proper type for the roundmode array.
> 
> Cc: Philippe Mathieu-Daudé <f4bug@amsat.org>
> Cc: Yoshinori Sato <ysato@users.sourceforge.jp>
> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
> ---
>  target/rx/op_helper.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>