[PATCH 0/3] qapi: static typing conversion, pt5c

John Snow posted 3 patches 2 years, 11 months ago
Failed in applying to current master (apply log)
There is a newer version of this series
scripts/qapi/expr.py   | 223 ++++++++++++++++++++---------------------
scripts/qapi/parser.py |  29 ++++--
scripts/qapi/schema.py |   6 +-
3 files changed, 129 insertions(+), 129 deletions(-)
[PATCH 0/3] qapi: static typing conversion, pt5c
Posted by John Snow 2 years, 11 months ago
This is part five (c), and focuses on sharing strict types between
parser.py and expr.py.

gitlab: https://gitlab.com/jsnow/qemu/-/commits/python-qapi-cleanup-pt5c

Requirements:
- Python 3.6+
- mypy >= 0.770
- pylint >= 2.6.0 (2.7.0+ when using Python 3.9+)

Every commit should pass with:
 - `isort -c qapi/`
 - `flake8 qapi/`
 - `pylint --rcfile=qapi/pylintrc qapi/`
 - `mypy --config-file=qapi/mypy.ini qapi/`

John Snow (3):
  qapi/expr: Split check_expr out from check_exprs
  qapi/parser.py: add ParsedExpression type
  qapi/parser: Remove _JSONObject

 scripts/qapi/expr.py   | 223 ++++++++++++++++++++---------------------
 scripts/qapi/parser.py |  29 ++++--
 scripts/qapi/schema.py |   6 +-
 3 files changed, 129 insertions(+), 129 deletions(-)

-- 
2.30.2



Re: [PATCH 0/3] qapi: static typing conversion, pt5c
Posted by Markus Armbruster 2 years, 7 months ago
Needs a rebase now.  Let's finish discussing my review of pt5b [v2]
first.  Pending patches to expr.py should have made it to master by
then.  If you're impatient, suggest to base on master + "[PATCH 0/5]
qapi: Another round of minor fixes and cleanups" + pt5b [v2].


Re: [PATCH 0/3] qapi: static typing conversion, pt5c
Posted by John Snow 2 years, 7 months ago
On Wed, Sep 8, 2021, 9:42 AM Markus Armbruster <armbru@redhat.com> wrote:

> Needs a rebase now.  Let's finish discussing my review of pt5b [v2]
> first.  Pending patches to expr.py should have made it to master by
> then.  If you're impatient, suggest to base on master + "[PATCH 0/5]
> qapi: Another round of minor fixes and cleanups" + pt5b [v2].
>

Not that impatient. Will focus on seeing 5b through the gates first.

My plan is to get the AQMP stuff merged and CI settled, then return focus
to you. Shouldn't take long.

--js

(ps: trying to answer mails from my phone for $reasons. If my formatting is
garbled and stupid, please just yell at me and I'll figure out how to fix
it. Thanks!)

>