[v2] target/i386: Make sure that vsyscall's tb->size != 0

[PATCH v2 0/2] target/i386: Make sure that vsyscall's tb->size != 0

Ilya Leoshkevich posted 2 patches 2 years, 11 months ago

Diff against v1
Download series mbox

Test checkpatch passed

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20210519045738.1335210-1-iii@linux.ibm.com

Maintainers: Richard Henderson <richard.henderson@linaro.org>, Eduardo Habkost <ehabkost@redhat.com>, Paolo Bonzini <pbonzini@redhat.com>

target/i386/tcg/translate.c      |  1 +
tests/tcg/x86_64/Makefile.target |  6 +++++-
tests/tcg/x86_64/vsyscall.c      | 12 ++++++++++++
3 files changed, 18 insertions(+), 1 deletion(-)
create mode 100644 tests/tcg/x86_64/vsyscall.c

Expand all Fold all

[PATCH v2 0/2] target/i386: Make sure that vsyscall's tb->size != 0

Posted by Ilya Leoshkevich 2 years, 11 months ago

This series for the s390-next tree fixes [1]. Patch 1 is the fix, patch
2 is the new test to avoid similar regressions in the future.

[1] https://lists.nongnu.org/archive/html/qemu-devel/2021-05/msg02962.html

v1: https://lists.gnu.org/archive/html/qemu-devel/2021-05/msg03219.html
v1 -> v2: Fixed a problem with compiling the new test on centos7. `make
          docker-all-tests` does not spot any other issues with the
          updated patch (it does fail though: a number of iotests have
          problems, there is a build problem with musl, etc, but this
          all happens without the patch too).

Ilya Leoshkevich (2):
  target/i386: Make sure that vsyscall's tb->size != 0
  tests/tcg/x86_64: add vsyscall smoke test

 target/i386/tcg/translate.c      |  1 +
 tests/tcg/x86_64/Makefile.target |  6 +++++-
 tests/tcg/x86_64/vsyscall.c      | 12 ++++++++++++
 3 files changed, 18 insertions(+), 1 deletion(-)
 create mode 100644 tests/tcg/x86_64/vsyscall.c

-- 
2.31.1

Re: [PATCH v2 0/2] target/i386: Make sure that vsyscall's tb->size != 0

Posted by Cornelia Huck 2 years, 11 months ago

On Wed, 19 May 2021 06:57:36 +0200
Ilya Leoshkevich <iii@linux.ibm.com> wrote:

> This series for the s390-next tree fixes [1]. Patch 1 is the fix, patch
> 2 is the new test to avoid similar regressions in the future.
> 
> [1] https://lists.nongnu.org/archive/html/qemu-devel/2021-05/msg02962.html
> 
> v1: https://lists.gnu.org/archive/html/qemu-devel/2021-05/msg03219.html
> v1 -> v2: Fixed a problem with compiling the new test on centos7. `make
>           docker-all-tests` does not spot any other issues with the
>           updated patch (it does fail though: a number of iotests have
>           problems, there is a build problem with musl, etc, but this
>           all happens without the patch too).
> 
> Ilya Leoshkevich (2):
>   target/i386: Make sure that vsyscall's tb->size != 0
>   tests/tcg/x86_64: add vsyscall smoke test
> 
>  target/i386/tcg/translate.c      |  1 +
>  tests/tcg/x86_64/Makefile.target |  6 +++++-
>  tests/tcg/x86_64/vsyscall.c      | 12 ++++++++++++
>  3 files changed, 18 insertions(+), 1 deletion(-)
>  create mode 100644 tests/tcg/x86_64/vsyscall.c
> 

Passes my tests and CI now.

Can I get an ack on patch 2? :)

Re: [PATCH v2 0/2] target/i386: Make sure that vsyscall's tb->size != 0

Posted by Cornelia Huck 2 years, 11 months ago

On Wed, 19 May 2021 06:57:36 +0200
Ilya Leoshkevich <iii@linux.ibm.com> wrote:

> This series for the s390-next tree fixes [1]. Patch 1 is the fix, patch
> 2 is the new test to avoid similar regressions in the future.
> 
> [1] https://lists.nongnu.org/archive/html/qemu-devel/2021-05/msg02962.html
> 
> v1: https://lists.gnu.org/archive/html/qemu-devel/2021-05/msg03219.html
> v1 -> v2: Fixed a problem with compiling the new test on centos7. `make
>           docker-all-tests` does not spot any other issues with the
>           updated patch (it does fail though: a number of iotests have
>           problems, there is a build problem with musl, etc, but this
>           all happens without the patch too).
> 
> Ilya Leoshkevich (2):
>   target/i386: Make sure that vsyscall's tb->size != 0
>   tests/tcg/x86_64: add vsyscall smoke test
> 
>  target/i386/tcg/translate.c      |  1 +
>  tests/tcg/x86_64/Makefile.target |  6 +++++-
>  tests/tcg/x86_64/vsyscall.c      | 12 ++++++++++++
>  3 files changed, 18 insertions(+), 1 deletion(-)
>  create mode 100644 tests/tcg/x86_64/vsyscall.c
> 

Thanks, queued to s390-next.