[PATCH 0/2] esp: minor fixes for older Linux versions

Mark Cave-Ayland posted 2 patches 2 years, 11 months ago
Test checkpatch passed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20210518212511.21688-1-mark.cave-ayland@ilande.co.uk
Maintainers: Paolo Bonzini <pbonzini@redhat.com>, Fam Zheng <fam@euphon.net>
hw/scsi/esp.c | 13 ++++++++++---
1 file changed, 10 insertions(+), 3 deletions(-)
[PATCH 0/2] esp: minor fixes for older Linux versions
Posted by Mark Cave-Ayland 2 years, 11 months ago
Following on from the ESP changes in QEMU 6.0 someone pointed out that the old
Linux 2.6 ESP driver as used in Aurelian's SPARC image at
https://people.debian.org/~aurel32/qemu/sparc/ emits a constant stream of
"esp0: STEP_ASEL for tgt 0" messages to the console during boot.

These patches solve the issue so that the older image is able to boot cleanly
once again. The first patch is a genuine bug fix for the QEMU 6.0 changes whilst
the second works around the delayed bus phase change when deferring IO transfers
from the end of the command phase to the start of the information transfer
phase.

I've tested this using the extended suite of images used for the QEMU 6.0 changes
and confirmed that there are no other regressions.

Signed-off-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>


Mark Cave-Ayland (2):
  esp: only assert INTR_DC interrupt flag if selection fails
  esp: only set ESP_RSEQ at the start of the select sequence

 hw/scsi/esp.c | 13 ++++++++++---
 1 file changed, 10 insertions(+), 3 deletions(-)

-- 
2.20.1


Re: [PATCH 0/2] esp: minor fixes for older Linux versions
Posted by Paolo Bonzini 2 years, 10 months ago
On 18/05/21 23:25, Mark Cave-Ayland wrote:
> Following on from the ESP changes in QEMU 6.0 someone pointed out that the old
> Linux 2.6 ESP driver as used in Aurelian's SPARC image at
> https://people.debian.org/~aurel32/qemu/sparc/ emits a constant stream of
> "esp0: STEP_ASEL for tgt 0" messages to the console during boot.
> 
> These patches solve the issue so that the older image is able to boot cleanly
> once again. The first patch is a genuine bug fix for the QEMU 6.0 changes whilst
> the second works around the delayed bus phase change when deferring IO transfers
> from the end of the command phase to the start of the information transfer
> phase.
> 
> I've tested this using the extended suite of images used for the QEMU 6.0 changes
> and confirmed that there are no other regressions.
> 
> Signed-off-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
> 
> 
> Mark Cave-Ayland (2):
>    esp: only assert INTR_DC interrupt flag if selection fails
>    esp: only set ESP_RSEQ at the start of the select sequence
> 
>   hw/scsi/esp.c | 13 ++++++++++---
>   1 file changed, 10 insertions(+), 3 deletions(-)
> 

Queued, thanks.

Paolo


Re: [PATCH 0/2] esp: minor fixes for older Linux versions
Posted by Mark Cave-Ayland 2 years, 11 months ago
On 18/05/2021 22:25, Mark Cave-Ayland wrote:

> Following on from the ESP changes in QEMU 6.0 someone pointed out that the old
> Linux 2.6 ESP driver as used in Aurelian's SPARC image at
> https://people.debian.org/~aurel32/qemu/sparc/ emits a constant stream of
> "esp0: STEP_ASEL for tgt 0" messages to the console during boot.
> 
> These patches solve the issue so that the older image is able to boot cleanly
> once again. The first patch is a genuine bug fix for the QEMU 6.0 changes whilst
> the second works around the delayed bus phase change when deferring IO transfers
> from the end of the command phase to the start of the information transfer
> phase.
> 
> I've tested this using the extended suite of images used for the QEMU 6.0 changes
> and confirmed that there are no other regressions.
> 
> Signed-off-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
> 
> 
> Mark Cave-Ayland (2):
>    esp: only assert INTR_DC interrupt flag if selection fails
>    esp: only set ESP_RSEQ at the start of the select sequence
> 
>   hw/scsi/esp.c | 13 ++++++++++---
>   1 file changed, 10 insertions(+), 3 deletions(-)

Ping?


ATB,

Mark.

Re: [PATCH 0/2] esp: minor fixes for older Linux versions
Posted by Mark Cave-Ayland 2 years, 11 months ago
On 28/05/2021 08:07, Mark Cave-Ayland wrote:

> On 18/05/2021 22:25, Mark Cave-Ayland wrote:
> 
>> Following on from the ESP changes in QEMU 6.0 someone pointed out that the old
>> Linux 2.6 ESP driver as used in Aurelian's SPARC image at
>> https://people.debian.org/~aurel32/qemu/sparc/ emits a constant stream of
>> "esp0: STEP_ASEL for tgt 0" messages to the console during boot.
>>
>> These patches solve the issue so that the older image is able to boot cleanly
>> once again. The first patch is a genuine bug fix for the QEMU 6.0 changes whilst
>> the second works around the delayed bus phase change when deferring IO transfers
>> from the end of the command phase to the start of the information transfer
>> phase.
>>
>> I've tested this using the extended suite of images used for the QEMU 6.0 changes
>> and confirmed that there are no other regressions.
>>
>> Signed-off-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
>>
>>
>> Mark Cave-Ayland (2):
>>    esp: only assert INTR_DC interrupt flag if selection fails
>>    esp: only set ESP_RSEQ at the start of the select sequence
>>
>>   hw/scsi/esp.c | 13 ++++++++++---
>>   1 file changed, 10 insertions(+), 3 deletions(-)
> 
> Ping?

Ping again?


ATB,

Mark.