[PATCH v5 0/6] hw/block/fdc: Allow Kconfig-selecting ISA bus/SysBus floppy controllers

Philippe Mathieu-Daudé posted 6 patches 2 years, 11 months ago
Test checkpatch passed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20210518193239.1725624-1-philmd@redhat.com
There is a newer version of this series
hw/block/fdc-internal.h | 158 ++++++++++
include/hw/block/fdc.h  |   2 +
hw/block/fdc-isa.c      | 319 +++++++++++++++++++++
hw/block/fdc-sysbus.c   | 258 +++++++++++++++++
hw/block/fdc.c          | 621 +---------------------------------------
MAINTAINERS             |   3 +
hw/block/Kconfig        |   8 +
hw/block/meson.build    |   2 +
hw/block/trace-events   |   3 +
hw/i386/Kconfig         |   2 +-
hw/isa/Kconfig          |   7 +-
hw/mips/Kconfig         |   2 +-
hw/sparc/Kconfig        |   2 +-
hw/sparc64/Kconfig      |   2 +-
14 files changed, 770 insertions(+), 619 deletions(-)
create mode 100644 hw/block/fdc-internal.h
create mode 100644 hw/block/fdc-isa.c
create mode 100644 hw/block/fdc-sysbus.c
[PATCH v5 0/6] hw/block/fdc: Allow Kconfig-selecting ISA bus/SysBus floppy controllers
Posted by Philippe Mathieu-Daudé 2 years, 11 months ago
Hi,

The floppy disc controllers pulls in irrelevant devices (sysbus in
an ISA-only machine, ISA bus + isa devices on a sysbus-only machine).

This series clean that by extracting each device in its own file,
adding the corresponding Kconfig symbols: FDC_ISA and FDC_SYSBUS.

Since v4:
- Dropped machine patches for later due to DMA jazz issue

Since v3:
- Fix ISA_SUPERIO -> FDC Kconfig dependency (jsnow)

Since v2:
- rebased

Since v1:
- added missing "hw/block/block.h" header (jsnow)
- inlined hardware specific calls (Mark)
- added R-b/A-b tags

Regards,

Phil.

Philippe Mathieu-Daudé (6):
  hw/isa/Kconfig: Fix missing dependency ISA_SUPERIO -> FDC
  hw/block/fdc: Replace disabled fprintf() by trace event
  hw/block/fdc: Declare shared prototypes in fdc-internal.h
  hw/block/fdc: Extract ISA floppy controllers to fdc-isa.c
  hw/block/fdc: Extract SysBus floppy controllers to fdc-sysbus.c
  hw/block/fdc: Add sysbus_fdc_init_drives() method

 hw/block/fdc-internal.h | 158 ++++++++++
 include/hw/block/fdc.h  |   2 +
 hw/block/fdc-isa.c      | 319 +++++++++++++++++++++
 hw/block/fdc-sysbus.c   | 258 +++++++++++++++++
 hw/block/fdc.c          | 621 +---------------------------------------
 MAINTAINERS             |   3 +
 hw/block/Kconfig        |   8 +
 hw/block/meson.build    |   2 +
 hw/block/trace-events   |   3 +
 hw/i386/Kconfig         |   2 +-
 hw/isa/Kconfig          |   7 +-
 hw/mips/Kconfig         |   2 +-
 hw/sparc/Kconfig        |   2 +-
 hw/sparc64/Kconfig      |   2 +-
 14 files changed, 770 insertions(+), 619 deletions(-)
 create mode 100644 hw/block/fdc-internal.h
 create mode 100644 hw/block/fdc-isa.c
 create mode 100644 hw/block/fdc-sysbus.c

-- 
2.26.3