hmp-commands: expand type of icount to "l" in replay commands

[RFC PATCH] hmp-commands: expand type of icount to "l" in replay commands

Alex Bennée posted 1 patch 2 years, 11 months ago

Download mbox

Test checkpatch passed

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20210518140855.27026-1-alex.bennee@linaro.org

hmp-commands.hx | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

Expand all Fold all

[RFC PATCH] hmp-commands: expand type of icount to "l" in replay commands

Posted by Alex Bennée 2 years, 11 months ago

This is not a 32 bit number, it can (and most likely will) be quite a
big one.

Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Cc: Pavel Dovgalyuk <Pavel.Dovgalyuk@ispras.ru>
---
 hmp-commands.hx | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/hmp-commands.hx b/hmp-commands.hx
index 435c591a1c..5ee9cfd520 100644
--- a/hmp-commands.hx
+++ b/hmp-commands.hx
@@ -1667,7 +1667,7 @@ ERST
 
     {
         .name       = "replay_break",
-        .args_type  = "icount:i",
+        .args_type  = "icount:l",
         .params     = "icount",
         .help       = "set breakpoint at the specified instruction count",
         .cmd        = hmp_replay_break,
@@ -1699,7 +1699,7 @@ ERST
 
     {
         .name       = "replay_seek",
-        .args_type  = "icount:i",
+        .args_type  = "icount:l",
         .params     = "icount",
         .help       = "replay execution to the specified instruction count",
         .cmd        = hmp_replay_seek,
-- 
2.20.1

Re: [RFC PATCH] hmp-commands: expand type of icount to "l" in replay commands

Posted by Pavel Dovgalyuk 2 years, 11 months ago

On 18.05.2021 17:08, Alex Bennée wrote:
> This is not a 32 bit number, it can (and most likely will) be quite a
> big one.

Thanks, I forgot about it.

> 
> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
> Cc: Pavel Dovgalyuk <Pavel.Dovgalyuk@ispras.ru>

Reviewed-by: Pavel Dovgalyuk <Pavel.Dovgalyuk@ispras.ru>

> ---
>   hmp-commands.hx | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/hmp-commands.hx b/hmp-commands.hx
> index 435c591a1c..5ee9cfd520 100644
> --- a/hmp-commands.hx
> +++ b/hmp-commands.hx
> @@ -1667,7 +1667,7 @@ ERST
>   
>       {
>           .name       = "replay_break",
> -        .args_type  = "icount:i",
> +        .args_type  = "icount:l",
>           .params     = "icount",
>           .help       = "set breakpoint at the specified instruction count",
>           .cmd        = hmp_replay_break,
> @@ -1699,7 +1699,7 @@ ERST
>   
>       {
>           .name       = "replay_seek",
> -        .args_type  = "icount:i",
> +        .args_type  = "icount:l",
>           .params     = "icount",
>           .help       = "replay execution to the specified instruction count",
>           .cmd        = hmp_replay_seek,
>