[PATCH 1/3] cirrus-ci: test installation

Paolo Bonzini posted 3 patches 4 years, 8 months ago
[PATCH 1/3] cirrus-ci: test installation
Posted by Paolo Bonzini 4 years, 8 months ago
Entitlements are applied via an install script that runs at installation
time.  Test it in CI.

Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
 .cirrus.yml | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/.cirrus.yml b/.cirrus.yml
index f4bf49b704..340fd395c0 100644
--- a/.cirrus.yml
+++ b/.cirrus.yml
@@ -37,6 +37,7 @@ macos_task:
     - gmake check-qapi-schema V=1
     - gmake check-softfloat V=1
     - gmake check-qtest-x86_64 V=1
+    - gmake install DESTDIR=$PWD/destdir
 
 macos_xcode_task:
   osx_instance:
@@ -47,7 +48,7 @@ macos_xcode_task:
   script:
     - mkdir build
     - cd build
-    - ../configure --extra-cflags='-Wno-error=deprecated-declarations' --enable-modules
+    - ../configure --extra-cflags='-Wno-error=deprecated-declarations' --enable-modules --disable-strip
                    --enable-werror --cc=clang || { cat config.log meson-logs/meson-log.txt; exit 1; }
     - gmake -j$(sysctl -n hw.ncpu)
     - gmake check-unit V=1
@@ -55,6 +56,7 @@ macos_xcode_task:
     - gmake check-qapi-schema V=1
     - gmake check-softfloat V=1
     - gmake check-qtest-x86_64 V=1
+    - gmake install DESTDIR=$PWD/destdir
 
 windows_msys2_task:
   timeout_in: 90m
-- 
2.31.1



Re: [PATCH 1/3] cirrus-ci: test installation
Posted by Alex Bennée 4 years, 8 months ago
Paolo Bonzini <pbonzini@redhat.com> writes:

> Entitlements are applied via an install script that runs at installation
> time.  Test it in CI.
>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
>  .cirrus.yml | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/.cirrus.yml b/.cirrus.yml
> index f4bf49b704..340fd395c0 100644
> --- a/.cirrus.yml
> +++ b/.cirrus.yml
> @@ -37,6 +37,7 @@ macos_task:
>      - gmake check-qapi-schema V=1
>      - gmake check-softfloat V=1
>      - gmake check-qtest-x86_64 V=1
> +    - gmake install DESTDIR=$PWD/destdir
>  
>  macos_xcode_task:
>    osx_instance:
> @@ -47,7 +48,7 @@ macos_xcode_task:
>    script:
>      - mkdir build
>      - cd build
> -    - ../configure --extra-cflags='-Wno-error=deprecated-declarations' --enable-modules
> +    - ../configure --extra-cflags='-Wno-error=deprecated-declarations' --enable-modules --disable-strip

So what's the --disable-strip about? Surely we don't rely on the
installer packaging to do that for us?

>                     --enable-werror --cc=clang || { cat config.log meson-logs/meson-log.txt; exit 1; }
>      - gmake -j$(sysctl -n hw.ncpu)
>      - gmake check-unit V=1
> @@ -55,6 +56,7 @@ macos_xcode_task:
>      - gmake check-qapi-schema V=1
>      - gmake check-softfloat V=1
>      - gmake check-qtest-x86_64 V=1
> +    - gmake install DESTDIR=$PWD/destdir
>  
>  windows_msys2_task:
>    timeout_in: 90m


-- 
Alex Bennée

Re: [PATCH 1/3] cirrus-ci: test installation
Posted by Paolo Bonzini 4 years, 8 months ago
On 18/05/21 15:50, Alex Bennée wrote:
>>   macos_xcode_task:
>>     osx_instance:
>> @@ -47,7 +48,7 @@ macos_xcode_task:
>>     script:
>>       - mkdir build
>>       - cd build
>> -    - ../configure --extra-cflags='-Wno-error=deprecated-declarations' --enable-modules
>> +    - ../configure --extra-cflags='-Wno-error=deprecated-declarations' --enable-modules --disable-strip
> So what's the --disable-strip about? Surely we don't rely on the
> installer packaging to do that for us?

It was simply testing both with and without strip, to make sure that 
there wasn't anything macOS-specific.

Paolo