[PATCH] target/riscv: Remove obsolete 'CPU unmigratable' comment

Philippe Mathieu-Daudé posted 1 patch 2 years, 11 months ago
Test checkpatch passed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20210517070851.857841-1-f4bug@amsat.org
target/riscv/cpu.c | 1 -
1 file changed, 1 deletion(-)
[PATCH] target/riscv: Remove obsolete 'CPU unmigratable' comment
Posted by Philippe Mathieu-Daudé 2 years, 11 months ago
The RISCV CPU is migratable since commit f7697f0e629
("target/riscv: Add basic vmstate description of CPU"),
so remove an obsolete comment which is now incorrect.

Reported-by: Richard Henderson <richard.henderson@linaro.org>
Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
---
 target/riscv/cpu.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/target/riscv/cpu.c b/target/riscv/cpu.c
index 3191fd00822..d459e8427e2 100644
--- a/target/riscv/cpu.c
+++ b/target/riscv/cpu.c
@@ -638,7 +638,6 @@ static void riscv_cpu_class_init(ObjectClass *c, void *data)
     cc->disas_set_info = riscv_cpu_disas_set_info;
 #ifndef CONFIG_USER_ONLY
     cc->get_phys_page_debug = riscv_cpu_get_phys_page_debug;
-    /* For now, mark unmigratable: */
     cc->vmsd = &vmstate_riscv_cpu;
     cc->write_elf64_note = riscv_cpu_write_elf64_note;
     cc->write_elf32_note = riscv_cpu_write_elf32_note;
-- 
2.26.3

Re: [PATCH] target/riscv: Remove obsolete 'CPU unmigratable' comment
Posted by Bin Meng 2 years, 11 months ago
On Mon, May 17, 2021 at 3:08 PM Philippe Mathieu-Daudé <f4bug@amsat.org> wrote:
>
> The RISCV CPU is migratable since commit f7697f0e629
> ("target/riscv: Add basic vmstate description of CPU"),
> so remove an obsolete comment which is now incorrect.
>
> Reported-by: Richard Henderson <richard.henderson@linaro.org>
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> ---
>  target/riscv/cpu.c | 1 -
>  1 file changed, 1 deletion(-)
>

Reviewed-by: Bin Meng <bmeng.cn@gmail.com>

Re: [PATCH] target/riscv: Remove obsolete 'CPU unmigratable' comment
Posted by Richard Henderson 2 years, 11 months ago
On 5/17/21 2:08 AM, Philippe Mathieu-Daudé wrote:
> The RISCV CPU is migratable since commit f7697f0e629
> ("target/riscv: Add basic vmstate description of CPU"),
> so remove an obsolete comment which is now incorrect.
> 
> Reported-by: Richard Henderson<richard.henderson@linaro.org>
> Signed-off-by: Philippe Mathieu-Daudé<f4bug@amsat.org>
> ---
>   target/riscv/cpu.c | 1 -
>   1 file changed, 1 deletion(-)

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>

r~

Re: [PATCH] target/riscv: Remove obsolete 'CPU unmigratable' comment
Posted by Alistair Francis 2 years, 11 months ago
On Mon, May 17, 2021 at 5:09 PM Philippe Mathieu-Daudé <f4bug@amsat.org> wrote:
>
> The RISCV CPU is migratable since commit f7697f0e629
> ("target/riscv: Add basic vmstate description of CPU"),
> so remove an obsolete comment which is now incorrect.
>
> Reported-by: Richard Henderson <richard.henderson@linaro.org>
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>

Reviewed-by: Alistair Francis <alistair.francis@wdc.com>

Alistair

> ---
>  target/riscv/cpu.c | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/target/riscv/cpu.c b/target/riscv/cpu.c
> index 3191fd00822..d459e8427e2 100644
> --- a/target/riscv/cpu.c
> +++ b/target/riscv/cpu.c
> @@ -638,7 +638,6 @@ static void riscv_cpu_class_init(ObjectClass *c, void *data)
>      cc->disas_set_info = riscv_cpu_disas_set_info;
>  #ifndef CONFIG_USER_ONLY
>      cc->get_phys_page_debug = riscv_cpu_get_phys_page_debug;
> -    /* For now, mark unmigratable: */
>      cc->vmsd = &vmstate_riscv_cpu;
>      cc->write_elf64_note = riscv_cpu_write_elf64_note;
>      cc->write_elf32_note = riscv_cpu_write_elf32_note;
> --
> 2.26.3
>
>

Re: [PATCH] target/riscv: Remove obsolete 'CPU unmigratable' comment
Posted by Alistair Francis 2 years, 11 months ago
On Mon, May 17, 2021 at 5:09 PM Philippe Mathieu-Daudé <f4bug@amsat.org> wrote:
>
> The RISCV CPU is migratable since commit f7697f0e629
> ("target/riscv: Add basic vmstate description of CPU"),
> so remove an obsolete comment which is now incorrect.
>
> Reported-by: Richard Henderson <richard.henderson@linaro.org>
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>

Thanks!

Applied to riscv-to-apply.next

Alistair

> ---
>  target/riscv/cpu.c | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/target/riscv/cpu.c b/target/riscv/cpu.c
> index 3191fd00822..d459e8427e2 100644
> --- a/target/riscv/cpu.c
> +++ b/target/riscv/cpu.c
> @@ -638,7 +638,6 @@ static void riscv_cpu_class_init(ObjectClass *c, void *data)
>      cc->disas_set_info = riscv_cpu_disas_set_info;
>  #ifndef CONFIG_USER_ONLY
>      cc->get_phys_page_debug = riscv_cpu_get_phys_page_debug;
> -    /* For now, mark unmigratable: */
>      cc->vmsd = &vmstate_riscv_cpu;
>      cc->write_elf64_note = riscv_cpu_write_elf64_note;
>      cc->write_elf32_note = riscv_cpu_write_elf32_note;
> --
> 2.26.3
>
>