[v2] vhost-user-gpu: fix several security issues

[PATCH v2 0/8] vhost-user-gpu: fix several security issues

Posted by Li Qiang 2 years, 11 months ago

These security issue is low severity and is similar with the
virtio-vga/virtio-gpu device. All of them can be triggered by
the guest user.

Change since v1:
Add the CVE information:
Several memory leak issues is combined assigned CVE-2021-3544.
Information disclosure is assigned CVE-2021-3545.
OOB memory write access is assigned CVE-2021-3545.

Abstract 'vg_cleanup_mapping_iov' to make code more clearly.

Li Qiang (8):
  vhost-user-gpu: fix memory disclosure in virgl_cmd_get_capset_info
    (CVE-2021-3545)
  vhost-user-gpu: fix resource leak in 'vg_resource_create_2d'
    (CVE-2021-3544)
  vhost-user-gpu: fix memory leak in vg_resource_attach_backing
    (CVE-2021-3544)
  vhost-user-gpu: fix memory leak while calling 'vg_resource_unref'
    (CVE-2021-3544)
  vhost-user-gpu: fix memory leak in 'virgl_cmd_resource_unref'
    (CVE-2021-3544)
  vhost-user-gpu: fix memory leak in 'virgl_resource_attach_backing'
    (CVE-2021-3544)
  vhost-user-gpu: fix OOB write in 'virgl_cmd_get_capset'
    (CVE-2021-3546)
  vhost-user-gpu: abstract vg_cleanup_mapping_iov

 contrib/vhost-user-gpu/vhost-user-gpu.c | 29 ++++++++++++++++++++++---
 contrib/vhost-user-gpu/virgl.c          | 20 +++++++++++++++--
 contrib/vhost-user-gpu/vugpu.h          |  2 +-
 3 files changed, 45 insertions(+), 6 deletions(-)

-- 
2.25.1

Re: [PATCH v2 0/8] vhost-user-gpu: fix several security issues

Posted by Marc-André Lureau 2 years, 11 months ago

Hi

On Sun, May 16, 2021 at 7:04 AM Li Qiang <liq3ea@163.com> wrote:

> These security issue is low severity and is similar with the
> virtio-vga/virtio-gpu device. All of them can be triggered by
> the guest user.
>
> Change since v1:
> Add the CVE information:
> Several memory leak issues is combined assigned CVE-2021-3544.
> Information disclosure is assigned CVE-2021-3545.
> OOB memory write access is assigned CVE-2021-3545.
>
> Abstract 'vg_cleanup_mapping_iov' to make code more clearly.
>
> Li Qiang (8):
>   vhost-user-gpu: fix memory disclosure in virgl_cmd_get_capset_info
>     (CVE-2021-3545)
>   vhost-user-gpu: fix resource leak in 'vg_resource_create_2d'
>     (CVE-2021-3544)
>   vhost-user-gpu: fix memory leak in vg_resource_attach_backing
>     (CVE-2021-3544)
>   vhost-user-gpu: fix memory leak while calling 'vg_resource_unref'
>     (CVE-2021-3544)
>   vhost-user-gpu: fix memory leak in 'virgl_cmd_resource_unref'
>     (CVE-2021-3544)
>   vhost-user-gpu: fix memory leak in 'virgl_resource_attach_backing'
>     (CVE-2021-3544)
>   vhost-user-gpu: fix OOB write in 'virgl_cmd_get_capset'
>     (CVE-2021-3546)
>   vhost-user-gpu: abstract vg_cleanup_mapping_iov
>
>  contrib/vhost-user-gpu/vhost-user-gpu.c | 29 ++++++++++++++++++++++---
>  contrib/vhost-user-gpu/virgl.c          | 20 +++++++++++++++--
>  contrib/vhost-user-gpu/vugpu.h          |  2 +-
>  3 files changed, 45 insertions(+), 6 deletions(-)
>
> --
> 2.25.1
>
>
Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>

Re: [PATCH v2 0/8] vhost-user-gpu: fix several security issues

Posted by Gerd Hoffmann 2 years, 11 months ago

On Sat, May 15, 2021 at 08:03:55PM -0700, Li Qiang wrote:
> These security issue is low severity and is similar with the
> virtio-vga/virtio-gpu device. All of them can be triggered by
> the guest user.
> 
> Change since v1:
> Add the CVE information:
> Several memory leak issues is combined assigned CVE-2021-3544.
> Information disclosure is assigned CVE-2021-3545.
> OOB memory write access is assigned CVE-2021-3545.
> 
> Abstract 'vg_cleanup_mapping_iov' to make code more clearly.

Added all ti vga queue.

thanks,
  Gerd