[PATCH] tests/qtest/fuzz: Fix build failure

Philippe Mathieu-Daudé posted 1 patch 2 years, 11 months ago
Test checkpatch passed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20210513162008.3922223-1-philmd@redhat.com
tests/qtest/fuzz/fuzz.c | 1 +
1 file changed, 1 insertion(+)
[PATCH] tests/qtest/fuzz: Fix build failure
Posted by Philippe Mathieu-Daudé 2 years, 11 months ago
On Fedora 32, using clang (version 10.0.1-3.fc32) we get:

  tests/qtest/fuzz/fuzz.c:237:5: error: implicit declaration of function 'qemu_init' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
      qemu_init(result.we_wordc, result.we_wordv, NULL);
      ^

qemu_init() is declared in "sysemu/sysemu.h", include this
header to fix.

Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
---
 tests/qtest/fuzz/fuzz.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/tests/qtest/fuzz/fuzz.c b/tests/qtest/fuzz/fuzz.c
index 04b70e114bf..5f77c849837 100644
--- a/tests/qtest/fuzz/fuzz.c
+++ b/tests/qtest/fuzz/fuzz.c
@@ -16,6 +16,7 @@
 #include <wordexp.h>
 
 #include "qemu/datadir.h"
+#include "sysemu/sysemu.h"
 #include "sysemu/qtest.h"
 #include "sysemu/runstate.h"
 #include "qemu/main-loop.h"
-- 
2.26.3

Re: [PATCH] tests/qtest/fuzz: Fix build failure
Posted by Alexander Bulekov 2 years, 11 months ago

On 210513 1820, Philippe Mathieu-Daudé wrote:
> On Fedora 32, using clang (version 10.0.1-3.fc32) we get:
> 
>   tests/qtest/fuzz/fuzz.c:237:5: error: implicit declaration of function 'qemu_init' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
>       qemu_init(result.we_wordc, result.we_wordv, NULL);
>       ^
> 
> qemu_init() is declared in "sysemu/sysemu.h", include this
> header to fix.
> 
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>

Reviewed-by: Alexander Bulekov <alxndr@bu.edu>

Thank you

Re: [PATCH] tests/qtest/fuzz: Fix build failure
Posted by Philippe Mathieu-Daudé 2 years, 11 months ago
ping? (patch reviewed).

On 5/13/21 6:20 PM, Philippe Mathieu-Daudé wrote:
> On Fedora 32, using clang (version 10.0.1-3.fc32) we get:
> 
>   tests/qtest/fuzz/fuzz.c:237:5: error: implicit declaration of function 'qemu_init' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
>       qemu_init(result.we_wordc, result.we_wordv, NULL);
>       ^
> 
> qemu_init() is declared in "sysemu/sysemu.h", include this
> header to fix.
> 
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---
>  tests/qtest/fuzz/fuzz.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/tests/qtest/fuzz/fuzz.c b/tests/qtest/fuzz/fuzz.c
> index 04b70e114bf..5f77c849837 100644
> --- a/tests/qtest/fuzz/fuzz.c
> +++ b/tests/qtest/fuzz/fuzz.c
> @@ -16,6 +16,7 @@
>  #include <wordexp.h>
>  
>  #include "qemu/datadir.h"
> +#include "sysemu/sysemu.h"
>  #include "sysemu/qtest.h"
>  #include "sysemu/runstate.h"
>  #include "qemu/main-loop.h"
>