netdev: add more commands to preconfig mode

[PATCH] netdev: add more commands to preconfig mode

Posted by Paolo Bonzini 4 years, 9 months ago

Creating and destroying network backend does not require a fully
constructed machine.  Allow the related monitor commands to run before
machine initialization has concluded.

Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
 hmp-commands.hx | 2 ++
 qapi/net.json   | 6 ++++--
 2 files changed, 6 insertions(+), 2 deletions(-)

diff --git a/hmp-commands.hx b/hmp-commands.hx
index 901a50ebd1..1768bc5df0 100644
--- a/hmp-commands.hx
+++ b/hmp-commands.hx
@@ -1276,6 +1276,7 @@ ERST
         .help       = "add host network device",
         .cmd        = hmp_netdev_add,
         .command_completion = netdev_add_completion,
+        .flags      = "p",
     },
 
 SRST
@@ -1290,6 +1291,7 @@ ERST
         .help       = "remove host network device",
         .cmd        = hmp_netdev_del,
         .command_completion = netdev_del_completion,
+        .flags      = "p",
     },
 
 SRST
diff --git a/qapi/net.json b/qapi/net.json
index af3f5b0fda..7fab2e7cd8 100644
--- a/qapi/net.json
+++ b/qapi/net.json
@@ -55,7 +55,8 @@
 # <- { "return": {} }
 #
 ##
-{ 'command': 'netdev_add', 'data': 'Netdev', 'boxed': true }
+{ 'command': 'netdev_add', 'data': 'Netdev', 'boxed': true,
+  'allow-preconfig': true }
 
 ##
 # @netdev_del:
@@ -75,7 +76,8 @@
 # <- { "return": {} }
 #
 ##
-{ 'command': 'netdev_del', 'data': {'id': 'str'} }
+{ 'command': 'netdev_del', 'data': {'id': 'str'},
+  'allow-preconfig': true }
 
 ##
 # @NetLegacyNicOptions:
-- 
2.26.2

Re: [PATCH] netdev: add more commands to preconfig mode

Posted by Daniel P. Berrangé 4 years, 8 months ago

On Tue, May 11, 2021 at 11:39:55AM -0400, Paolo Bonzini wrote:
> Creating and destroying network backend does not require a fully
> constructed machine.  Allow the related monitor commands to run before
> machine initialization has concluded.
> 
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
>  hmp-commands.hx | 2 ++
>  qapi/net.json   | 6 ++++--
>  2 files changed, 6 insertions(+), 2 deletions(-)

Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>


Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|

Re: [PATCH] netdev: add more commands to preconfig mode

Posted by Jason Wang 4 years, 8 months ago

在 2021/6/7 下午10:22, Daniel P. Berrangé 写道:
> On Tue, May 11, 2021 at 11:39:55AM -0400, Paolo Bonzini wrote:
>> Creating and destroying network backend does not require a fully
>> constructed machine.  Allow the related monitor commands to run before
>> machine initialization has concluded.
>>
>> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
>> ---
>>   hmp-commands.hx | 2 ++
>>   qapi/net.json   | 6 ++++--
>>   2 files changed, 6 insertions(+), 2 deletions(-)
> Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
>
>
> Regards,
> Daniel


Queued.

Thanks

Re: [PATCH] netdev: add more commands to preconfig mode

Posted by Paolo Bonzini 4 years, 8 months ago

On 11/05/21 17:39, Paolo Bonzini wrote:
> Creating and destroying network backend does not require a fully
> constructed machine.  Allow the related monitor commands to run before
> machine initialization has concluded.
> 
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
>   hmp-commands.hx | 2 ++
>   qapi/net.json   | 6 ++++--
>   2 files changed, 6 insertions(+), 2 deletions(-)
> 
> diff --git a/hmp-commands.hx b/hmp-commands.hx
> index 901a50ebd1..1768bc5df0 100644
> --- a/hmp-commands.hx
> +++ b/hmp-commands.hx
> @@ -1276,6 +1276,7 @@ ERST
>           .help       = "add host network device",
>           .cmd        = hmp_netdev_add,
>           .command_completion = netdev_add_completion,
> +        .flags      = "p",
>       },
>   
>   SRST
> @@ -1290,6 +1291,7 @@ ERST
>           .help       = "remove host network device",
>           .cmd        = hmp_netdev_del,
>           .command_completion = netdev_del_completion,
> +        .flags      = "p",
>       },
>   
>   SRST
> diff --git a/qapi/net.json b/qapi/net.json
> index af3f5b0fda..7fab2e7cd8 100644
> --- a/qapi/net.json
> +++ b/qapi/net.json
> @@ -55,7 +55,8 @@
>   # <- { "return": {} }
>   #
>   ##
> -{ 'command': 'netdev_add', 'data': 'Netdev', 'boxed': true }
> +{ 'command': 'netdev_add', 'data': 'Netdev', 'boxed': true,
> +  'allow-preconfig': true }
>   
>   ##
>   # @netdev_del:
> @@ -75,7 +76,8 @@
>   # <- { "return": {} }
>   #
>   ##
> -{ 'command': 'netdev_del', 'data': {'id': 'str'} }
> +{ 'command': 'netdev_del', 'data': {'id': 'str'},
> +  'allow-preconfig': true }
>   
>   ##
>   # @NetLegacyNicOptions:
> 

Ping.