[v2] hw/isa: Remove unuseful qemu_allocate_irqs() call

[PATCH v2 0/4] hw/isa: Remove unuseful qemu_allocate_irqs() call

Posted by Philippe Mathieu-Daudé 2 years, 11 months ago

I started to fix the LeakSanitizer error in piix4_realize(),
then looked for similar pattern and found 2 other places.
The older is i82378 (historically the first one) which then
spread.

Since v1:
- rebased
- removed vt82c686 patches

Philippe Mathieu-Daudé (4):
  hw/isa/i82378: Name output IRQ as 'intr'
  hw/isa/i82378: Simplify removing unuseful qemu_allocate_irqs() call
  hw/isa/i82378: Rename output IRQ variable
  hw/isa/piix4: Fix leak removing unuseful qemu_allocate_irqs() call

 hw/isa/i82378.c | 13 +++----------
 hw/isa/piix4.c  | 10 +---------
 hw/ppc/prep.c   |  4 ++--
 3 files changed, 6 insertions(+), 21 deletions(-)

-- 
2.26.3

Re: [PATCH v2 0/4] hw/isa: Remove unuseful qemu_allocate_irqs() call

Posted by Philippe Mathieu-Daudé 2 years, 5 months ago

Cc'ing Zoltan

On 5/11/21 06:06, Philippe Mathieu-Daudé wrote:
> I started to fix the LeakSanitizer error in piix4_realize(),
> then looked for similar pattern and found 2 other places.
> The older is i82378 (historically the first one) which then
> spread.
> 
> Since v1:
> - rebased
> - removed vt82c686 patches
> 
> Philippe Mathieu-Daudé (4):
>   hw/isa/i82378: Name output IRQ as 'intr'
>   hw/isa/i82378: Simplify removing unuseful qemu_allocate_irqs() call
>   hw/isa/i82378: Rename output IRQ variable
>   hw/isa/piix4: Fix leak removing unuseful qemu_allocate_irqs() call
> 
>  hw/isa/i82378.c | 13 +++----------
>  hw/isa/piix4.c  | 10 +---------
>  hw/ppc/prep.c   |  4 ++--
>  3 files changed, 6 insertions(+), 21 deletions(-)
>

Re: [PATCH v2 0/4] hw/isa: Remove unuseful qemu_allocate_irqs() call

Posted by BALATON Zoltan 2 years, 5 months ago

On Sat, 6 Nov 2021, Philippe Mathieu-Daudé wrote:
> Cc'ing Zoltan

What do I have to do with this? This was a while ago so I don't remember 
and it seems to not touch any of the devices I have some experience with 
so not sure what do you expect from me for this series.

Regards,
BALATON Zoltan

> On 5/11/21 06:06, Philippe Mathieu-Daudé wrote:
>> I started to fix the LeakSanitizer error in piix4_realize(),
>> then looked for similar pattern and found 2 other places.
>> The older is i82378 (historically the first one) which then
>> spread.
>>
>> Since v1:
>> - rebased
>> - removed vt82c686 patches
>>
>> Philippe Mathieu-Daudé (4):
>>   hw/isa/i82378: Name output IRQ as 'intr'
>>   hw/isa/i82378: Simplify removing unuseful qemu_allocate_irqs() call
>>   hw/isa/i82378: Rename output IRQ variable
>>   hw/isa/piix4: Fix leak removing unuseful qemu_allocate_irqs() call
>>
>>  hw/isa/i82378.c | 13 +++----------
>>  hw/isa/piix4.c  | 10 +---------
>>  hw/ppc/prep.c   |  4 ++--
>>  3 files changed, 6 insertions(+), 21 deletions(-)
>>
>
>