[v3] virtio-blk: Convert QEMUBH callback to "bitops.h" API

[PATCH v3 0/2] virtio-blk: Convert QEMUBH callback to "bitops.h" API

Posted by Philippe Mathieu-Daudé 2 years, 11 months ago

This series follow a suggestion from Stefan to use the bitops
API in virtio-blk:
https://www.mail-archive.com/qemu-devel@nongnu.org/msg805139.html

Since v2:
- clear bitmap to avoid spurious interrupts! (Stefan)
- use 'further' in find_next docstring (Eric)
- added Richard R-b tag

Since v1:
- improved "bitops.h" docstring
- addressed Richard's review comments

Philippe Mathieu-Daudé (2):
  bitops.h: Improve find_xxx_bit() documentation
  virtio-blk: Convert QEMUBH callback to "bitops.h" API

 include/qemu/bitops.h           | 15 ++++++++++++---
 hw/block/dataplane/virtio-blk.c | 20 +++++---------------
 2 files changed, 17 insertions(+), 18 deletions(-)

-- 
2.26.3

Re: [PATCH v3 0/2] virtio-blk: Convert QEMUBH callback to "bitops.h" API

Posted by Stefan Hajnoczi 2 years, 11 months ago

On Mon, May 10, 2021 at 10:07:56PM +0200, Philippe Mathieu-Daudé wrote:
> This series follow a suggestion from Stefan to use the bitops
> API in virtio-blk:
> https://www.mail-archive.com/qemu-devel@nongnu.org/msg805139.html
> 
> Since v2:
> - clear bitmap to avoid spurious interrupts! (Stefan)
> - use 'further' in find_next docstring (Eric)
> - added Richard R-b tag
> 
> Since v1:
> - improved "bitops.h" docstring
> - addressed Richard's review comments
> 
> Philippe Mathieu-Daudé (2):
>   bitops.h: Improve find_xxx_bit() documentation
>   virtio-blk: Convert QEMUBH callback to "bitops.h" API
> 
>  include/qemu/bitops.h           | 15 ++++++++++++---
>  hw/block/dataplane/virtio-blk.c | 20 +++++---------------
>  2 files changed, 17 insertions(+), 18 deletions(-)
> 
> -- 
> 2.26.3
> 
> 

Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>

Re: [PATCH v3 0/2] virtio-blk: Convert QEMUBH callback to "bitops.h" API

Posted by Stefan Hajnoczi 2 years, 11 months ago

On Mon, May 10, 2021 at 10:07:56PM +0200, Philippe Mathieu-Daudé wrote:
> This series follow a suggestion from Stefan to use the bitops
> API in virtio-blk:
> https://www.mail-archive.com/qemu-devel@nongnu.org/msg805139.html
> 
> Since v2:
> - clear bitmap to avoid spurious interrupts! (Stefan)
> - use 'further' in find_next docstring (Eric)
> - added Richard R-b tag
> 
> Since v1:
> - improved "bitops.h" docstring
> - addressed Richard's review comments
> 
> Philippe Mathieu-Daudé (2):
>   bitops.h: Improve find_xxx_bit() documentation
>   virtio-blk: Convert QEMUBH callback to "bitops.h" API
> 
>  include/qemu/bitops.h           | 15 ++++++++++++---
>  hw/block/dataplane/virtio-blk.c | 20 +++++---------------
>  2 files changed, 17 insertions(+), 18 deletions(-)

This series causes "make check" to hang. QEMU processes consume 100% CPU
in notify_guest_bh().

I have dropped this from my patch queue.

Stefan