ppc/pnv: Add support for the POWER10 DD2 CPU

[PATCH 0/2] ppc/pnv: Add support for the POWER10 DD2 CPU

Cédric Le Goater posted 2 patches 2 years, 11 months ago

Download series mbox

Test checkpatch passed

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20210505090609.593194-1-clg@kaod.org

Maintainers: Greg Kurz <groug@kaod.org>, "Cédric Le Goater" <clg@kaod.org>, David Gibson <david@gibson.dropbear.id.au>

include/hw/ppc/pnv.h            | 2 +-
target/ppc/cpu-models.h         | 1 +
hw/ppc/pnv.c                    | 2 +-
hw/ppc/pnv_core.c               | 2 +-
target/ppc/cpu-models.c         | 4 +++-
target/ppc/translate_init.c.inc | 2 +-
6 files changed, 8 insertions(+), 5 deletions(-)

Expand all Fold all

[PATCH 0/2] ppc/pnv: Add support for the POWER10 DD2 CPU

Posted by Cédric Le Goater 2 years, 11 months ago

Hello,

The POWER10 DD2 CPU adds an extra LPCR[HAIL] bit which is a requirement
to support the scv instruction on PowerNV POWER10 platforms (glibc-2.33).

These changes add a POWER10 DD2 CPU and switch the default chip model
of the powernv10 machine to use this CPU. This to make sure that the
machine can boot the latest distros.

Thanks,

C.


Cédric Le Goater (2):
  ppc: Add a POWER10 DD2 CPU
  ppc/pnv: Add support for the POWER10 DD2 CPU

 include/hw/ppc/pnv.h            | 2 +-
 target/ppc/cpu-models.h         | 1 +
 hw/ppc/pnv.c                    | 2 +-
 hw/ppc/pnv_core.c               | 2 +-
 target/ppc/cpu-models.c         | 4 +++-
 target/ppc/translate_init.c.inc | 2 +-
 6 files changed, 8 insertions(+), 5 deletions(-)

-- 
2.26.3

Re: [PATCH 0/2] ppc/pnv: Add support for the POWER10 DD2 CPU

Posted by David Gibson 2 years, 11 months ago

On Wed, May 05, 2021 at 11:06:07AM +0200, Cédric Le Goater wrote:
> Hello,
> 
> The POWER10 DD2 CPU adds an extra LPCR[HAIL] bit which is a requirement
> to support the scv instruction on PowerNV POWER10 platforms (glibc-2.33).
> 
> These changes add a POWER10 DD2 CPU and switch the default chip model
> of the powernv10 machine to use this CPU. This to make sure that the
> machine can boot the latest distros.

LGTM as far as it goes.  Couple of points

 * I'd prefer to combine the two patches together, basically
   atomically replacing DD1 with DD2
 * I'd like to sort out the DAWR1 support first, or at the same time.
   I think it's reasonable to treat anything about POWER10 emulation
   as experimental and unstable until we put an actually publically
   available chip in there.  If we sort out DAWR1 support now, it
   means we can avoid having another spapr capability flag to handle
   the case of qemu versions that support DD2, but not DAWR1.

-- 
David Gibson			| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _other_
				| _way_ _around_!
http://www.ozlabs.org/~dgibson