[PATCH v5 00/11] 64bit block-layer: part II

Vladimir Sementsov-Ogievskiy posted 11 patches 2 years, 11 months ago
Test checkpatch failed
Failed in applying to current master (apply log)
There is a newer version of this series
include/block/block_int.h        | 66 ++++++++++++++++--------------
block/backup-top.c               | 14 +++----
block/blkdebug.c                 | 12 +++---
block/blklogwrites.c             | 16 ++++----
block/blkreplay.c                |  8 ++--
block/blkverify.c                |  8 ++--
block/bochs.c                    |  4 +-
block/cloop.c                    |  4 +-
block/commit.c                   |  2 +-
block/copy-on-read.c             | 19 +++++----
block/crypto.c                   |  8 ++--
block/curl.c                     |  3 +-
block/dmg.c                      |  4 +-
block/file-posix.c               | 35 ++++++++--------
block/file-win32.c               |  8 ++--
block/filter-compress.c          | 15 +++----
block/gluster.c                  | 13 +++---
block/io.c                       | 44 +++++++++++++++-----
block/iscsi.c                    | 53 ++++++++++++++----------
block/mirror.c                   |  8 ++--
block/nbd.c                      | 22 ++++++----
block/nfs.c                      | 12 +++---
block/null.c                     | 18 ++++----
block/nvme.c                     | 48 ++++++++++++++++++----
block/preallocate.c              | 14 +++----
block/qcow.c                     | 16 ++++----
block/qcow2-cluster.c            | 14 ++++++-
block/qcow2.c                    | 70 +++++++++++++++++++++++---------
block/qed.c                      |  9 +++-
block/quorum.c                   | 11 ++---
block/raw-format.c               | 36 ++++++++--------
block/rbd.c                      | 10 +++--
block/sheepdog.c                 | 15 ++++++-
block/throttle.c                 | 18 ++++----
block/vdi.c                      |  8 ++--
block/vmdk.c                     | 14 +++----
block/vpc.c                      |  8 ++--
block/vvfat.c                    | 12 +++---
tests/unit/test-bdrv-drain.c     | 16 ++++----
tests/unit/test-block-iothread.c | 21 +++++++---
block/trace-events               | 10 ++---
41 files changed, 456 insertions(+), 290 deletions(-)
[PATCH v5 00/11] 64bit block-layer: part II
Posted by Vladimir Sementsov-Ogievskiy 2 years, 11 months ago
Hi all!

v5: rebase on master, fix block comments style and over-80 line.
01: s/{}/()/ in subject, so that email not to be mangled.

part II aims to update block drivers to int64_t.

I remind that main aim of this update of the whole block-layer to 64bit
is to implement 64bit write-zeroes NBD request.

Vladimir Sementsov-Ogievskiy (11):
  block/io: bring request check to bdrv_co_(read,write)v_vmstate
  qcow2: check request on vmstate save/load path
  block: use int64_t instead of uint64_t in driver read handlers
  block: use int64_t instead of uint64_t in driver write handlers
  block: use int64_t instead of uint64_t in copy_range driver handlers
  block: make BlockLimits::max_pwrite_zeroes 64bit
  block: use int64_t instead of int in driver write_zeroes handlers
  block/io: allow 64bit write-zeroes requests
  block: make BlockLimits::max_pdiscard 64bit
  block: use int64_t instead of int in driver discard handlers
  block/io: allow 64bit discard requests

 include/block/block_int.h        | 66 ++++++++++++++++--------------
 block/backup-top.c               | 14 +++----
 block/blkdebug.c                 | 12 +++---
 block/blklogwrites.c             | 16 ++++----
 block/blkreplay.c                |  8 ++--
 block/blkverify.c                |  8 ++--
 block/bochs.c                    |  4 +-
 block/cloop.c                    |  4 +-
 block/commit.c                   |  2 +-
 block/copy-on-read.c             | 19 +++++----
 block/crypto.c                   |  8 ++--
 block/curl.c                     |  3 +-
 block/dmg.c                      |  4 +-
 block/file-posix.c               | 35 ++++++++--------
 block/file-win32.c               |  8 ++--
 block/filter-compress.c          | 15 +++----
 block/gluster.c                  | 13 +++---
 block/io.c                       | 44 +++++++++++++++-----
 block/iscsi.c                    | 53 ++++++++++++++----------
 block/mirror.c                   |  8 ++--
 block/nbd.c                      | 22 ++++++----
 block/nfs.c                      | 12 +++---
 block/null.c                     | 18 ++++----
 block/nvme.c                     | 48 ++++++++++++++++++----
 block/preallocate.c              | 14 +++----
 block/qcow.c                     | 16 ++++----
 block/qcow2-cluster.c            | 14 ++++++-
 block/qcow2.c                    | 70 +++++++++++++++++++++++---------
 block/qed.c                      |  9 +++-
 block/quorum.c                   | 11 ++---
 block/raw-format.c               | 36 ++++++++--------
 block/rbd.c                      | 10 +++--
 block/sheepdog.c                 | 15 ++++++-
 block/throttle.c                 | 18 ++++----
 block/vdi.c                      |  8 ++--
 block/vmdk.c                     | 14 +++----
 block/vpc.c                      |  8 ++--
 block/vvfat.c                    | 12 +++---
 tests/unit/test-bdrv-drain.c     | 16 ++++----
 tests/unit/test-block-iothread.c | 21 +++++++---
 block/trace-events               | 10 ++---
 41 files changed, 456 insertions(+), 290 deletions(-)


Cc: John Snow <jsnow@redhat.com>
Cc: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
Cc: Kevin Wolf <kwolf@redhat.com>
Cc: Max Reitz <mreitz@redhat.com>
Cc: Ari Sundholm <ari@tuxera.com>
Cc: Pavel Dovgalyuk <pavel.dovgaluk@ispras.ru>
Cc: Paolo Bonzini <pbonzini@redhat.com>
Cc: Stefan Hajnoczi <stefanha@redhat.com>
Cc: Stefan Weil <sw@weilnetz.de>
Cc: Fam Zheng <fam@euphon.net>
Cc: Ronnie Sahlberg <ronniesahlberg@gmail.com>
Cc: Peter Lieven <pl@kamp.de>
Cc: Eric Blake <eblake@redhat.com>
Cc: Alberto Garcia <berto@igalia.com>
Cc: Jason Dillaman <dillaman@redhat.com>
Cc: Liu Yuan <namei.unix@gmail.com>
Cc: qemu-block@nongnu.org
Cc: integration@gluster.org

-- 
2.29.2


Re: [PATCH v5 00/11] 64bit block-layer: part II
Posted by no-reply@patchew.org 2 years, 11 months ago
Patchew URL: https://patchew.org/QEMU/20210505075001.45041-1-vsementsov@virtuozzo.com/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: 20210505075001.45041-1-vsementsov@virtuozzo.com
Subject: [PATCH v5 00/11] 64bit block-layer: part II

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 - [tag update]      patchew/20210505045824.33880-1-liq3ea@163.com -> patchew/20210505045824.33880-1-liq3ea@163.com
 * [new tag]         patchew/20210505075001.45041-1-vsementsov@virtuozzo.com -> patchew/20210505075001.45041-1-vsementsov@virtuozzo.com
Switched to a new branch 'test'
3700aaf block/io: allow 64bit discard requests
54ba548 block: use int64_t instead of int in driver discard handlers
7a3aaa5 block: make BlockLimits::max_pdiscard 64bit
f80faf7 block/io: allow 64bit write-zeroes requests
4cc3310 block: use int64_t instead of int in driver write_zeroes handlers
136dd63 block: make BlockLimits::max_pwrite_zeroes 64bit
03a7c45 block: use int64_t instead of uint64_t in copy_range driver handlers
496fe8b block: use int64_t instead of uint64_t in driver write handlers
eefb31d block: use int64_t instead of uint64_t in driver read handlers
fb7a119 qcow2: check request on vmstate save/load path
23ba0f4 block/io: bring request check to bdrv_co_(read, write)v_vmstate

=== OUTPUT BEGIN ===
1/11 Checking commit 23ba0f4a09c1 (block/io: bring request check to bdrv_co_(read, write)v_vmstate)
ERROR: Author email address is mangled by the mailing list
#2: 
Author: Vladimir Sementsov-Ogievskiy via <qemu-devel@nongnu.org>

total: 1 errors, 0 warnings, 42 lines checked

Patch 1/11 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

2/11 Checking commit fb7a119cd9aa (qcow2: check request on vmstate save/load path)
3/11 Checking commit eefb31d480b4 (block: use int64_t instead of uint64_t in driver read handlers)
4/11 Checking commit 496fe8b2e7ce (block: use int64_t instead of uint64_t in driver write handlers)
5/11 Checking commit 03a7c4534a58 (block: use int64_t instead of uint64_t in copy_range driver handlers)
6/11 Checking commit 136dd63cc723 (block: make BlockLimits::max_pwrite_zeroes 64bit)
7/11 Checking commit 4cc3310d243e (block: use int64_t instead of int in driver write_zeroes handlers)
8/11 Checking commit f80faf73a84a (block/io: allow 64bit write-zeroes requests)
9/11 Checking commit 7a3aaa587314 (block: make BlockLimits::max_pdiscard 64bit)
10/11 Checking commit 54ba54860b4a (block: use int64_t instead of int in driver discard handlers)
11/11 Checking commit 3700aafec1ff (block/io: allow 64bit discard requests)
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/20210505075001.45041-1-vsementsov@virtuozzo.com/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com
Re: [PATCH v5 00/11] 64bit block-layer: part II
Posted by Vladimir Sementsov-Ogievskiy 2 years, 11 months ago
05.05.2021 11:06, no-reply@patchew.org wrote:
> Patchew URL: https://patchew.org/QEMU/20210505075001.45041-1-vsementsov@virtuozzo.com/
> 
> 
> 
> Hi,
> 
> This series seems to have some coding style problems. See output below for
> more information:
> 
> Type: series
> Message-id: 20210505075001.45041-1-vsementsov@virtuozzo.com
> Subject: [PATCH v5 00/11] 64bit block-layer: part II
> 
> === TEST SCRIPT BEGIN ===
> #!/bin/bash
> git rev-parse base > /dev/null || exit 0
> git config --local diff.renamelimit 0
> git config --local diff.renames True
> git config --local diff.algorithm histogram
> ./scripts/checkpatch.pl --mailback base..
> === TEST SCRIPT END ===
> 
> Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
>  From https://github.com/patchew-project/qemu
>   - [tag update]      patchew/20210505045824.33880-1-liq3ea@163.com -> patchew/20210505045824.33880-1-liq3ea@163.com
>   * [new tag]         patchew/20210505075001.45041-1-vsementsov@virtuozzo.com -> patchew/20210505075001.45041-1-vsementsov@virtuozzo.com
> Switched to a new branch 'test'
> 3700aaf block/io: allow 64bit discard requests
> 54ba548 block: use int64_t instead of int in driver discard handlers
> 7a3aaa5 block: make BlockLimits::max_pdiscard 64bit
> f80faf7 block/io: allow 64bit write-zeroes requests
> 4cc3310 block: use int64_t instead of int in driver write_zeroes handlers
> 136dd63 block: make BlockLimits::max_pwrite_zeroes 64bit
> 03a7c45 block: use int64_t instead of uint64_t in copy_range driver handlers
> 496fe8b block: use int64_t instead of uint64_t in driver write handlers
> eefb31d block: use int64_t instead of uint64_t in driver read handlers
> fb7a119 qcow2: check request on vmstate save/load path
> 23ba0f4 block/io: bring request check to bdrv_co_(read, write)v_vmstate
> 
> === OUTPUT BEGIN ===
> 1/11 Checking commit 23ba0f4a09c1 (block/io: bring request check to bdrv_co_(read, write)v_vmstate)
> ERROR: Author email address is mangled by the mailing list
> #2:
> Author: Vladimir Sementsov-Ogievskiy via <qemu-devel@nongnu.org>
> 
> total: 1 errors, 0 warnings, 42 lines checked
> 
> Patch 1/11 has style problems, please review.  If any of these errors
> are false positives report them to the maintainer, see
> CHECKPATCH in MAINTAINERS.

So, s/{}/()/ doesn't help.

> 
> 2/11 Checking commit fb7a119cd9aa (qcow2: check request on vmstate save/load path)
> 3/11 Checking commit eefb31d480b4 (block: use int64_t instead of uint64_t in driver read handlers)
> 4/11 Checking commit 496fe8b2e7ce (block: use int64_t instead of uint64_t in driver write handlers)
> 5/11 Checking commit 03a7c4534a58 (block: use int64_t instead of uint64_t in copy_range driver handlers)
> 6/11 Checking commit 136dd63cc723 (block: make BlockLimits::max_pwrite_zeroes 64bit)
> 7/11 Checking commit 4cc3310d243e (block: use int64_t instead of int in driver write_zeroes handlers)
> 8/11 Checking commit f80faf73a84a (block/io: allow 64bit write-zeroes requests)
> 9/11 Checking commit 7a3aaa587314 (block: make BlockLimits::max_pdiscard 64bit)
> 10/11 Checking commit 54ba54860b4a (block: use int64_t instead of int in driver discard handlers)
> 11/11 Checking commit 3700aafec1ff (block/io: allow 64bit discard requests)
> === OUTPUT END ===
> 
> Test command exited with code: 1
> 
> 
> The full log is available at
> http://patchew.org/logs/20210505075001.45041-1-vsementsov@virtuozzo.com/testing.checkpatch/?type=message.
> ---
> Email generated automatically by Patchew [https://patchew.org/].
> Please send your feedback to patchew-devel@redhat.com
> 


-- 
Best regards,
Vladimir

Re: [PATCH v5 00/11] 64bit block-layer: part II
Posted by Eric Blake 2 years, 10 months ago
On Wed, May 05, 2021 at 10:49:50AM +0300, Vladimir Sementsov-Ogievskiy wrote:
> Hi all!
> 
> v5: rebase on master, fix block comments style and over-80 line.
> 01: s/{}/()/ in subject, so that email not to be mangled.

Don't worry too much about that; if it happens again on v6, I can
manually fix the commit on my side or else pull the commit directly
from your repo (if you provide a link) rather than via 'git am'
through the mailing list.

> 
> part II aims to update block drivers to int64_t.
> 
> I remind that main aim of this update of the whole block-layer to 64bit
> is to implement 64bit write-zeroes NBD request.
> 
> Vladimir Sementsov-Ogievskiy (11):

I got through patches 1-6 in your v4 posting (our mails crossed), so
I'll assume those are similar, and resume my review with patch 7 in
this posting.

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org