1. Patchew
  2. QEMU
  3. View series

[PATCH] tests/migration-test: Fix "true" vs true

Dr. David Alan Gilbert (git) posted 1 patch 4 years, 9 months ago
Test checkpatch passed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20210504100545.112213-1-dgilbert@redhat.com
Maintainers: Thomas Huth <thuth@redhat.com>, Juan Quintela <quintela@redhat.com>, Paolo Bonzini <pbonzini@redhat.com>, Laurent Vivier <lvivier@redhat.com>, "Dr. David Alan Gilbert" <dgilbert@redhat.com>
tests/qtest/migration-test.c | 14 +++++++-------
1 file changed, 7 insertions(+), 7 deletions(-)
[PATCH] tests/migration-test: Fix "true" vs true
Posted by Dr. David Alan Gilbert (git) 4 years, 9 months ago 
From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>

Accidental use of "true" as a boolean; spotted by coverity
and Peter.

Fixes: b99784ef6c3
Fixes: d795f47466e
Reported-by: Peter Maydell <peter.maydell@linaro.org>
Reported-by: Coverity (CID 1432373, 1432292, 1432288)
Signed-off-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
---
 tests/qtest/migration-test.c | 14 +++++++-------
 1 file changed, 7 insertions(+), 7 deletions(-)

diff --git a/tests/qtest/migration-test.c b/tests/qtest/migration-test.c
index 3a711bb492..4d989f191b 100644
--- a/tests/qtest/migration-test.c
+++ b/tests/qtest/migration-test.c
@@ -898,8 +898,8 @@ static void test_xbzrle(const char *uri)
 
     migrate_set_parameter_int(from, "xbzrle-cache-size", 33554432);
 
-    migrate_set_capability(from, "xbzrle", "true");
-    migrate_set_capability(to, "xbzrle", "true");
+    migrate_set_capability(from, "xbzrle", true);
+    migrate_set_capability(to, "xbzrle", true);
     /* Wait for the first serial output from the source */
     wait_for_serial("src_serial");
 
@@ -1246,8 +1246,8 @@ static void test_multifd_tcp(const char *method)
     migrate_set_parameter_str(from, "multifd-compression", method);
     migrate_set_parameter_str(to, "multifd-compression", method);
 
-    migrate_set_capability(from, "multifd", "true");
-    migrate_set_capability(to, "multifd", "true");
+    migrate_set_capability(from, "multifd", true);
+    migrate_set_capability(to, "multifd", true);
 
     /* Start incoming migration from the 1st socket */
     rsp = wait_command(to, "{ 'execute': 'migrate-incoming',"
@@ -1330,8 +1330,8 @@ static void test_multifd_tcp_cancel(void)
     migrate_set_parameter_int(from, "multifd-channels", 16);
     migrate_set_parameter_int(to, "multifd-channels", 16);
 
-    migrate_set_capability(from, "multifd", "true");
-    migrate_set_capability(to, "multifd", "true");
+    migrate_set_capability(from, "multifd", true);
+    migrate_set_capability(to, "multifd", true);
 
     /* Start incoming migration from the 1st socket */
     rsp = wait_command(to, "{ 'execute': 'migrate-incoming',"
@@ -1358,7 +1358,7 @@ static void test_multifd_tcp_cancel(void)
 
     migrate_set_parameter_int(to2, "multifd-channels", 16);
 
-    migrate_set_capability(to2, "multifd", "true");
+    migrate_set_capability(to2, "multifd", true);
 
     /* Start incoming migration from the 1st socket */
     rsp = wait_command(to2, "{ 'execute': 'migrate-incoming',"
-- 
2.31.1
Re: [PATCH] tests/migration-test: Fix "true" vs true
Posted by Thomas Huth 4 years, 9 months ago 
On 04/05/2021 12.05, Dr. David Alan Gilbert (git) wrote:
> From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
> 
> Accidental use of "true" as a boolean; spotted by coverity
> and Peter.
> 
> Fixes: b99784ef6c3
> Fixes: d795f47466e
> Reported-by: Peter Maydell <peter.maydell@linaro.org>
> Reported-by: Coverity (CID 1432373, 1432292, 1432288)
> Signed-off-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
> ---
>   tests/qtest/migration-test.c | 14 +++++++-------
>   1 file changed, 7 insertions(+), 7 deletions(-)
> 
> diff --git a/tests/qtest/migration-test.c b/tests/qtest/migration-test.c
> index 3a711bb492..4d989f191b 100644
> --- a/tests/qtest/migration-test.c
> +++ b/tests/qtest/migration-test.c
> @@ -898,8 +898,8 @@ static void test_xbzrle(const char *uri)
>   
>       migrate_set_parameter_int(from, "xbzrle-cache-size", 33554432);
>   
> -    migrate_set_capability(from, "xbzrle", "true");
> -    migrate_set_capability(to, "xbzrle", "true");
> +    migrate_set_capability(from, "xbzrle", true);
> +    migrate_set_capability(to, "xbzrle", true);
>       /* Wait for the first serial output from the source */
>       wait_for_serial("src_serial");
>   
> @@ -1246,8 +1246,8 @@ static void test_multifd_tcp(const char *method)
>       migrate_set_parameter_str(from, "multifd-compression", method);
>       migrate_set_parameter_str(to, "multifd-compression", method);
>   
> -    migrate_set_capability(from, "multifd", "true");
> -    migrate_set_capability(to, "multifd", "true");
> +    migrate_set_capability(from, "multifd", true);
> +    migrate_set_capability(to, "multifd", true);
>   
>       /* Start incoming migration from the 1st socket */
>       rsp = wait_command(to, "{ 'execute': 'migrate-incoming',"
> @@ -1330,8 +1330,8 @@ static void test_multifd_tcp_cancel(void)
>       migrate_set_parameter_int(from, "multifd-channels", 16);
>       migrate_set_parameter_int(to, "multifd-channels", 16);
>   
> -    migrate_set_capability(from, "multifd", "true");
> -    migrate_set_capability(to, "multifd", "true");
> +    migrate_set_capability(from, "multifd", true);
> +    migrate_set_capability(to, "multifd", true);
>   
>       /* Start incoming migration from the 1st socket */
>       rsp = wait_command(to, "{ 'execute': 'migrate-incoming',"
> @@ -1358,7 +1358,7 @@ static void test_multifd_tcp_cancel(void)
>   
>       migrate_set_parameter_int(to2, "multifd-channels", 16);
>   
> -    migrate_set_capability(to2, "multifd", "true");
> +    migrate_set_capability(to2, "multifd", true);
>   
>       /* Start incoming migration from the 1st socket */
>       rsp = wait_command(to2, "{ 'execute': 'migrate-incoming',"
> 

Reviewed-by: Thomas Huth <thuth@redhat.com>
Re: [PATCH] tests/migration-test: Fix "true" vs true
Posted by Philippe Mathieu-Daudé 4 years, 9 months ago 
On 5/4/21 12:05 PM, Dr. David Alan Gilbert (git) wrote:
> From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
> 
> Accidental use of "true" as a boolean; spotted by coverity
> and Peter.
> 
> Fixes: b99784ef6c3
> Fixes: d795f47466e
> Reported-by: Peter Maydell <peter.maydell@linaro.org>
> Reported-by: Coverity (CID 1432373, 1432292, 1432288)
> Signed-off-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
> ---
>  tests/qtest/migration-test.c | 14 +++++++-------
>  1 file changed, 7 insertions(+), 7 deletions(-)
> 
> diff --git a/tests/qtest/migration-test.c b/tests/qtest/migration-test.c
> index 3a711bb492..4d989f191b 100644
> --- a/tests/qtest/migration-test.c
> +++ b/tests/qtest/migration-test.c
> @@ -898,8 +898,8 @@ static void test_xbzrle(const char *uri)
>  
>      migrate_set_parameter_int(from, "xbzrle-cache-size", 33554432);
>  
> -    migrate_set_capability(from, "xbzrle", "true");
> -    migrate_set_capability(to, "xbzrle", "true");
> +    migrate_set_capability(from, "xbzrle", true);
> +    migrate_set_capability(to, "xbzrle", true);

Funny one =)

Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>

Patchew 2.1-devel-b67e4c2

© 2016 - 2026 Red Hat, Inc.