[PATCH 0/2] Remove deprecated qemu-img backing file without format

Eric Blake posted 2 patches 4 years, 9 months ago
Test checkpatch passed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20210503213600.569128-1-eblake@redhat.com
Maintainers: Kevin Wolf <kwolf@redhat.com>, Max Reitz <mreitz@redhat.com>
docs/system/deprecated.rst       | 32 ---------------------------
docs/system/removed-features.rst | 31 ++++++++++++++++++++++++++
block.c                          | 37 ++++++++++----------------------
block/qcow2.c                    | 13 ++++-------
qemu-img.c                       |  6 ++++--
tests/qemu-iotests/061           |  3 +++
tests/qemu-iotests/061.out       |  3 ++-
tests/qemu-iotests/082.out       |  6 ++++--
tests/qemu-iotests/114           | 18 ++++++++--------
tests/qemu-iotests/114.out       | 11 ++++------
tests/qemu-iotests/301           |  4 +---
tests/qemu-iotests/301.out       | 16 ++------------
12 files changed, 75 insertions(+), 105 deletions(-)
[PATCH 0/2] Remove deprecated qemu-img backing file without format
Posted by Eric Blake 4 years, 9 months ago
We've gone enough release cycles without noticeable pushback on our
intentions, so time to make it harder to create images that can form a
security hole due to a need for format probing rather than an explicit
format.

Eric Blake (2):
  qcow2: Prohibit backing file changes in 'qemu-img amend'
  qemu-img: Require -F with -b backing image

 docs/system/deprecated.rst       | 32 ---------------------------
 docs/system/removed-features.rst | 31 ++++++++++++++++++++++++++
 block.c                          | 37 ++++++++++----------------------
 block/qcow2.c                    | 13 ++++-------
 qemu-img.c                       |  6 ++++--
 tests/qemu-iotests/061           |  3 +++
 tests/qemu-iotests/061.out       |  3 ++-
 tests/qemu-iotests/082.out       |  6 ++++--
 tests/qemu-iotests/114           | 18 ++++++++--------
 tests/qemu-iotests/114.out       | 11 ++++------
 tests/qemu-iotests/301           |  4 +---
 tests/qemu-iotests/301.out       | 16 ++------------
 12 files changed, 75 insertions(+), 105 deletions(-)

-- 
2.31.1


Re: [PATCH 0/2] Remove deprecated qemu-img backing file without format
Posted by Eric Blake 4 years, 7 months ago
On Mon, May 03, 2021 at 04:35:58PM -0500, Eric Blake wrote:
> We've gone enough release cycles without noticeable pushback on our
> intentions, so time to make it harder to create images that can form a
> security hole due to a need for format probing rather than an explicit
> format.
> 
> Eric Blake (2):
>   qcow2: Prohibit backing file changes in 'qemu-img amend'
>   qemu-img: Require -F with -b backing image

Ping.

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org

Re: [PATCH 0/2] Remove deprecated qemu-img backing file without format
Posted by Kevin Wolf 4 years, 7 months ago
Am 07.07.2021 um 23:17 hat Eric Blake geschrieben:
> On Mon, May 03, 2021 at 04:35:58PM -0500, Eric Blake wrote:
> > We've gone enough release cycles without noticeable pushback on our
> > intentions, so time to make it harder to create images that can form a
> > security hole due to a need for format probing rather than an explicit
> > format.
> > 
> > Eric Blake (2):
> >   qcow2: Prohibit backing file changes in 'qemu-img amend'
> >   qemu-img: Require -F with -b backing image
> 
> Ping.

Thanks, applied to the block branch.

For some reason, the CCs were missing on the cover letter. Please make
sure to CC me (and qemu-block) for the whole series if you want it to go
through my tree.

Kevin

Re: [PATCH 0/2] Remove deprecated qemu-img backing file without format
Posted by Connor Kuehl 4 years, 7 months ago
On 5/3/21 2:35 PM, Eric Blake wrote:
> We've gone enough release cycles without noticeable pushback on our
> intentions, so time to make it harder to create images that can form a
> security hole due to a need for format probing rather than an explicit
> format.
> 
> Eric Blake (2):
>   qcow2: Prohibit backing file changes in 'qemu-img amend'
>   qemu-img: Require -F with -b backing image
> 
>  docs/system/deprecated.rst       | 32 ---------------------------
>  docs/system/removed-features.rst | 31 ++++++++++++++++++++++++++
>  block.c                          | 37 ++++++++++----------------------
>  block/qcow2.c                    | 13 ++++-------
>  qemu-img.c                       |  6 ++++--
>  tests/qemu-iotests/061           |  3 +++
>  tests/qemu-iotests/061.out       |  3 ++-
>  tests/qemu-iotests/082.out       |  6 ++++--
>  tests/qemu-iotests/114           | 18 ++++++++--------
>  tests/qemu-iotests/114.out       | 11 ++++------
>  tests/qemu-iotests/301           |  4 +---
>  tests/qemu-iotests/301.out       | 16 ++------------
>  12 files changed, 75 insertions(+), 105 deletions(-)
> 

For the series + the squash attached to patch 2:

Reviewed-by: Connor Kuehl <ckuehl@redhat.com>