[v3] hw/sparc/sun4m: Introduce Sun4mMachineClass to access sun4m_hwdefs

[PATCH v3 0/6] hw/sparc/sun4m: Introduce Sun4mMachineClass to access sun4m_hwdefs

Philippe Mathieu-Daudé posted 6 patches 2 years, 11 months ago

Diff against v1 v2
Download series mbox

Test checkpatch passed

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20210503171303.822501-1-f4bug@amsat.org

hw/sparc/sun4m.c | 459 +++++++++++++++++++----------------------------
1 file changed, 186 insertions(+), 273 deletions(-)

Expand all Fold all

[PATCH v3 0/6] hw/sparc/sun4m: Introduce Sun4mMachineClass to access sun4m_hwdefs

Posted by Philippe Mathieu-Daudé 2 years, 11 months ago

Missing review: 6

Hi Mark,

This series QOM'ify the sun4m machines.
I need it for a further memory maxsize check.
It is mostly code movement (and the diff-stat is good).

Since v2:
- use static const variable for hwdef (Richard)
- added Richard's R-b tag

Since v1:
- Full rewrite after Mark review

Philippe Mathieu-Daudé (6):
  hw/sparc/sun4m: Have sun4m machines inherit new TYPE_SUN4M_MACHINE
  hw/sparc/sun4m: Introduce Sun4mMachineClass
  hw/sparc/sun4m: Factor out sun4m_machine_class_init()
  hw/sparc/sun4m: Register machine types in sun4m_machine_types[]
  hw/sparc/sun4m: Fix code style for checkpatch.pl
  hw/sparc/sun4m: Move each sun4m_hwdef definition in its class_init

 hw/sparc/sun4m.c | 459 +++++++++++++++++++----------------------------
 1 file changed, 186 insertions(+), 273 deletions(-)

-- 
2.26.3

Re: [PATCH v3 0/6] hw/sparc/sun4m: Introduce Sun4mMachineClass to access sun4m_hwdefs

Posted by Mark Cave-Ayland 2 years, 11 months ago

On 03/05/2021 18:12, Philippe Mathieu-Daudé wrote:

> Missing review: 6
> 
> Hi Mark,
> 
> This series QOM'ify the sun4m machines.
> I need it for a further memory maxsize check.
> It is mostly code movement (and the diff-stat is good).
> 
> Since v2:
> - use static const variable for hwdef (Richard)
> - added Richard's R-b tag
> 
> Since v1:
> - Full rewrite after Mark review
> 
> Philippe Mathieu-Daudé (6):
>    hw/sparc/sun4m: Have sun4m machines inherit new TYPE_SUN4M_MACHINE
>    hw/sparc/sun4m: Introduce Sun4mMachineClass
>    hw/sparc/sun4m: Factor out sun4m_machine_class_init()
>    hw/sparc/sun4m: Register machine types in sun4m_machine_types[]
>    hw/sparc/sun4m: Fix code style for checkpatch.pl
>    hw/sparc/sun4m: Move each sun4m_hwdef definition in its class_init
> 
>   hw/sparc/sun4m.c | 459 +++++++++++++++++++----------------------------
>   1 file changed, 186 insertions(+), 273 deletions(-)

Looks good to me:

Reviewed-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>

I've also queued this to my qemu-sparc branch.


ATB,

Mark.