[v3] hw: Convert mc146818rtc & etraxfs_timer to 3-phase reset interface

[PATCH v3 0/2] hw: Convert mc146818rtc & etraxfs_timer to 3-phase reset interface

Posted by Philippe Mathieu-Daudé 3 years ago

Remove qemu_register_reset() when a qdev type has a qbus parent,
implementing the 3-phase Resettable interface.

Since v2:
- Lower IRQ in 'hold' phase, not 'exit' one (Edgar)

Since v1:
- Use 3-phase reset interface instead of qdev one (Laurent)

Supersedes: <20210423233652.3042941-1-f4bug@amsat.org>

Philippe Mathieu-Daudé (2):
  hw/timer/etraxfs_timer: Convert to 3-phase reset (Resettable
    interface)
  hw/rtc/mc146818rtc: Convert to 3-phase reset (Resettable interface)

 hw/rtc/mc146818rtc.c     | 42 +++++++++++++++++++++-------------------
 hw/timer/etraxfs_timer.c | 14 +++++++++++---
 2 files changed, 33 insertions(+), 23 deletions(-)

-- 
2.26.3

Re: [PATCH v3 0/2] hw: Convert mc146818rtc & etraxfs_timer to 3-phase reset interface

Posted by Philippe Mathieu-Daudé 2 years, 11 months ago

Hi Laurent,

I addressed your comments from v1, and this series is
now reviewed. Can it get merged via your qemu-trivial tree?

On 5/2/21 6:39 PM, Philippe Mathieu-Daudé wrote:
> Remove qemu_register_reset() when a qdev type has a qbus parent,
> implementing the 3-phase Resettable interface.
> 
> Since v2:
> - Lower IRQ in 'hold' phase, not 'exit' one (Edgar)
> 
> Since v1:
> - Use 3-phase reset interface instead of qdev one (Laurent)
> 
> Supersedes: <20210423233652.3042941-1-f4bug@amsat.org>
> 
> Philippe Mathieu-Daudé (2):
>   hw/timer/etraxfs_timer: Convert to 3-phase reset (Resettable
>     interface)
>   hw/rtc/mc146818rtc: Convert to 3-phase reset (Resettable interface)
> 
>  hw/rtc/mc146818rtc.c     | 42 +++++++++++++++++++++-------------------
>  hw/timer/etraxfs_timer.c | 14 +++++++++++---
>  2 files changed, 33 insertions(+), 23 deletions(-)
>

Re: [PATCH v3 0/2] hw: Convert mc146818rtc & etraxfs_timer to 3-phase reset interface

Posted by Laurent Vivier 2 years, 11 months ago

Le 11/05/2021 à 05:29, Philippe Mathieu-Daudé a écrit :
> Hi Laurent,
> 
> I addressed your comments from v1, and this series is
> now reviewed. Can it get merged via your qemu-trivial tree?

Yes, but next time cc: trivial to be sure ;)

Applied to my trivial-patches branch.

Thanks,
Laurent

> On 5/2/21 6:39 PM, Philippe Mathieu-Daudé wrote:
>> Remove qemu_register_reset() when a qdev type has a qbus parent,
>> implementing the 3-phase Resettable interface.
>>
>> Since v2:
>> - Lower IRQ in 'hold' phase, not 'exit' one (Edgar)
>>
>> Since v1:
>> - Use 3-phase reset interface instead of qdev one (Laurent)
>>
>> Supersedes: <20210423233652.3042941-1-f4bug@amsat.org>
>>
>> Philippe Mathieu-Daudé (2):
>>   hw/timer/etraxfs_timer: Convert to 3-phase reset (Resettable
>>     interface)
>>   hw/rtc/mc146818rtc: Convert to 3-phase reset (Resettable interface)
>>
>>  hw/rtc/mc146818rtc.c     | 42 +++++++++++++++++++++-------------------
>>  hw/timer/etraxfs_timer.c | 14 +++++++++++---
>>  2 files changed, 33 insertions(+), 23 deletions(-)
>>

Re: [PATCH v3 0/2] hw: Convert mc146818rtc & etraxfs_timer to 3-phase reset interface

Posted by Philippe Mathieu-Daudé 2 years, 11 months ago

On 5/13/21 6:03 PM, Laurent Vivier wrote:
> Le 11/05/2021 à 05:29, Philippe Mathieu-Daudé a écrit :
>> Hi Laurent,
>>
>> I addressed your comments from v1, and this series is
>> now reviewed. Can it get merged via your qemu-trivial tree?
> 
> Yes, but next time cc: trivial to be sure ;)

OK, thank you :)

> 
> Applied to my trivial-patches branch.
> 
> Thanks,
> Laurent