bsd-user: minor cleanup patches

[PULL 0/5] bsd-user: minor cleanup patches

Posted by Warner Losh 3 years ago

The following changes since commit ffa090bc56e73e287a63261e70ac02c0970be61a:

  target/s390x: fix s390_probe_access to check PAGE_WRITE_ORG for writeability (2021-04-23 14:10:56 +0100)

are available in the Git repository at:

  https://gitlab.com/bsdimp/qemu.git tags/pull-bsd-user-20210430

for you to fetch changes up to 58b3beb483d08066548d84eccd007b9d8bd24a2b:

  bsd-user: style tweak: Put {} around all if/else/for statements (2021-04-30 09:14:06 -0600)

----------------------------------------------------------------
bsd-user: start to cleanup the mess

A number of small cleanups to get started. All the checkpatch.pl warnings for
bsdload.c have been fixed, as well as a warning from qemu.h (though more remain
and this patch series fails the format check still). I've also fixed a
compile-time warning about a missing break.

----------------------------------------------------------------
Warner Losh (5):
      bsd-user: whitespace changes
      bsd-user: style tweak: keyword space (
      bsd-user: style tweak: return is not a function, eliminate ()
      bsd-user: put back a break; that had gone missing...
      bsd-user: style tweak: Put {} around all if/else/for statements

 bsd-user/bsdload.c | 55 +++++++++++++++++++++++++++---------------------------
 bsd-user/qemu.h    |  4 ++--
 bsd-user/syscall.c |  1 +
 3 files changed, 31 insertions(+), 29 deletions(-)

-- 
2.22.1

Re: [PULL 0/5] bsd-user: minor cleanup patches

Posted by Peter Maydell 3 years ago

On Fri, 30 Apr 2021 at 18:46, Warner Losh <imp@bsdimp.com> wrote:
>
> The following changes since commit ffa090bc56e73e287a63261e70ac02c0970be61a:
>
>   target/s390x: fix s390_probe_access to check PAGE_WRITE_ORG for writeability (2021-04-23 14:10:56 +0100)
>
> are available in the Git repository at:
>
>   https://gitlab.com/bsdimp/qemu.git tags/pull-bsd-user-20210430
>
> for you to fetch changes up to 58b3beb483d08066548d84eccd007b9d8bd24a2b:
>
>   bsd-user: style tweak: Put {} around all if/else/for statements (2021-04-30 09:14:06 -0600)
>
> ----------------------------------------------------------------
> bsd-user: start to cleanup the mess
>
> A number of small cleanups to get started. All the checkpatch.pl warnings for
> bsdload.c have been fixed, as well as a warning from qemu.h (though more remain
> and this patch series fails the format check still). I've also fixed a
> compile-time warning about a missing break.
>
> ----------------------------------------------------------------
> Warner Losh (5):
>       bsd-user: whitespace changes
>       bsd-user: style tweak: keyword space (
>       bsd-user: style tweak: return is not a function, eliminate ()
>       bsd-user: put back a break; that had gone missing...
>       bsd-user: style tweak: Put {} around all if/else/for statements


Applied, thanks.

Please update the changelog at https://wiki.qemu.org/ChangeLog/6.1
for any user-visible changes.

-- PMM