[v3] Base for adding PowerPC 64-bit instructions

[PATCH v3 09/30] target/ppc: Remove special case for POWERPC_EXCP_TRAP

Posted by Richard Henderson 4 years, 9 months ago

Since POWERPC_EXCP_TRAP is raised by gen_exception_err,
we will have also set DISAS_NORETURN.

Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
 target/ppc/translate.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/target/ppc/translate.c b/target/ppc/translate.c
index b26b6964a7..5efa4d6566 100644
--- a/target/ppc/translate.c
+++ b/target/ppc/translate.c
@@ -8079,7 +8079,6 @@ static void ppc_tr_translate_insn(DisasContextBase *dcbase, CPUState *cs)
     /* Check trace mode exceptions */
     if (unlikely(ctx->singlestep_enabled & CPU_SINGLE_STEP &&
                  (ctx->base.pc_next <= 0x100 || ctx->base.pc_next > 0xF00) &&
-                 ctx->exception != POWERPC_EXCP_TRAP &&
                  ctx->exception != POWERPC_EXCP_BRANCH &&
                  ctx->base.is_jmp != DISAS_NORETURN)) {
         uint32_t excp = gen_prep_dbgex(ctx);
-- 
2.25.1

RE: [PATCH v3 09/30] target/ppc: Remove special case for POWERPC_EXCP_TRAP

Posted by Luis Fernando Fujita Pires 4 years, 9 months ago

From: Richard Henderson <richard.henderson@linaro.org>
> Since POWERPC_EXCP_TRAP is raised by gen_exception_err, we will have also
> set DISAS_NORETURN.
> 
> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
> ---
>  target/ppc/translate.c | 1 -
>  1 file changed, 1 deletion(-)

Reviewed-by: Luis Pires <luis.pires@eldorado.org.br>