[PATCH v2 0/7] target/ppc: untangle cpu init from translation

Bruno Larsen (billionai) posted 7 patches 3 years ago
Failed in applying to current master (apply log)
.../ppc/{translate_init.c.inc => cpu_init.c}  | 2298 ++++-------------
target/ppc/internal.h                         |   11 +
target/ppc/meson.build                        |    1 +
target/ppc/spr_tcg.c.inc                      | 1034 ++++++++
target/ppc/spr_tcg.h                          |  121 +
target/ppc/translate.c                        |  447 +++-
6 files changed, 2046 insertions(+), 1866 deletions(-)
rename target/ppc/{translate_init.c.inc => cpu_init.c} (86%)
create mode 100644 target/ppc/spr_tcg.c.inc
create mode 100644 target/ppc/spr_tcg.h
[PATCH v2 0/7] target/ppc: untangle cpu init from translation
Posted by Bruno Larsen (billionai) 3 years ago
This patch series aims to remove the logic of initializing CPU from
the file related to TCG translation. To achieve this, we have to make
it so registering SPRs isn't directly tied to TCG, and move code only
related to translation out of translate_init.c.inc and into translate.c.
This is in preparation to compile this target without TCG.

This series requires the patch proposed in
<20210426184706.48040-1-bruno.larsen@eldorado.org.br>

Changes for v2:
 * split and reordered patches, to make it easier to review
 * improved commit messages 
 * Undid creation of spr_common, as it was unnecessary
 * kept more functions as static
 * ensured that the project builds after every commit

Bruno Larsen (billionai) (7):
  target/ppc: move opcode table logic to translate.c
  target/ppc: Created !TCG SPR registration macro
  target/ppc: Isolated SPR read/write callbacks
  target/ppc: turned SPR R/W callbacks not static
  target/ppc: removed VSCR from SPR registration
  target/ttc: renamed SPR registration functions
  target/ppc: isolated cpu init from translation logic

 .../ppc/{translate_init.c.inc => cpu_init.c}  | 2298 ++++-------------
 target/ppc/internal.h                         |   11 +
 target/ppc/meson.build                        |    1 +
 target/ppc/spr_tcg.c.inc                      | 1034 ++++++++
 target/ppc/spr_tcg.h                          |  121 +
 target/ppc/translate.c                        |  447 +++-
 6 files changed, 2046 insertions(+), 1866 deletions(-)
 rename target/ppc/{translate_init.c.inc => cpu_init.c} (86%)
 create mode 100644 target/ppc/spr_tcg.c.inc
 create mode 100644 target/ppc/spr_tcg.h

-- 
2.17.1


Re: [PATCH v2 0/7] target/ppc: untangle cpu init from translation
Posted by Richard Henderson 3 years ago
On 4/29/21 9:21 AM, Bruno Larsen (billionai) wrote:
> This series requires the patch proposed in
> <20210426184706.48040-1-bruno.larsen@eldorado.org.br>

FYI, for the benefit of tooling, use "Based-on: message-id" which will allow 
patchew to construct a patch repository.

As is,

https://patchew.org/QEMU/20210429162130.2412-1-bruno.larsen@eldorado.org.br/

reports "Failed in applying to current master". Compare that to

https://patchew.org/QEMU/20210416210240.1591291-1-richard.henderson@linaro.org/

(which, no coincidence, is the first one I could think of that uses Based-on).


r~