1. Patchew
  2. QEMU
  3. [PATCH v2 0/2] virtiofsd: Meson build fix
  4. View patch

[PATCH v2 2/2] gitlab-ci: Add a job to build virtiofsd standalone

Philippe Mathieu-Daudé posted 2 patches 4 years, 9 months ago
[PATCH v2 2/2] gitlab-ci: Add a job to build virtiofsd standalone
Posted by Philippe Mathieu-Daudé 4 years, 9 months ago 
Add a job which builds virtiofsd without any emulation or tool.

Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
---
https://gitlab.com/philmd/qemu/-/jobs/1222007991
Duration: 7 minutes 48 seconds
---
 .gitlab-ci.yml | 13 +++++++++++++
 1 file changed, 13 insertions(+)

diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml
index 52d65d6c04f..ba3c7ade6ca 100644
--- a/.gitlab-ci.yml
+++ b/.gitlab-ci.yml
@@ -800,6 +800,19 @@ build-libvhost-user:
     - meson
     - ninja
 
+build-virtiofsd-fedora:
+  <<: *native_build_job_definition
+  needs:
+    job: amd64-fedora-container
+  variables:
+    IMAGE: fedora
+    CONFIGURE_ARGS: --enable-virtiofsd
+        --disable-system --disable-user --disable-tools --disable-docs
+  artifacts:
+    expire_in: 2 days
+    paths:
+      - build/tools/virtiofsd/virtiofsd
+
 # No targets are built here, just tools, docs, and unit tests. This
 # also feeds into the eventual documentation deployment steps later
 build-tools-and-docs-debian:
-- 
2.26.3
Re: [PATCH v2 2/2] gitlab-ci: Add a job to build virtiofsd standalone
Posted by Daniel P. Berrangé 4 years, 9 months ago 
On Thu, Apr 29, 2021 at 10:33:46AM +0200, Philippe Mathieu-Daudé wrote:
> Add a job which builds virtiofsd without any emulation or tool.
> 
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---
> https://gitlab.com/philmd/qemu/-/jobs/1222007991
> Duration: 7 minutes 48 seconds
> ---
>  .gitlab-ci.yml | 13 +++++++++++++
>  1 file changed, 13 insertions(+)
> 
> diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml
> index 52d65d6c04f..ba3c7ade6ca 100644
> --- a/.gitlab-ci.yml
> +++ b/.gitlab-ci.yml
> @@ -800,6 +800,19 @@ build-libvhost-user:
>      - meson
>      - ninja
>  
> +build-virtiofsd-fedora:
> +  <<: *native_build_job_definition
> +  needs:
> +    job: amd64-fedora-container
> +  variables:
> +    IMAGE: fedora
> +    CONFIGURE_ARGS: --enable-virtiofsd
> +        --disable-system --disable-user --disable-tools --disable-docs
> +  artifacts:
> +    expire_in: 2 days
> +    paths:
> +      - build/tools/virtiofsd/virtiofsd

I'm not convinced that this job is justiable given our need to keep
the total CI pipeline size constrained. The precedent this sets is
that we need to test every configure args combination for each binary
we build. That is not scalable as a pattern. Neither this virtiofsd
arg scenario, nor others is going to be commonly used by downstream
consumers of QEMU, so the payoff from having this job is also small.


Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|
Re: [PATCH v2 2/2] gitlab-ci: Add a job to build virtiofsd standalone
Posted by Philippe Mathieu-Daudé 4 years, 9 months ago 
On 4/29/21 10:43 AM, Daniel P. Berrangé wrote:
> On Thu, Apr 29, 2021 at 10:33:46AM +0200, Philippe Mathieu-Daudé wrote:
>> Add a job which builds virtiofsd without any emulation or tool.
>>
>> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
>> ---
>> https://gitlab.com/philmd/qemu/-/jobs/1222007991
>> Duration: 7 minutes 48 seconds
>> ---
>>  .gitlab-ci.yml | 13 +++++++++++++
>>  1 file changed, 13 insertions(+)
>>
>> diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml
>> index 52d65d6c04f..ba3c7ade6ca 100644
>> --- a/.gitlab-ci.yml
>> +++ b/.gitlab-ci.yml
>> @@ -800,6 +800,19 @@ build-libvhost-user:
>>      - meson
>>      - ninja
>>  
>> +build-virtiofsd-fedora:
>> +  <<: *native_build_job_definition
>> +  needs:
>> +    job: amd64-fedora-container
>> +  variables:
>> +    IMAGE: fedora
>> +    CONFIGURE_ARGS: --enable-virtiofsd
>> +        --disable-system --disable-user --disable-tools --disable-docs
>> +  artifacts:
>> +    expire_in: 2 days
>> +    paths:
>> +      - build/tools/virtiofsd/virtiofsd
> 
> I'm not convinced that this job is justiable given our need to keep
> the total CI pipeline size constrained. The precedent this sets is
> that we need to test every configure args combination for each binary
> we build. That is not scalable as a pattern. Neither this virtiofsd
> arg scenario, nor others is going to be commonly used by downstream
> consumers of QEMU, so the payoff from having this job is also small.

I'm not sure "our current pipelines is too busy because we don't have
a clear idea what is tested and what is duplicated" justifies no more
tests can be added, but it is a effective way to have the current set
cleaned.

Anyhow, if mainstream isn't interested by this configuration, it could
be added to the virtio-fs/qemu fork. Alternatively mainstream with:

  only:
    variables:
      - $CI_PROJECT_NAMESPACE == 'virtio-fs'
Re: [PATCH v2 2/2] gitlab-ci: Add a job to build virtiofsd standalone
Posted by Wainer dos Santos Moschetta 4 years, 9 months ago 
Hi,

On 4/29/21 5:33 AM, Philippe Mathieu-Daudé wrote:
> Add a job which builds virtiofsd without any emulation or tool.
>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---
> https://gitlab.com/philmd/qemu/-/jobs/1222007991
> Duration: 7 minutes 48 seconds
> ---
>   .gitlab-ci.yml | 13 +++++++++++++
>   1 file changed, 13 insertions(+)
>
> diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml
> index 52d65d6c04f..ba3c7ade6ca 100644
> --- a/.gitlab-ci.yml
> +++ b/.gitlab-ci.yml
> @@ -800,6 +800,19 @@ build-libvhost-user:
>       - meson
>       - ninja
>   
> +build-virtiofsd-fedora:
> +  <<: *native_build_job_definition
> +  needs:
> +    job: amd64-fedora-container
> +  variables:
> +    IMAGE: fedora
> +    CONFIGURE_ARGS: --enable-virtiofsd
> +        --disable-system --disable-user --disable-tools --disable-docs
> +  artifacts:
> +    expire_in: 2 days
> +    paths:
> +      - build/tools/virtiofsd/virtiofsd
> +

Why it needs the executable archived?

- Wainer

>   # No targets are built here, just tools, docs, and unit tests. This
>   # also feeds into the eventual documentation deployment steps later
>   build-tools-and-docs-debian:
Re: [PATCH v2 2/2] gitlab-ci: Add a job to build virtiofsd standalone
Posted by Philippe Mathieu-Daudé 4 years, 9 months ago 
On 4/29/21 3:16 PM, Wainer dos Santos Moschetta wrote:
> Hi,
> 
> On 4/29/21 5:33 AM, Philippe Mathieu-Daudé wrote:
>> Add a job which builds virtiofsd without any emulation or tool.
>>
>> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
>> ---
>> https://gitlab.com/philmd/qemu/-/jobs/1222007991
>> Duration: 7 minutes 48 seconds
>> ---
>>   .gitlab-ci.yml | 13 +++++++++++++
>>   1 file changed, 13 insertions(+)
>>
>> diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml
>> index 52d65d6c04f..ba3c7ade6ca 100644
>> --- a/.gitlab-ci.yml
>> +++ b/.gitlab-ci.yml
>> @@ -800,6 +800,19 @@ build-libvhost-user:
>>       - meson
>>       - ninja
>>   +build-virtiofsd-fedora:
>> +  <<: *native_build_job_definition
>> +  needs:
>> +    job: amd64-fedora-container
>> +  variables:
>> +    IMAGE: fedora
>> +    CONFIGURE_ARGS: --enable-virtiofsd
>> +        --disable-system --disable-user --disable-tools --disable-docs
>> +  artifacts:
>> +    expire_in: 2 days
>> +    paths:
>> +      - build/tools/virtiofsd/virtiofsd
>> +
> 
> Why it needs the executable archived?

I assumed if there were testing jobs as next stage, this is what they
would consume? I copy/pasted from another job and adapted, but you are
right, it is pointless. AnyhowI understood this job has been discarded
during review.

Thanks for having a look!

Phil.

Patchew 2.1-devel-b67e4c2

© 2016 - 2026 Red Hat, Inc.