[PATCH v6 0/9] vhost-vdpa: add support for configure interrupt

Cindy Lu posted 9 patches 3 years ago
Test checkpatch failed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20210427033951.29805-1-lulu@redhat.com
Maintainers: Gerd Hoffmann <kraxel@redhat.com>, "Marc-André Lureau" <marcandre.lureau@redhat.com>, "Dr. David Alan Gilbert" <dgilbert@redhat.com>, Cornelia Huck <cohuck@redhat.com>, Jason Wang <jasowang@redhat.com>, "Gonglei (Arei)" <arei.gonglei@huawei.com>, David Hildenbrand <david@redhat.com>, "Michael S. Tsirkin" <mst@redhat.com>, Halil Pasic <pasic@linux.ibm.com>, Thomas Huth <thuth@redhat.com>, Richard Henderson <richard.henderson@linaro.org>, Christian Borntraeger <borntraeger@de.ibm.com>, Stefan Hajnoczi <stefanha@redhat.com>
There is a newer version of this series
hw/display/vhost-user-gpu.c       |   8 +-
hw/net/vhost_net.c                |   9 ++
hw/net/virtio-net.c               |  20 ++-
hw/s390x/virtio-ccw.c             |   6 +-
hw/virtio/trace-events            |   2 +
hw/virtio/vhost-user-fs.c         |  11 +-
hw/virtio/vhost-vdpa.c            |   7 +
hw/virtio/vhost-vsock-common.c    |   8 +-
hw/virtio/vhost.c                 |  70 +++++++++-
hw/virtio/virtio-crypto.c         |   8 +-
hw/virtio/virtio-mmio.c           |  30 ++++-
hw/virtio/virtio-pci.c            | 212 +++++++++++++++++++-----------
hw/virtio/virtio.c                |  37 ++++--
include/hw/virtio/vhost-backend.h |   3 +
include/hw/virtio/vhost.h         |   3 +
include/hw/virtio/virtio.h        |   4 +-
include/net/vhost_net.h           |   3 +
17 files changed, 336 insertions(+), 105 deletions(-)
[PATCH v6 0/9] vhost-vdpa: add support for configure interrupt
Posted by Cindy Lu 3 years ago
these patches are add the support for configure interrupt 

These code are all tested in vp-vdpa (support configure interrupt)
vdpa_sim (not support configure interrupt)

test in virtio-pci bus and virtio-mmio bus

Change in v2:
Add support for virtio-mmio bus
active the notifier while the backend support configure interrupt
misc fixes form v1

Change in v3
fix the coding style problems

Change in v4
misc fixes form v3
merge the set_config_notifier to set_guest_notifier
when vdpa start, check the feature by VIRTIO_NET_F_STATUS 

Change in v5
misc fixes form v4
split the code for introduce configure interrupt type and callback function 
will init the configure interrupt in all virtio-pci and virtio-mmio bus, but will 
only active while using vhost-vdpa driver

Change in v6
misc fixes form v5
decouple virtqueue from interrupt setting and misc process
fix the bug in virtio_net_handle_rx
use -1 as the queue number to identify if the interrupt is configure interrupt

Cindy Lu (9):
  hw: Add check for queue number
  virtio-pci:decouple virtqueue from interrupt setting process
  vhost: add new call back function for config interrupt
  vhost-vdpa: add support for config interrupt call back
  vhost:add support for configure interrupt
  virtio-mmio: add support for configure interrupt
  virtio-pci: add support for configure interrupt
  virtio: decouple virtqueue from set notifier fd handler
  virtio-net: add peer_deleted check in virtio_net_handle_rx

 hw/display/vhost-user-gpu.c       |   8 +-
 hw/net/vhost_net.c                |   9 ++
 hw/net/virtio-net.c               |  20 ++-
 hw/s390x/virtio-ccw.c             |   6 +-
 hw/virtio/trace-events            |   2 +
 hw/virtio/vhost-user-fs.c         |  11 +-
 hw/virtio/vhost-vdpa.c            |   7 +
 hw/virtio/vhost-vsock-common.c    |   8 +-
 hw/virtio/vhost.c                 |  70 +++++++++-
 hw/virtio/virtio-crypto.c         |   8 +-
 hw/virtio/virtio-mmio.c           |  30 ++++-
 hw/virtio/virtio-pci.c            | 212 +++++++++++++++++++-----------
 hw/virtio/virtio.c                |  37 ++++--
 include/hw/virtio/vhost-backend.h |   3 +
 include/hw/virtio/vhost.h         |   3 +
 include/hw/virtio/virtio.h        |   4 +-
 include/net/vhost_net.h           |   3 +
 17 files changed, 336 insertions(+), 105 deletions(-)

-- 
2.21.3


Re: [PATCH v6 0/9] vhost-vdpa: add support for configure interrupt
Posted by no-reply@patchew.org 3 years ago
Patchew URL: https://patchew.org/QEMU/20210427033951.29805-1-lulu@redhat.com/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: 20210427033951.29805-1-lulu@redhat.com
Subject: [PATCH v6 0/9] vhost-vdpa: add support for configure interrupt

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 - [tag update]      patchew/20210424162229.3312116-1-f4bug@amsat.org -> patchew/20210424162229.3312116-1-f4bug@amsat.org
 * [new tag]         patchew/20210427033951.29805-1-lulu@redhat.com -> patchew/20210427033951.29805-1-lulu@redhat.com
Switched to a new branch 'test'
75b5f19 virtio-net: add peer_deleted check in virtio_net_handle_rx
e6c2a2d virtio: decouple virtqueue from set notifier fd handler
d7e3243 virtio-pci: add support for configure interrupt
55946c5 virtio-mmio: add support for configure interrupt
0e8ea81 vhost:add support for configure interrupt
665e11d vhost-vdpa: add support for config interrupt call back
e83f793 vhost: add new call back function for config interrupt
3ce0821 virtio-pci:decouple virtqueue from interrupt setting process
d4debe8 hw: Add check for queue number

=== OUTPUT BEGIN ===
1/9 Checking commit d4debe818e21 (hw: Add check for queue number)
2/9 Checking commit 3ce082180cca (virtio-pci:decouple virtqueue from interrupt setting process)
3/9 Checking commit e83f7938542d (vhost: add new call back function for config interrupt)
4/9 Checking commit 665e11d3c98f (vhost-vdpa: add support for config interrupt call back)
5/9 Checking commit 0e8ea81cf5a0 (vhost:add support for configure interrupt)
6/9 Checking commit 55946c55ee11 (virtio-mmio: add support for configure interrupt)
7/9 Checking commit d7e3243f82ec (virtio-pci: add support for configure interrupt)
ERROR: Missing Signed-off-by: line(s)

total: 1 errors, 0 warnings, 266 lines checked

Patch 7/9 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

8/9 Checking commit e6c2a2d36bce (virtio: decouple virtqueue from set notifier fd handler)
9/9 Checking commit 75b5f193ac32 (virtio-net: add peer_deleted check in virtio_net_handle_rx)
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/20210427033951.29805-1-lulu@redhat.com/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com