Alpha had two bugs, one with the non-ka_restorer fallback
using the wrong offset, and the other with the ka_restorer
value getting lost in do_sigaction.

Sparc had another bug, where the ka_restorer field was
written to user memory.

Version 2 splits patch 2 into 6.


r~


Richard Henderson (7):
  linux-user/alpha: Fix rt sigframe return
  linux-user/alpha: Rename the sigaction restorer field
  linux-user: Pass ka_restorer to do_sigaction
  linux-user: Honor TARGET_ARCH_HAS_SA_RESTORER in do_syscall
  linux-user/alpha: Define TARGET_ARCH_HAS_KA_RESTORER
  linux-user/alpha: Share code for TARGET_NR_sigaction
  linux-user: Tidy TARGET_NR_rt_sigaction

 linux-user/alpha/target_signal.h |   1 +
 linux-user/syscall_defs.h        |  29 ++-------
 linux-user/alpha/signal.c        |  10 +--
 linux-user/signal.c              |   5 +-
 linux-user/syscall.c             | 107 ++++++++-----------------------
 5 files changed, 43 insertions(+), 109 deletions(-)

-- 
2.25.1

Patchew URL: https://patchew.org/QEMU/20210422230227.314751-1-richard.henderson@linaro.org/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: 20210422230227.314751-1-richard.henderson@linaro.org
Subject: [PATCH v2 0/7] linux-user: sigaction fixes/cleanups

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 * [new tag]         patchew/20210422230227.314751-1-richard.henderson@linaro.org -> patchew/20210422230227.314751-1-richard.henderson@linaro.org
Switched to a new branch 'test'
9eee746 linux-user: Tidy TARGET_NR_rt_sigaction
46c2541 linux-user/alpha: Share code for TARGET_NR_sigaction
c69776b linux-user/alpha: Define TARGET_ARCH_HAS_KA_RESTORER
de9e5c2 linux-user: Honor TARGET_ARCH_HAS_SA_RESTORER in do_syscall
57bd960 linux-user: Pass ka_restorer to do_sigaction
ef4054e linux-user/alpha: Rename the sigaction restorer field
df4fac9 linux-user/alpha: Fix rt sigframe return

=== OUTPUT BEGIN ===
1/7 Checking commit df4fac977c4c (linux-user/alpha: Fix rt sigframe return)
2/7 Checking commit ef4054e42574 (linux-user/alpha: Rename the sigaction restorer field)
3/7 Checking commit 57bd9604ef18 (linux-user: Pass ka_restorer to do_sigaction)
ERROR: code indent should never use tabs
#64: FILE: linux-user/syscall.c:9019:
+^I    ret = get_errno(do_sigaction(arg1, pact, &oact, 0));$

total: 1 errors, 0 warnings, 97 lines checked

Patch 3/7 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

4/7 Checking commit de9e5c267f85 (linux-user: Honor TARGET_ARCH_HAS_SA_RESTORER in do_syscall)
5/7 Checking commit c69776bf2b07 (linux-user/alpha: Define TARGET_ARCH_HAS_KA_RESTORER)
6/7 Checking commit 46c2541b617d (linux-user/alpha: Share code for TARGET_NR_sigaction)
7/7 Checking commit 9eee7464d318 (linux-user: Tidy TARGET_NR_rt_sigaction)
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/20210422230227.314751-1-richard.henderson@linaro.org/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com

Le 23/04/2021 à 01:02, Richard Henderson a écrit :
> Alpha had two bugs, one with the non-ka_restorer fallback
> using the wrong offset, and the other with the ka_restorer
> value getting lost in do_sigaction.
> 
> Sparc had another bug, where the ka_restorer field was
> written to user memory.
> 
> Version 2 splits patch 2 into 6.
> 
> 
> r~
> 
> 
> Richard Henderson (7):
>   linux-user/alpha: Fix rt sigframe return
>   linux-user/alpha: Rename the sigaction restorer field
>   linux-user: Pass ka_restorer to do_sigaction
>   linux-user: Honor TARGET_ARCH_HAS_SA_RESTORER in do_syscall
>   linux-user/alpha: Define TARGET_ARCH_HAS_KA_RESTORER
>   linux-user/alpha: Share code for TARGET_NR_sigaction
>   linux-user: Tidy TARGET_NR_rt_sigaction
> 
>  linux-user/alpha/target_signal.h |   1 +
>  linux-user/syscall_defs.h        |  29 ++-------
>  linux-user/alpha/signal.c        |  10 +--
>  linux-user/signal.c              |   5 +-
>  linux-user/syscall.c             | 107 ++++++++-----------------------
>  5 files changed, 43 insertions(+), 109 deletions(-)
> 


Applied to my linux-user-for-6.1 branch.

Thanks,
Laurent