[PATCH v6 11/15] qmp: Clarify memory backend properties returned via query-memdev

David Hildenbrand posted 15 patches 4 years, 9 months ago
Maintainers: Markus Armbruster <armbru@redhat.com>, "Daniel P. Berrangé" <berrange@redhat.com>, Eduardo Habkost <ehabkost@redhat.com>, Igor Mammedov <imammedo@redhat.com>, Thomas Huth <huth@tuxfamily.org>, Eric Blake <eblake@redhat.com>, Paolo Bonzini <pbonzini@redhat.com>
There is a newer version of this series
[PATCH v6 11/15] qmp: Clarify memory backend properties returned via query-memdev
Posted by David Hildenbrand 4 years, 9 months ago
We return information on the currently configured memory backends and
don't configure them, so decribe what the currently set properties
express.

Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Suggested-by: Markus Armbruster <armbru@redhat.com>
Cc: Eric Blake <eblake@redhat.com>
Cc: Markus Armbruster <armbru@redhat.com>
Cc: Igor Mammedov <imammedo@redhat.com>
Signed-off-by: David Hildenbrand <david@redhat.com>
---
 qapi/machine.json | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/qapi/machine.json b/qapi/machine.json
index 6e90d463fc..758b901185 100644
--- a/qapi/machine.json
+++ b/qapi/machine.json
@@ -790,11 +790,11 @@
 #
 # @size: memory backend size
 #
-# @merge: enables or disables memory merge support
+# @merge: whether memory merge support is enabled
 #
-# @dump: includes memory backend's memory in a core dump or not
+# @dump: whether memory backend's memory is included in a core dump
 #
-# @prealloc: enables or disables memory preallocation
+# @prealloc: whether memory was preallocated
 #
 # @host-nodes: host nodes for its memory policy
 #
-- 
2.30.2


Re: [PATCH v6 11/15] qmp: Clarify memory backend properties returned via query-memdev
Posted by Markus Armbruster 4 years, 9 months ago
David Hildenbrand <david@redhat.com> writes:

> We return information on the currently configured memory backends and
> don't configure them, so decribe what the currently set properties
> express.
>
> Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> Suggested-by: Markus Armbruster <armbru@redhat.com>
> Cc: Eric Blake <eblake@redhat.com>
> Cc: Markus Armbruster <armbru@redhat.com>
> Cc: Igor Mammedov <imammedo@redhat.com>
> Signed-off-by: David Hildenbrand <david@redhat.com>
> ---
>  qapi/machine.json | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/qapi/machine.json b/qapi/machine.json
> index 6e90d463fc..758b901185 100644
> --- a/qapi/machine.json
> +++ b/qapi/machine.json
> @@ -790,11 +790,11 @@
>  #
>  # @size: memory backend size
>  #
> -# @merge: enables or disables memory merge support
> +# @merge: whether memory merge support is enabled
>  #
> -# @dump: includes memory backend's memory in a core dump or not
> +# @dump: whether memory backend's memory is included in a core dump
>  #
> -# @prealloc: enables or disables memory preallocation
> +# @prealloc: whether memory was preallocated
>  #
>  # @host-nodes: host nodes for its memory policy
>  #

Reviewed-by: Markus Armbruster <armbru@redhat.com>


Re: [PATCH v6 11/15] qmp: Clarify memory backend properties returned via query-memdev
Posted by Eduardo Habkost 4 years, 9 months ago
On Wed, Apr 21, 2021 at 02:26:20PM +0200, David Hildenbrand wrote:
> We return information on the currently configured memory backends and
> don't configure them, so decribe what the currently set properties
> express.
> 
> Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> Suggested-by: Markus Armbruster <armbru@redhat.com>
> Cc: Eric Blake <eblake@redhat.com>
> Cc: Markus Armbruster <armbru@redhat.com>
> Cc: Igor Mammedov <imammedo@redhat.com>
> Signed-off-by: David Hildenbrand <david@redhat.com>

Reviewed-by: Eduardo Habkost <ehabkost@redhat.com>

-- 
Eduardo