Add support for FEAT_TLBIOS and FEAT_TLBIRANGE

[PATCH v7 0/4] Add support for FEAT_TLBIOS and FEAT_TLBIRANGE

Rebecca Cran posted 4 patches 3 years ago

Download series mbox

Test checkpatch passed

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20210414203231.824-1-rebecca@nuviainc.com

Maintainers: Peter Maydell <peter.maydell@linaro.org>, Paolo Bonzini <pbonzini@redhat.com>, Richard Henderson <richard.henderson@linaro.org>

accel/tcg/cputlb.c      | 130 ++++++-
include/exec/exec-all.h |  46 +++
target/arm/cpu.h        |  10 +
target/arm/cpu64.c      |   1 +
target/arm/helper.c     | 371 ++++++++++++++++++++
5 files changed, 555 insertions(+), 3 deletions(-)

Expand all Fold all

[PATCH v7 0/4] Add support for FEAT_TLBIOS and FEAT_TLBIRANGE

Posted by Rebecca Cran 3 years ago

ARMv8.4 adds the mandatory FEAT_TLBIOS and FEAT_TLBIRANGE. 
They provides TLBI maintenance instructions that extend to the Outer
Shareable domain and that apply to a range of input addresses.

Changes from v6 to v7:

o Fixed the tlbi_aa64_rvae1_write the tlbi_aa64_rvae1is_write functions
  to pass the correct value into functions which use an ARMMMUIdx.

o Fixed comments in helper.c which referred to non-existent instructions.

Testing:

o Booted Linux 5.11 - verified the previous assert failure in qemu is
  resolved.
o Ran checkpatch.pl.

Rebecca Cran (4):
  accel/tcg: Add TLB invalidation support for ranges of addresses
  target/arm: Add support for FEAT_TLBIRANGE
  target/arm: Add support for FEAT_TLBIOS
  target/arm: set ID_AA64ISAR0.TLB to 2 for max AARCH64 CPU type

 accel/tcg/cputlb.c      | 130 ++++++-
 include/exec/exec-all.h |  46 +++
 target/arm/cpu.h        |  10 +
 target/arm/cpu64.c      |   1 +
 target/arm/helper.c     | 371 ++++++++++++++++++++
 5 files changed, 555 insertions(+), 3 deletions(-)

-- 
2.26.2

Re: [PATCH v7 0/4] Add support for FEAT_TLBIOS and FEAT_TLBIRANGE

Posted by Rebecca Cran 3 years ago

Hi Richard,


Could you review this patch series again please?

I've fixed several issues recently, and am interested to know if it's 
ready to commit or would need further changes.


-- 

Rebecca Cran


On 4/14/2021 2:32 PM, Rebecca Cran wrote:
> ARMv8.4 adds the mandatory FEAT_TLBIOS and FEAT_TLBIRANGE.
> They provides TLBI maintenance instructions that extend to the Outer
> Shareable domain and that apply to a range of input addresses.
>
> Changes from v6 to v7:
>
> o Fixed the tlbi_aa64_rvae1_write the tlbi_aa64_rvae1is_write functions
>    to pass the correct value into functions which use an ARMMMUIdx.
>
> o Fixed comments in helper.c which referred to non-existent instructions.
>
> Testing:
>
> o Booted Linux 5.11 - verified the previous assert failure in qemu is
>    resolved.
> o Ran checkpatch.pl.
>
> Rebecca Cran (4):
>    accel/tcg: Add TLB invalidation support for ranges of addresses
>    target/arm: Add support for FEAT_TLBIRANGE
>    target/arm: Add support for FEAT_TLBIOS
>    target/arm: set ID_AA64ISAR0.TLB to 2 for max AARCH64 CPU type
>
>   accel/tcg/cputlb.c      | 130 ++++++-
>   include/exec/exec-all.h |  46 +++
>   target/arm/cpu.h        |  10 +
>   target/arm/cpu64.c      |   1 +
>   target/arm/helper.c     | 371 ++++++++++++++++++++
>   5 files changed, 555 insertions(+), 3 deletions(-)
>