virtiofsd: Enable xattr if xattrmap is used

[PATCH 0/2] virtiofsd: Enable xattr if xattrmap is used

Posted by Carlos Venegas 3 years ago

Using xattrmap for Kata Containers we found that xattr is should be used
or xattrmap wont work.  These patches enable xattr when -o xattrmap is
used. Also, they add help for the xattrmap  option on `virtiofsd --help` output.

Carlos Venegas (2):
  virtiofsd: Allow use "-o xattrmap" without "-o xattr"
  virtiofsd: Add help for -o xattr-mapping

 tools/virtiofsd/helper.c         | 3 +++
 tools/virtiofsd/passthrough_ll.c | 1 +
 2 files changed, 4 insertions(+)

-- 
2.25.1

Re: [PATCH 0/2] virtiofsd: Enable xattr if xattrmap is used

Posted by Connor Kuehl 3 years ago

On Wed Apr 14, 2021 at 3:12 PM CDT, Carlos Venegas wrote:
>
> Using xattrmap for Kata Containers we found that xattr is should be used
> or xattrmap wont work. These patches enable xattr when -o xattrmap is
> used. Also, they add help for the xattrmap option on `virtiofsd --help`
> output.
>
> Carlos Venegas (2):
> virtiofsd: Allow use "-o xattrmap" without "-o xattr"
> virtiofsd: Add help for -o xattr-mapping

Good usability improvement.

For the series:

Reviewed-by: Connor Kuehl <ckuehl@redhat.com>

Re: [PATCH 0/2] virtiofsd: Enable xattr if xattrmap is used

Posted by Dr. David Alan Gilbert 3 years ago

* Carlos Venegas (jose.carlos.venegas.munoz@intel.com) wrote:
> 
> Using xattrmap for Kata Containers we found that xattr is should be used
> or xattrmap wont work.  These patches enable xattr when -o xattrmap is
> used. Also, they add help for the xattrmap  option on `virtiofsd --help` output.

Queued.  You might like to submit some more patches to give the error
that Greg was suggesting and/or update some docs.

Dave

> Carlos Venegas (2):
>   virtiofsd: Allow use "-o xattrmap" without "-o xattr"
>   virtiofsd: Add help for -o xattr-mapping
> 
>  tools/virtiofsd/helper.c         | 3 +++
>  tools/virtiofsd/passthrough_ll.c | 1 +
>  2 files changed, 4 insertions(+)
> 
> -- 
> 2.25.1
> 
> 
-- 
Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK

RE: [PATCH 0/2] virtiofsd: Enable xattr if xattrmap is used

Posted by Venegas Munoz, Jose Carlos 3 years ago

Thank you both for the suggestions, I had not took a look recently, I will check today in my afternoon.

Cheers.

> -----Original Message-----
> From: Dr. David Alan Gilbert <dgilbert@redhat.com>
> Sent: Thursday, May 6, 2021 10:53 AM
> To: Venegas Munoz, Jose Carlos <jose.carlos.venegas.munoz@intel.com>
> Cc: virtio-fs@redhat.com; qemu-devel@nongnu.org; vgoyal@redhat.com
> Subject: Re: [PATCH 0/2] virtiofsd: Enable xattr if xattrmap is used
> 
> * Carlos Venegas (jose.carlos.venegas.munoz@intel.com) wrote:
> >
> > Using xattrmap for Kata Containers we found that xattr is should be
> > used or xattrmap wont work.  These patches enable xattr when -o
> > xattrmap is used. Also, they add help for the xattrmap  option on `virtiofsd -
> -help` output.
> 
> Queued.  You might like to submit some more patches to give the error that
> Greg was suggesting and/or update some docs.
> 
> Dave
> 
> > Carlos Venegas (2):
> >   virtiofsd: Allow use "-o xattrmap" without "-o xattr"
> >   virtiofsd: Add help for -o xattr-mapping
> >
> >  tools/virtiofsd/helper.c         | 3 +++
> >  tools/virtiofsd/passthrough_ll.c | 1 +
> >  2 files changed, 4 insertions(+)
> >
> > --
> > 2.25.1
> >
> >
> --
> Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK