vhost-vdpa: Make vhost_vdpa_get_device_id() static

[PATCH] vhost-vdpa: Make vhost_vdpa_get_device_id() static

Posted by Zenghui Yu 4 years, 7 months ago

As it's only used inside hw/virtio/vhost-vdpa.c.

Signed-off-by: Zenghui Yu <yuzenghui@huawei.com>
---
 hw/virtio/vhost-vdpa.c         | 4 ++--
 include/hw/virtio/vhost-vdpa.h | 2 --
 2 files changed, 2 insertions(+), 4 deletions(-)

diff --git a/hw/virtio/vhost-vdpa.c b/hw/virtio/vhost-vdpa.c
index 01d2101d09..8f2fb9f10b 100644
--- a/hw/virtio/vhost-vdpa.c
+++ b/hw/virtio/vhost-vdpa.c
@@ -371,8 +371,8 @@ static int vhost_vdpa_set_backend_cap(struct vhost_dev *dev)
     return 0;
 }
 
-int vhost_vdpa_get_device_id(struct vhost_dev *dev,
-                                   uint32_t *device_id)
+static int vhost_vdpa_get_device_id(struct vhost_dev *dev,
+                                    uint32_t *device_id)
 {
     int ret;
     ret = vhost_vdpa_call(dev, VHOST_VDPA_GET_DEVICE_ID, device_id);
diff --git a/include/hw/virtio/vhost-vdpa.h b/include/hw/virtio/vhost-vdpa.h
index 9b81a409da..28ca65018e 100644
--- a/include/hw/virtio/vhost-vdpa.h
+++ b/include/hw/virtio/vhost-vdpa.h
@@ -22,6 +22,4 @@ typedef struct vhost_vdpa {
 } VhostVDPA;
 
 extern AddressSpace address_space_memory;
-extern int vhost_vdpa_get_device_id(struct vhost_dev *dev,
-                                   uint32_t *device_id);
 #endif
-- 
2.19.1

Re: [PATCH] vhost-vdpa: Make vhost_vdpa_get_device_id() static

Posted by Philippe Mathieu-Daudé 4 years, 7 months ago

On 4/13/21 3:37 PM, Zenghui Yu wrote:
> As it's only used inside hw/virtio/vhost-vdpa.c.
> 
> Signed-off-by: Zenghui Yu <yuzenghui@huawei.com>
> ---
>  hw/virtio/vhost-vdpa.c         | 4 ++--
>  include/hw/virtio/vhost-vdpa.h | 2 --
>  2 files changed, 2 insertions(+), 4 deletions(-)

Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>

Re: [PATCH] vhost-vdpa: Make vhost_vdpa_get_device_id() static

Posted by Stefano Garzarella 4 years, 7 months ago

On Tue, Apr 13, 2021 at 09:37:37PM +0800, Zenghui Yu wrote:
>As it's only used inside hw/virtio/vhost-vdpa.c.
>
>Signed-off-by: Zenghui Yu <yuzenghui@huawei.com>
>---
> hw/virtio/vhost-vdpa.c         | 4 ++--
> include/hw/virtio/vhost-vdpa.h | 2 --
> 2 files changed, 2 insertions(+), 4 deletions(-)

Reviewed-by: Stefano Garzarella <sgarzare@redhat.com>

>
>diff --git a/hw/virtio/vhost-vdpa.c b/hw/virtio/vhost-vdpa.c
>index 01d2101d09..8f2fb9f10b 100644
>--- a/hw/virtio/vhost-vdpa.c
>+++ b/hw/virtio/vhost-vdpa.c
>@@ -371,8 +371,8 @@ static int vhost_vdpa_set_backend_cap(struct vhost_dev *dev)
>     return 0;
> }
>
>-int vhost_vdpa_get_device_id(struct vhost_dev *dev,
>-                                   uint32_t *device_id)
>+static int vhost_vdpa_get_device_id(struct vhost_dev *dev,
>+                                    uint32_t *device_id)
> {
>     int ret;
>     ret = vhost_vdpa_call(dev, VHOST_VDPA_GET_DEVICE_ID, device_id);
>diff --git a/include/hw/virtio/vhost-vdpa.h b/include/hw/virtio/vhost-vdpa.h
>index 9b81a409da..28ca65018e 100644
>--- a/include/hw/virtio/vhost-vdpa.h
>+++ b/include/hw/virtio/vhost-vdpa.h
>@@ -22,6 +22,4 @@ typedef struct vhost_vdpa {
> } VhostVDPA;
>
> extern AddressSpace address_space_memory;
>-extern int vhost_vdpa_get_device_id(struct vhost_dev *dev,
>-                                   uint32_t *device_id);
> #endif
>-- 
>2.19.1
>
>