target/mips: Fix TCG temporary leak in gen_cache_operation()

[PATCH-for-6.0?] target/mips: Fix TCG temporary leak in gen_cache_operation()

Philippe Mathieu-Daudé posted 1 patch 3 years ago

Download mbox

Test checkpatch passed

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20210406202857.1440744-1-f4bug@amsat.org

Maintainers: Aleksandar Rikalo <aleksandar.rikalo@syrmia.com>, Jiaxun Yang <jiaxun.yang@flygoat.com>, Aurelien Jarno <aurelien@aurel32.net>, "Philippe Mathieu-Daudé" <f4bug@amsat.org>

target/mips/translate.c | 2 ++
1 file changed, 2 insertions(+)

Expand all Fold all

[PATCH-for-6.0?] target/mips: Fix TCG temporary leak in gen_cache_operation()

Posted by Philippe Mathieu-Daudé 3 years ago

Fix a TCG temporary leak when translating CACHE opcode.

Fixes: 0d74a222c27 ("make ITC Configuration Tags accessible to the CPU")
Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
---
 target/mips/translate.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/target/mips/translate.c b/target/mips/translate.c
index c518bf3963b..71fa5ec1973 100644
--- a/target/mips/translate.c
+++ b/target/mips/translate.c
@@ -12804,6 +12804,8 @@ static void gen_cache_operation(DisasContext *ctx, uint32_t op, int base,
     TCGv t1 = tcg_temp_new();
     gen_base_offset_addr(ctx, t1, base, offset);
     gen_helper_cache(cpu_env, t1, t0);
+    tcg_temp_free(t1);
+    tcg_temp_free_i32(t0);
 }
 
 #if defined(TARGET_MIPS64)
-- 
2.26.3

Re: [PATCH-for-6.0?] target/mips: Fix TCG temporary leak in gen_cache_operation()

Posted by Richard Henderson 3 years ago

On 4/6/21 1:28 PM, Philippe Mathieu-Daudé wrote:
> Fix a TCG temporary leak when translating CACHE opcode.
> 
> Fixes: 0d74a222c27 ("make ITC Configuration Tags accessible to the CPU")
> Signed-off-by: Philippe Mathieu-Daudé<f4bug@amsat.org>
> ---
>   target/mips/translate.c | 2 ++
>   1 file changed, 2 insertions(+)

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>


r~