On Thu, Apr 01, 2021 at 03:28:13PM +0200, Max Reitz wrote:
> (Alternative to: “iotests/qsd-jobs: Filter events in the first test”)
>
> Hi,
>
> The qsd-jobs test has kind of unreliable output, because sometimes the
> job is ready before ‘quit’, and sometimes it is not. This series
> presents one approach to fix that, which is to extend common.qemu to
> allow running the storage daemon instead of qemu, and then to use that
> in qsd-jobs to wait for the BLOCK_JOB_READY event before issuing the
> ‘quit’ command.
>
> I took patch 1 from my “qcow2: Improve refcount structure rebuilding”
> series.
> (https://lists.nongnu.org/archive/html/qemu-block/2021-03/msg00654.html)
>
> As noted above, this series is an alternative to “iotests/qsd-jobs:
> Filter events in the first test”. I like this series here better
> because I’d prefer it if tests that do QMP actually check the output so
> they control what’s really happening.
> On the other hand, this may be too complicated for 6.0, and we might
> want to fix qsd-jobs in 6.0.
>
>
> Max Reitz (2):
> iotests/common.qemu: Allow using the QSD
> iotests/qsd-jobs: Use common.qemu for the QSD
>
> tests/qemu-iotests/common.qemu | 53 +++++++++++++++++++++-----
> tests/qemu-iotests/tests/qsd-jobs | 55 ++++++++++++++++++++-------
> tests/qemu-iotests/tests/qsd-jobs.out | 10 ++++-
> 3 files changed, 92 insertions(+), 26 deletions(-)
>
> --
> 2.29.2
>
Acked-by: Stefan Hajnoczi <stefanha@redhat.com>