[v1] hw/virtio: remove redundant code

[PATCH] hw/virtio: remove redundant code

Wentao Fan posted 1 patch 3 years ago

Diff against v1
Download mbox

Test checkpatch passed

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20210401125808.89241-1-fanwentao.0130@bytedance.com

Maintainers: "Michael S. Tsirkin" <mst@redhat.com>

hw/virtio/virtio.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)

Expand all Fold all

[PATCH] hw/virtio: remove redundant code

Posted by Wentao Fan 3 years ago

From: Fan Wentao <fanwentao.0130@bytedance.com>

Signed-off-by: Wentao Fan <fanwentao.0130@bytedance.com>
---
 hw/virtio/virtio.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/hw/virtio/virtio.c b/hw/virtio/virtio.c
index 07f4e60b30..aa5c283102 100644
--- a/hw/virtio/virtio.c
+++ b/hw/virtio/virtio.c
@@ -173,8 +173,7 @@ static void virtio_init_region_cache(VirtIODevice *vdev, int n)
     }
     new = g_new0(VRingMemoryRegionCaches, 1);
     size = virtio_queue_get_desc_size(vdev, n);
-    packed = virtio_vdev_has_feature(vq->vdev, VIRTIO_F_RING_PACKED) ?
-                                   true : false;
+    packed = virtio_vdev_has_feature(vq->vdev, VIRTIO_F_RING_PACKED);
     len = address_space_cache_init(&new->desc, vdev->dma_as,
                                    addr, size, packed);
     if (len < size) {
-- 
2.24.3 (Apple Git-128)

Re: [PATCH] hw/virtio: remove redundant code

Posted by Jason Wang 3 years ago

在 2021/4/1 下午8:58, Wentao Fan 写道:
> From: Fan Wentao <fanwentao.0130@bytedance.com>
>
> Signed-off-by: Wentao Fan <fanwentao.0130@bytedance.com>


Acked-by: Jason Wang <jasowang@redhat.com>


> ---
>   hw/virtio/virtio.c | 3 +--
>   1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/hw/virtio/virtio.c b/hw/virtio/virtio.c
> index 07f4e60b30..aa5c283102 100644
> --- a/hw/virtio/virtio.c
> +++ b/hw/virtio/virtio.c
> @@ -173,8 +173,7 @@ static void virtio_init_region_cache(VirtIODevice *vdev, int n)
>       }
>       new = g_new0(VRingMemoryRegionCaches, 1);
>       size = virtio_queue_get_desc_size(vdev, n);
> -    packed = virtio_vdev_has_feature(vq->vdev, VIRTIO_F_RING_PACKED) ?
> -                                   true : false;
> +    packed = virtio_vdev_has_feature(vq->vdev, VIRTIO_F_RING_PACKED);
>       len = address_space_cache_init(&new->desc, vdev->dma_as,
>                                      addr, size, packed);
>       if (len < size) {