[v2] migration: Fixes to the 'background-snapshot' code

[PATCH v2 0/3] migration: Fixes to the 'background-snapshot' code

Andrey Gruzdev posted 3 patches 3 years ago

Diff against v1 v1 v1 v1
Download series mbox

Test checkpatch passed

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20210331154809.86052-1-andrey.gruzdev@virtuozzo.com

Maintainers: David Hildenbrand <david@redhat.com>, "Michael S. Tsirkin" <mst@redhat.com>, "Dr. David Alan Gilbert" <dgilbert@redhat.com>, Juan Quintela <quintela@redhat.com>

hw/virtio/virtio-balloon.c |  8 +++++--
include/migration/misc.h   |  2 ++
migration/migration.c      | 22 ++++++++++++++++-
migration/ram.c            | 48 ++++++++++++++++++++++++++++++++++++++
migration/ram.h            |  1 +
5 files changed, 78 insertions(+), 3 deletions(-)

Expand all Fold all

[PATCH v2 0/3] migration: Fixes to the 'background-snapshot' code

Posted by Andrey Gruzdev 3 years ago

Changes v1->v2:
 * Added comment over the overlooked qemu_flush() in bg_migration_thread

Changes v0->v1:
 * Using qemu_real_host_page_size instead of TARGET_PAGE_SIZE for host
   page size in ram_block_populate_pages()
 * More elegant implementation of ram_block_populate_pages()

This patch series contains:
 * Fix to the issue with occasionally truncated non-iterable device state
 * Solution to compatibility issues with virtio-balloon device
 * Fix to the issue when discarded or never populated pages miss UFFD
   write protection and get into migration stream in dirty state

Andrey Gruzdev (3):
  migration: Fix missing qemu_fflush() on buffer file in
    bg_migration_thread
  migration: Inhibit virtio-balloon for the duration of background
    snapshot
  migration: Pre-fault memory before starting background snasphot

 hw/virtio/virtio-balloon.c |  8 +++++--
 include/migration/misc.h   |  2 ++
 migration/migration.c      | 22 ++++++++++++++++-
 migration/ram.c            | 48 ++++++++++++++++++++++++++++++++++++++
 migration/ram.h            |  1 +
 5 files changed, 78 insertions(+), 3 deletions(-)

-- 
2.27.0

Re: [PATCH v2 0/3] migration: Fixes to the 'background-snapshot' code

Posted by Peter Xu 3 years ago

On Wed, Mar 31, 2021 at 06:48:06PM +0300, Andrey Gruzdev wrote:
> Changes v1->v2:
>  * Added comment over the overlooked qemu_flush() in bg_migration_thread
> 
> Changes v0->v1:
>  * Using qemu_real_host_page_size instead of TARGET_PAGE_SIZE for host
>    page size in ram_block_populate_pages()
>  * More elegant implementation of ram_block_populate_pages()
> 
> This patch series contains:
>  * Fix to the issue with occasionally truncated non-iterable device state
>  * Solution to compatibility issues with virtio-balloon device
>  * Fix to the issue when discarded or never populated pages miss UFFD
>    write protection and get into migration stream in dirty state
> 
> Andrey Gruzdev (3):
>   migration: Fix missing qemu_fflush() on buffer file in
>     bg_migration_thread
>   migration: Inhibit virtio-balloon for the duration of background
>     snapshot
>   migration: Pre-fault memory before starting background snasphot

Should this be 6.0-rc material, maybe?

-- 
Peter Xu

Re: [PATCH v2 0/3] migration: Fixes to the 'background-snapshot' code

Posted by Andrey Gruzdev 3 years ago

On 31.03.2021 19:02, Peter Xu wrote:
> On Wed, Mar 31, 2021 at 06:48:06PM +0300, Andrey Gruzdev wrote:
>> Changes v1->v2:
>>   * Added comment over the overlooked qemu_flush() in bg_migration_thread
>>
>> Changes v0->v1:
>>   * Using qemu_real_host_page_size instead of TARGET_PAGE_SIZE for host
>>     page size in ram_block_populate_pages()
>>   * More elegant implementation of ram_block_populate_pages()
>>
>> This patch series contains:
>>   * Fix to the issue with occasionally truncated non-iterable device state
>>   * Solution to compatibility issues with virtio-balloon device
>>   * Fix to the issue when discarded or never populated pages miss UFFD
>>     write protection and get into migration stream in dirty state
>>
>> Andrey Gruzdev (3):
>>    migration: Fix missing qemu_fflush() on buffer file in
>>      bg_migration_thread
>>    migration: Inhibit virtio-balloon for the duration of background
>>      snapshot
>>    migration: Pre-fault memory before starting background snasphot
> Should this be 6.0-rc material, maybe?
>
Ah, yes)


-- 
Andrey Gruzdev, Principal Engineer
Virtuozzo GmbH  +7-903-247-6397
                 virtuzzo.com