Revert "qom: use qemu_printf to print help for user-creatable objects"

[PATCH] Revert "qom: use qemu_printf to print help for user-creatable objects"

Thomas Huth posted 1 patch 3 years, 1 month ago

Download mbox

Test checkpatch passed

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20210328054758.2351461-1-thuth@redhat.com

Maintainers: Paolo Bonzini <pbonzini@redhat.com>, Eduardo Habkost <ehabkost@redhat.com>, "Daniel P. Berrangé" <berrange@redhat.com>

qom/object_interfaces.c | 1 -
1 file changed, 1 deletion(-)

Expand all Fold all

[PATCH] Revert "qom: use qemu_printf to print help for user-creatable objects"

Posted by Thomas Huth 3 years, 1 month ago

This reverts commit 6d9abb6de9cc53a508823db0283061824f2f98a2.

The real code change had already been added by Kevin's commit da0a932bbf
("hmp: QAPIfy object_add") and commit 6d9abb6d just added a duplicated
include statement as a left-over of a rebase.

Signed-off-by: Thomas Huth <thuth@redhat.com>
---
 qom/object_interfaces.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/qom/object_interfaces.c b/qom/object_interfaces.c
index c3324b0f86..b17aa57de1 100644
--- a/qom/object_interfaces.c
+++ b/qom/object_interfaces.c
@@ -17,7 +17,6 @@
 #include "qemu/qemu-print.h"
 #include "qapi/opts-visitor.h"
 #include "qemu/config-file.h"
-#include "qemu/qemu-print.h"
 
 bool user_creatable_complete(UserCreatable *uc, Error **errp)
 {
-- 
2.27.0

Re: [PATCH] Revert "qom: use qemu_printf to print help for user-creatable objects"

Posted by Paolo Bonzini 3 years ago

On 28/03/21 07:47, Thomas Huth wrote:
> This reverts commit 6d9abb6de9cc53a508823db0283061824f2f98a2.
> 
> The real code change had already been added by Kevin's commit da0a932bbf
> ("hmp: QAPIfy object_add") and commit 6d9abb6d just added a duplicated
> include statement as a left-over of a rebase.
> 
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
>   qom/object_interfaces.c | 1 -
>   1 file changed, 1 deletion(-)
> 
> diff --git a/qom/object_interfaces.c b/qom/object_interfaces.c
> index c3324b0f86..b17aa57de1 100644
> --- a/qom/object_interfaces.c
> +++ b/qom/object_interfaces.c
> @@ -17,7 +17,6 @@
>   #include "qemu/qemu-print.h"
>   #include "qapi/opts-visitor.h"
>   #include "qemu/config-file.h"
> -#include "qemu/qemu-print.h"
>   
>   bool user_creatable_complete(UserCreatable *uc, Error **errp)
>   {
> 

Queued, thanks.

Paolo