[PATCH v3 0/5] memory: Add 'priority' property setter

Philippe Mathieu-Daudé posted 5 patches 3 years ago
Test checkpatch passed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20210327143452.1514392-1-f4bug@amsat.org
include/exec/memory.h | 10 ++++++++
softmmu/memory.c      | 56 +++++++++++++++++++++++++++++++++++--------
2 files changed, 56 insertions(+), 10 deletions(-)
[PATCH v3 0/5] memory: Add 'priority' property setter
Posted by Philippe Mathieu-Daudé 3 years ago
The first patch is an old fix, it would be nice to get it
merged eventually, but not a problem during years, so can
also wait 6.1.

The second patch add the memory_region_set_priority() helper
useful to memory controller devices.

The rest add the 'size'/'priority' object setters.

Supersedes: <20180405012241.25714-1-f4bug@amsat.org>
https://www.mail-archive.com/qemu-devel@nongnu.org/msg525635.html

Philippe Mathieu-Daudé (5):
  memory: Fix memory_region 'priority' property sign
  memory: Add memory_region_set_priority()
  memory: Rename MemoryRegion object getters
  memory: Add setter for MemoryRegion object 'size' property
  memory: Add setter for MemoryRegion object 'priority' property

 include/exec/memory.h | 10 ++++++++
 softmmu/memory.c      | 56 +++++++++++++++++++++++++++++++++++--------
 2 files changed, 56 insertions(+), 10 deletions(-)

-- 
2.26.2

Re: [PATCH v3 0/5] memory: Add 'priority' property setter
Posted by Peter Maydell 3 years ago
On Sat, 27 Mar 2021 at 14:34, Philippe Mathieu-Daudé <f4bug@amsat.org> wrote:
>
> The first patch is an old fix, it would be nice to get it
> merged eventually, but not a problem during years, so can
> also wait 6.1.
>
> The second patch add the memory_region_set_priority() helper
> useful to memory controller devices.
>
> The rest add the 'size'/'priority' object setters.

Do you have a series which makes use of these new APIs?

thanks
-- PMM

Re: [PATCH v3 0/5] memory: Add 'priority' property setter
Posted by Philippe Mathieu-Daudé 3 years ago
On 3/27/21 5:58 PM, Peter Maydell wrote:
> On Sat, 27 Mar 2021 at 14:34, Philippe Mathieu-Daudé <f4bug@amsat.org> wrote:
>>
>> The first patch is an old fix, it would be nice to get it
>> merged eventually, but not a problem during years, so can
>> also wait 6.1.
>>
>> The second patch add the memory_region_set_priority() helper
>> useful to memory controller devices.
>>
>> The rest add the 'size'/'priority' object setters.
> 
> Do you have a series which makes use of these new APIs?

Yes, new board / SoC, many patches, I'm trying to split to
have review because I don't expect many developers to review
a series adding 20+ devices... So far:

 87 files changed, 8805 insertions(+), 97 deletions(-)

Part of them already posted:

- hw/misc: Add support for interleaved memory accesses
https://www.mail-archive.com/qemu-devel@nongnu.org/msg730721.html

- memory_region_add_subregion_aliased() helper
https://www.mail-archive.com/qemu-devel@nongnu.org/msg795414.html

I can send an omnibus series if you prefer.

Thanks,

Phil.

Re: [PATCH v3 0/5] memory: Add 'priority' property setter
Posted by Peter Maydell 3 years ago
On Sat, 27 Mar 2021 at 18:44, Philippe Mathieu-Daudé <f4bug@amsat.org> wrote:
>
> On 3/27/21 5:58 PM, Peter Maydell wrote:
> > On Sat, 27 Mar 2021 at 14:34, Philippe Mathieu-Daudé <f4bug@amsat.org> wrote:
> >>
> >> The first patch is an old fix, it would be nice to get it
> >> merged eventually, but not a problem during years, so can
> >> also wait 6.1.
> >>
> >> The second patch add the memory_region_set_priority() helper
> >> useful to memory controller devices.
> >>
> >> The rest add the 'size'/'priority' object setters.
> >
> > Do you have a series which makes use of these new APIs?
>
> Yes, new board / SoC, many patches, I'm trying to split to
> have review because I don't expect many developers to review
> a series adding 20+ devices...

> I can send an omnibus series if you prefer.

No, you don't need to send a series, but a brief description
of the kind of device that would want to be able to dynamically set
MR size and priority would be helpful, I think.

thanks
-- PMM