This series adds a few usability improvements to qemu-iotests, in
particular:

- arguments can be passed to Python unittests scripts, for example
  to run only a subset of the test cases (patches 1-2)

- it is possible to do "./check -- ../../../tests/qemu-iotests/055 args..."
  and specify arbitrary arguments to be passed to a single test script.
  This allows to take advantage of the previous feature and ease debugging
  of Python tests.

Paolo

v2->v3: fix pylint/mypy [Max]
        fix patch 4 for shell-based tests [Emanuele]

Paolo Bonzini (5):
  qemu-iotests: do not buffer the test output
  qemu-iotests: allow passing unittest.main arguments to the test
    scripts
  qemu-iotests: move command line and environment handling from
    TestRunner to TestEnv
  qemu-iotests: let "check" spawn an arbitrary test command
  qemu-iotests: fix case of SOCK_DIR already in the environment

 tests/qemu-iotests/check         | 18 ++++++-
 tests/qemu-iotests/iotests.py    | 80 +++++++++++++++++++-------------
 tests/qemu-iotests/testenv.py    | 22 +++++++--
 tests/qemu-iotests/testrunner.py | 15 +-----
 4 files changed, 85 insertions(+), 50 deletions(-)

-- 
2.30.1

On 26.03.21 15:23, Paolo Bonzini wrote:
> This series adds a few usability improvements to qemu-iotests, in
> particular:
> 
> - arguments can be passed to Python unittests scripts, for example
>    to run only a subset of the test cases (patches 1-2)
> 
> - it is possible to do "./check -- ../../../tests/qemu-iotests/055 args..."
>    and specify arbitrary arguments to be passed to a single test script.
>    This allows to take advantage of the previous feature and ease debugging
>    of Python tests.
> 
> Paolo
Thanks, I’ve amended patch 4 and applied the series to my block branch:

https://git.xanclic.moe/XanClic/qemu/commits/branch/block

Max

On 30.03.21 13:32, Max Reitz wrote:
> On 26.03.21 15:23, Paolo Bonzini wrote:
>> This series adds a few usability improvements to qemu-iotests, in
>> particular:
>>
>> - arguments can be passed to Python unittests scripts, for example
>>    to run only a subset of the test cases (patches 1-2)
>>
>> - it is possible to do "./check -- ../../../tests/qemu-iotests/055 
>> args..."
>>    and specify arbitrary arguments to be passed to a single test script.
>>    This allows to take advantage of the previous feature and ease 
>> debugging
>>    of Python tests.
>>
>> Paolo
> Thanks, I’ve amended patch 4 and applied the series to my block branch:
> 
> https://git.xanclic.moe/XanClic/qemu/commits/branch/block

I’m sorry but I’ll have to drop it again.  At least iotests 245 und 295 
fail; I assume it has something to do with `iotests.activate_logging()`.

I don’t think that’s something that we’ll fix today, so I think we 
should postpone this series to rc2 after all.

Max

On 30/03/21 13:44, Max Reitz wrote:
> On 30.03.21 13:32, Max Reitz wrote:
>> On 26.03.21 15:23, Paolo Bonzini wrote:
>>> This series adds a few usability improvements to qemu-iotests, in
>>> particular:
>>>
>>> - arguments can be passed to Python unittests scripts, for example
>>>    to run only a subset of the test cases (patches 1-2)
>>>
>>> - it is possible to do "./check -- ../../../tests/qemu-iotests/055 
>>> args..."
>>>    and specify arbitrary arguments to be passed to a single test script.
>>>    This allows to take advantage of the previous feature and ease 
>>> debugging
>>>    of Python tests.
>>>
>>> Paolo
>> Thanks, I’ve amended patch 4 and applied the series to my block branch:
>>
>> https://git.xanclic.moe/XanClic/qemu/commits/branch/block
> 
> I’m sorry but I’ll have to drop it again.  At least iotests 245 und 295 
> fail; I assume it has something to do with `iotests.activate_logging()`.

Ok, will look into it.  Can you give me the exact set of ./check 
invocations that you use?

Paolo