1. Patchew
  2. QEMU
  3. View series

[PATCH v1 0/8] GICv3 LPI and ITS feature implementation

Shashi Mallela posted 8 patches 3 years, 1 month ago
Test checkpatch passed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20210323041238.133835-1-shashi.mallela@linaro.org
Maintainers: Radoslaw Biernacki <rad@semihalf.com>, Paolo Bonzini <pbonzini@redhat.com>, Leif Lindholm <leif@nuviainc.com>, Peter Maydell <peter.maydell@linaro.org>
There is a newer version of this series
hw/arm/sbsa-ref.c                      |   26 +-
hw/arm/virt.c                          |   10 +-
hw/intc/arm_gicv3.c                    |    6 +
hw/intc/arm_gicv3_common.c             |   16 +
hw/intc/arm_gicv3_cpuif.c              |   15 +-
hw/intc/arm_gicv3_dist.c               |   22 +-
hw/intc/arm_gicv3_its.c                | 1417 ++++++++++++++++++++
hw/intc/arm_gicv3_its_common.c         |   17 +-
hw/intc/arm_gicv3_its_kvm.c            |    2 +-
hw/intc/arm_gicv3_redist.c             |  155 ++-
hw/intc/gicv3_internal.h               |  176 ++-
hw/intc/meson.build                    |    1 +
include/hw/intc/arm_gicv3_common.h     |   14 +
include/hw/intc/arm_gicv3_its_common.h |   12 +-
target/arm/kvm_arm.h                   |    4 +-
15 files changed, 1869 insertions(+), 24 deletions(-)
create mode 100644 hw/intc/arm_gicv3_its.c
[PATCH v1 0/8] GICv3 LPI and ITS feature implementation
Posted by Shashi Mallela 3 years, 1 month ago 
This patchset implements qemu device model for enabling physical
LPI support and ITS functionality in GIC as per GICv3 specification.
Both flat table and 2 level tables are implemented.The ITS commands
for adding/deleting ITS table entries,trigerring LPI interrupts are 
implemented.Translated LPI interrupt ids are processed by redistributor
to determine priority and set pending state appropriately before
forwarding the same to cpu interface.
The ITS feature support has been added to sbsa-ref platform as well as
virt platform,wherein the emulated functionality co-exists with kvm
kernel functionality.

Shashi Mallela (8):
  hw/intc: GICv3 ITS initial framework
  hw/intc: GICv3 ITS register definitions added
  hw/intc: GICv3 ITS command queue framework
  hw/intc: GICv3 ITS Command processing
  hw/intc: GICv3 ITS Feature enablement
  hw/intc: GICv3 redistributor ITS processing
  hw/arm/sbsa-ref: add ITS support in SBSA GIC
  hw/arm/virt: add ITS support in virt GIC

 hw/arm/sbsa-ref.c                      |   26 +-
 hw/arm/virt.c                          |   10 +-
 hw/intc/arm_gicv3.c                    |    6 +
 hw/intc/arm_gicv3_common.c             |   16 +
 hw/intc/arm_gicv3_cpuif.c              |   15 +-
 hw/intc/arm_gicv3_dist.c               |   22 +-
 hw/intc/arm_gicv3_its.c                | 1417 ++++++++++++++++++++
 hw/intc/arm_gicv3_its_common.c         |   17 +-
 hw/intc/arm_gicv3_its_kvm.c            |    2 +-
 hw/intc/arm_gicv3_redist.c             |  155 ++-
 hw/intc/gicv3_internal.h               |  176 ++-
 hw/intc/meson.build                    |    1 +
 include/hw/intc/arm_gicv3_common.h     |   14 +
 include/hw/intc/arm_gicv3_its_common.h |   12 +-
 target/arm/kvm_arm.h                   |    4 +-
 15 files changed, 1869 insertions(+), 24 deletions(-)
 create mode 100644 hw/intc/arm_gicv3_its.c

-- 
2.27.0
Re: [PATCH v1 0/8] GICv3 LPI and ITS feature implementation
Posted by Alex Bennée 3 years, 1 month ago 
Shashi Mallela <shashi.mallela@linaro.org> writes:

> This patchset implements qemu device model for enabling physical
> LPI support and ITS functionality in GIC as per GICv3 specification.
> Both flat table and 2 level tables are implemented.The ITS commands
> for adding/deleting ITS table entries,trigerring LPI interrupts are 
> implemented.Translated LPI interrupt ids are processed by redistributor
> to determine priority and set pending state appropriately before
> forwarding the same to cpu interface.
> The ITS feature support has been added to sbsa-ref platform as well as
> virt platform,wherein the emulated functionality co-exists with kvm
> kernel functionality.

Running the kvm-unit-tests ITS set:

   env QEMU=$HOME/lsrc/qemu.git/builds/arm.all/qemu-system-aarch64 ./run_tests.sh -g its

with a patched unitests.cfg to remove the KVM requirement I get:

  PASS its-introspection (5 tests)
  FAIL its-trigger (6 tests, 1 unexpected failures)
  FAIL its-migration
  FAIL its-pending-migration (1 tests, 1 unexpected failures)
  SKIP its-migrate-unmapped-collection (1 tests, 1 skipped)

The its-migration asserts:

  Now migrate the VM, then press a key to continue...
  INFO: gicv3: its-migration: Migration complete
  INT dev_id=2 event_id=20
  /home/alex/lsrc/tests/kvm-unit-tests.git/lib/arm64/gic-v3-its-cmd.c:192: assert failed: false: INT timeout!
          STACK:

Full logs attached:

timeout -k 1s --foreground 90s /home/alex/lsrc/qemu.git/builds/arm.all/qemu-system-aarch64 -nodefaults -machine virt,accel=tcg -cpu cortex-a57 -device virtio-serial-device -device virtconsole,chardev=ctd -chardev testdev,id=ctd -device pci-testdev -display none -serial stdio -kernel arm/gic.flat -smp 8 -machine gic-version=3 -append its-introspection # -initrd /tmp/tmp.irCRYgMeFT
PASS: gicv3: its-introspection: GITS_IIDR is read-only
PASS: gicv3: its-introspection: GITS_TYPER is read-only
PASS: gicv3: its-introspection: ITS supports physical LPIs
INFO: gicv3: its-introspection: vLPI support: no
INFO: gicv3: its-introspection: ITT entry size = 0xc
INFO: gicv3: its-introspection: Bit Count: EventID=16 DeviceId=16 CollId=16
PASS: gicv3: its-introspection: ID spaces
INFO: gicv3: its-introspection: Target address format PE #
PASS: gicv3: its-introspection: detect device and collection BASER
INFO: gicv3: its-introspection: device table entry_size = 0x9
INFO: gicv3: its-introspection: collection table entry_size = 0x9
SUMMARY: 5 tests

run_migration timeout -k 1s --foreground 90s /home/alex/lsrc/qemu.git/builds/arm.all/qemu-system-aarch64 -nodefaults -machine virt,accel=tcg -cpu cortex-a57 -device virtio-serial-device -device virtconsole,chardev=ctd -chardev testdev,id=ctd -device pci-testdev -display none -serial stdio -kernel arm/gic.flat -smp 8 -machine gic-version=3 -append its-migrate-unmapped-collection # -initrd /tmp/tmp.DQwPrbFkd0
qemu-system-aarch64:qemu-system-aarch64: -chardev -chardev socket,id=mon1,path=/tmp/mig-helper-qmp1.yEhVzheBai,server,nowait socket,id=mon2,path=/tmp/mig-helper-qmp2.WIhQnCH5nq,server,nowait: : warning: warning: short-form boolean option 'server' deprecatedshort-form boolean option 'server' deprecated

Please use server=on instead
Please use server=on instead
qemu-system-aarch64:qemu-system-aarch64: -chardev -chardev socket,id=mon1,path=/tmp/mig-helper-qmp1.yEhVzheBai,server,nowait socket,id=mon2,path=/tmp/mig-helper-qmp2.WIhQnCH5nq,server,nowait: : warning: warning: short-form boolean option 'nowait' deprecatedshort-form boolean option 'nowait' deprecated

Please use wait=off instead
Please use wait=off instead
ITS: MAPD devid=2 size = 0x8 itt=0x40440000 valid=1
ITS: MAPD devid=7 size = 0x8 itt=0x40450000 valid=1
MAPC col_id=3 target_addr = 0x30000 valid=1
MAPC col_id=2 target_addr = 0x20000 valid=1
INVALL col_id=2
INVALL col_id=3
MAPTI dev_id=2 event_id=20 -> phys_id=8195, col_id=3
MAPTI dev_id=7 event_id=255 -> phys_id=8196, col_id=2
SKIP: gicv3: its-migrate-unmapped-collection: Skipping test, as this test hangs without the fix. Set ERRATA_8c58be34494b=y to enable.
Now migrate the VM, then press a key to continue...
INFO: gicv3: its-migrate-unmapped-collection: Migration complete
SUMMARY: 1 tests, 1 skipped

run_migration timeout -k 1s --foreground 90s /home/alex/lsrc/qemu.git/builds/arm.all/qemu-system-aarch64 -nodefaults -machine virt,accel=tcg -cpu cortex-a57 -device virtio-serial-device -device virtconsole,chardev=ctd -chardev testdev,id=ctd -device pci-testdev -display none -serial stdio -kernel arm/gic.flat -smp 8 -machine gic-version=3 -append its-migration # -initrd /tmp/tmp.o6yvmr7IoW
qemu-system-aarch64: -chardev socket,id=mon2,path=/tmp/mig-helper-qmp2.26HZNvi5R6,server,nowait: warning: short-form boolean option 'server' deprecated
Please use server=on instead
qemu-system-aarch64: -chardev socket,id=mon2,path=/tmp/mig-helper-qmp2.26HZNvi5R6,server,nowait: warning: short-form boolean option 'nowait' deprecated
Please use wait=off instead
qemu-system-aarch64: -chardev socket,id=mon1,path=/tmp/mig-helper-qmp1.a3pbeaOG0G,server,nowait: warning: short-form boolean option 'server' deprecated
Please use server=on instead
qemu-system-aarch64: -chardev socket,id=mon1,path=/tmp/mig-helper-qmp1.a3pbeaOG0G,server,nowait: warning: short-form boolean option 'nowait' deprecated
Please use wait=off instead
ITS: MAPD devid=2 size = 0x8 itt=0x40440000 valid=1
ITS: MAPD devid=7 size = 0x8 itt=0x40450000 valid=1
MAPC col_id=3 target_addr = 0x30000 valid=1
MAPC col_id=2 target_addr = 0x20000 valid=1
INVALL col_id=2
INVALL col_id=3
MAPTI dev_id=2 event_id=20 -> phys_id=8195, col_id=3
MAPTI dev_id=7 event_id=255 -> phys_id=8196, col_id=2
Now migrate the VM, then press a key to continue...
INFO: gicv3: its-migration: Migration complete
INT dev_id=2 event_id=20
/home/alex/lsrc/tests/kvm-unit-tests.git/lib/arm64/gic-v3-its-cmd.c:192: assert failed: false: INT timeout!
	STACK:

run_migration timeout -k 1s --foreground 90s /home/alex/lsrc/qemu.git/builds/arm.all/qemu-system-aarch64 -nodefaults -machine virt,accel=tcg -cpu cortex-a57 -device virtio-serial-device -device virtconsole,chardev=ctd -chardev testdev,id=ctd -device pci-testdev -display none -serial stdio -kernel arm/gic.flat -smp 8 -machine gic-version=3 -append its-pending-migration # -initrd /tmp/tmp.g0MCehNHE7
qemu-system-aarch64: -chardev socket,id=mon2,path=/tmp/mig-helper-qmp2.LzwzLgvqSJ,server,nowait: warning: short-form boolean option 'server' deprecated
Please use server=on instead
qemu-system-aarch64: -chardev socket,id=mon2,path=/tmp/mig-helper-qmp2.LzwzLgvqSJ,server,nowait: warning: short-form boolean option 'nowait' deprecated
qemu-system-aarch64:Please use wait=off instead
 -chardev socket,id=mon1,path=/tmp/mig-helper-qmp1.HVjOEOLU2L,server,nowait: warning: short-form boolean option 'server' deprecated
Please use server=on instead
qemu-system-aarch64: -chardev socket,id=mon1,path=/tmp/mig-helper-qmp1.HVjOEOLU2L,server,nowait: warning: short-form boolean option 'nowait' deprecated
Please use wait=off instead
ITS: MAPD devid=2 size = 0x8 itt=0x40450000 valid=1
MAPC col_id=7 target_addr = 0x70000 valid=1
MAPC col_id=6 target_addr = 0x60000 valid=1
MAPTI dev_id=2 event_id=0 -> phys_id=8192, col_id=6
MAPTI dev_id=2 event_id=1 -> phys_id=8193, col_id=7
MAPTI dev_id=2 event_id=2 -> phys_id=8194, col_id=6
MAPTI dev_id=2 event_id=3 -> phys_id=8195, col_id=7
MAPTI dev_id=2 event_id=4 -> phys_id=8196, col_id=6
MAPTI dev_id=2 event_id=5 -> phys_id=8197, col_id=7
MAPTI dev_id=2 event_id=6 -> phys_id=8198, col_id=6
MAPTI dev_id=2 event_id=7 -> phys_id=8199, col_id=7
MAPTI dev_id=2 event_id=8 -> phys_id=8200, col_id=6
MAPTI dev_id=2 event_id=9 -> phys_id=8201, col_id=7
MAPTI dev_id=2 event_id=10 -> phys_id=8202, col_id=6
MAPTI dev_id=2 event_id=11 -> phys_id=8203, col_id=7
MAPTI dev_id=2 event_id=12 -> phys_id=8204, col_id=6
MAPTI dev_id=2 event_id=13 -> phys_id=8205, col_id=7
MAPTI dev_id=2 event_id=14 -> phys_id=8206, col_id=6
MAPTI dev_id=2 event_id=15 -> phys_id=8207, col_id=7
MAPTI dev_id=2 event_id=16 -> phys_id=8208, col_id=6
MAPTI dev_id=2 event_id=17 -> phys_id=8209, col_id=7
MAPTI dev_id=2 event_id=18 -> phys_id=8210, col_id=6
MAPTI dev_id=2 event_id=19 -> phys_id=8211, col_id=7
MAPTI dev_id=2 event_id=20 -> phys_id=8212, col_id=6
MAPTI dev_id=2 event_id=21 -> phys_id=8213, col_id=7
MAPTI dev_id=2 event_id=22 -> phys_id=8214, col_id=6
MAPTI dev_id=2 event_id=23 -> phys_id=8215, col_id=7
MAPTI dev_id=2 event_id=24 -> phys_id=8216, col_id=6
MAPTI dev_id=2 event_id=25 -> phys_id=8217, col_id=7
MAPTI dev_id=2 event_id=26 -> phys_id=8218, col_id=6
MAPTI dev_id=2 event_id=27 -> phys_id=8219, col_id=7
MAPTI dev_id=2 event_id=28 -> phys_id=8220, col_id=6
MAPTI dev_id=2 event_id=29 -> phys_id=8221, col_id=7
MAPTI dev_id=2 event_id=30 -> phys_id=8222, col_id=6
MAPTI dev_id=2 event_id=31 -> phys_id=8223, col_id=7
MAPTI dev_id=2 event_id=32 -> phys_id=8224, col_id=6
MAPTI dev_id=2 event_id=33 -> phys_id=8225, col_id=7
MAPTI dev_id=2 event_id=34 -> phys_id=8226, col_id=6
MAPTI dev_id=2 event_id=35 -> phys_id=8227, col_id=7
MAPTI dev_id=2 event_id=36 -> phys_id=8228, col_id=6
MAPTI dev_id=2 event_id=37 -> phys_id=8229, col_id=7
MAPTI dev_id=2 event_id=38 -> phys_id=8230, col_id=6
MAPTI dev_id=2 event_id=39 -> phys_id=8231, col_id=7
MAPTI dev_id=2 event_id=40 -> phys_id=8232, col_id=6
MAPTI dev_id=2 event_id=41 -> phys_id=8233, col_id=7
MAPTI dev_id=2 event_id=42 -> phys_id=8234, col_id=6
MAPTI dev_id=2 event_id=43 -> phys_id=8235, col_id=7
MAPTI dev_id=2 event_id=44 -> phys_id=8236, col_id=6
MAPTI dev_id=2 event_id=45 -> phys_id=8237, col_id=7
MAPTI dev_id=2 event_id=46 -> phys_id=8238, col_id=6
MAPTI dev_id=2 event_id=47 -> phys_id=8239, col_id=7
MAPTI dev_id=2 event_id=48 -> phys_id=8240, col_id=6
MAPTI dev_id=2 event_id=49 -> phys_id=8241, col_id=7
MAPTI dev_id=2 event_id=50 -> phys_id=8242, col_id=6
MAPTI dev_id=2 event_id=51 -> phys_id=8243, col_id=7
MAPTI dev_id=2 event_id=52 -> phys_id=8244, col_id=6
MAPTI dev_id=2 event_id=53 -> phys_id=8245, col_id=7
MAPTI dev_id=2 event_id=54 -> phys_id=8246, col_id=6
MAPTI dev_id=2 event_id=55 -> phys_id=8247, col_id=7
MAPTI dev_id=2 event_id=56 -> phys_id=8248, col_id=6
MAPTI dev_id=2 event_id=57 -> phys_id=8249, col_id=7
MAPTI dev_id=2 event_id=58 -> phys_id=8250, col_id=6
MAPTI dev_id=2 event_id=59 -> phys_id=8251, col_id=7
MAPTI dev_id=2 event_id=60 -> phys_id=8252, col_id=6
MAPTI dev_id=2 event_id=61 -> phys_id=8253, col_id=7
MAPTI dev_id=2 event_id=62 -> phys_id=8254, col_id=6
MAPTI dev_id=2 event_id=63 -> phys_id=8255, col_id=7
MAPTI dev_id=2 event_id=64 -> phys_id=8256, col_id=6
MAPTI dev_id=2 event_id=65 -> phys_id=8257, col_id=7
MAPTI dev_id=2 event_id=66 -> phys_id=8258, col_id=6
MAPTI dev_id=2 event_id=67 -> phys_id=8259, col_id=7
MAPTI dev_id=2 event_id=68 -> phys_id=8260, col_id=6
MAPTI dev_id=2 event_id=69 -> phys_id=8261, col_id=7
MAPTI dev_id=2 event_id=70 -> phys_id=8262, col_id=6
MAPTI dev_id=2 event_id=71 -> phys_id=8263, col_id=7
MAPTI dev_id=2 event_id=72 -> phys_id=8264, col_id=6
MAPTI dev_id=2 event_id=73 -> phys_id=8265, col_id=7
MAPTI dev_id=2 event_id=74 -> phys_id=8266, col_id=6
MAPTI dev_id=2 event_id=75 -> phys_id=8267, col_id=7
MAPTI dev_id=2 event_id=76 -> phys_id=8268, col_id=6
MAPTI dev_id=2 event_id=77 -> phys_id=8269, col_id=7
MAPTI dev_id=2 event_id=78 -> phys_id=8270, col_id=6
MAPTI dev_id=2 event_id=79 -> phys_id=8271, col_id=7
MAPTI dev_id=2 event_id=80 -> phys_id=8272, col_id=6
MAPTI dev_id=2 event_id=81 -> phys_id=8273, col_id=7
MAPTI dev_id=2 event_id=82 -> phys_id=8274, col_id=6
MAPTI dev_id=2 event_id=83 -> phys_id=8275, col_id=7
MAPTI dev_id=2 event_id=84 -> phys_id=8276, col_id=6
MAPTI dev_id=2 event_id=85 -> phys_id=8277, col_id=7
MAPTI dev_id=2 event_id=86 -> phys_id=8278, col_id=6
MAPTI dev_id=2 event_id=87 -> phys_id=8279, col_id=7
MAPTI dev_id=2 event_id=88 -> phys_id=8280, col_id=6
MAPTI dev_id=2 event_id=89 -> phys_id=8281, col_id=7
MAPTI dev_id=2 event_id=90 -> phys_id=8282, col_id=6
MAPTI dev_id=2 event_id=91 -> phys_id=8283, col_id=7
MAPTI dev_id=2 event_id=92 -> phys_id=8284, col_id=6
MAPTI dev_id=2 event_id=93 -> phys_id=8285, col_id=7
MAPTI dev_id=2 event_id=94 -> phys_id=8286, col_id=6
MAPTI dev_id=2 event_id=95 -> phys_id=8287, col_id=7
MAPTI dev_id=2 event_id=96 -> phys_id=8288, col_id=6
MAPTI dev_id=2 event_id=97 -> phys_id=8289, col_id=7
MAPTI dev_id=2 event_id=98 -> phys_id=8290, col_id=6
MAPTI dev_id=2 event_id=99 -> phys_id=8291, col_id=7
MAPTI dev_id=2 event_id=100 -> phys_id=8292, col_id=6
MAPTI dev_id=2 event_id=101 -> phys_id=8293, col_id=7
MAPTI dev_id=2 event_id=102 -> phys_id=8294, col_id=6
MAPTI dev_id=2 event_id=103 -> phys_id=8295, col_id=7
MAPTI dev_id=2 event_id=104 -> phys_id=8296, col_id=6
MAPTI dev_id=2 event_id=105 -> phys_id=8297, col_id=7
MAPTI dev_id=2 event_id=106 -> phys_id=8298, col_id=6
MAPTI dev_id=2 event_id=107 -> phys_id=8299, col_id=7
MAPTI dev_id=2 event_id=108 -> phys_id=8300, col_id=6
MAPTI dev_id=2 event_id=109 -> phys_id=8301, col_id=7
MAPTI dev_id=2 event_id=110 -> phys_id=8302, col_id=6
MAPTI dev_id=2 event_id=111 -> phys_id=8303, col_id=7
MAPTI dev_id=2 event_id=112 -> phys_id=8304, col_id=6
MAPTI dev_id=2 event_id=113 -> phys_id=8305, col_id=7
MAPTI dev_id=2 event_id=114 -> phys_id=8306, col_id=6
MAPTI dev_id=2 event_id=115 -> phys_id=8307, col_id=7
MAPTI dev_id=2 event_id=116 -> phys_id=8308, col_id=6
MAPTI dev_id=2 event_id=117 -> phys_id=8309, col_id=7
MAPTI dev_id=2 event_id=118 -> phys_id=8310, col_id=6
MAPTI dev_id=2 event_id=119 -> phys_id=8311, col_id=7
MAPTI dev_id=2 event_id=120 -> phys_id=8312, col_id=6
MAPTI dev_id=2 event_id=121 -> phys_id=8313, col_id=7
MAPTI dev_id=2 event_id=122 -> phys_id=8314, col_id=6
MAPTI dev_id=2 event_id=123 -> phys_id=8315, col_id=7
MAPTI dev_id=2 event_id=124 -> phys_id=8316, col_id=6
MAPTI dev_id=2 event_id=125 -> phys_id=8317, col_id=7
MAPTI dev_id=2 event_id=126 -> phys_id=8318, col_id=6
MAPTI dev_id=2 event_id=127 -> phys_id=8319, col_id=7
MAPTI dev_id=2 event_id=128 -> phys_id=8320, col_id=6
MAPTI dev_id=2 event_id=129 -> phys_id=8321, col_id=7
MAPTI dev_id=2 event_id=130 -> phys_id=8322, col_id=6
MAPTI dev_id=2 event_id=131 -> phys_id=8323, col_id=7
MAPTI dev_id=2 event_id=132 -> phys_id=8324, col_id=6
MAPTI dev_id=2 event_id=133 -> phys_id=8325, col_id=7
MAPTI dev_id=2 event_id=134 -> phys_id=8326, col_id=6
MAPTI dev_id=2 event_id=135 -> phys_id=8327, col_id=7
MAPTI dev_id=2 event_id=136 -> phys_id=8328, col_id=6
MAPTI dev_id=2 event_id=137 -> phys_id=8329, col_id=7
MAPTI dev_id=2 event_id=138 -> phys_id=8330, col_id=6
MAPTI dev_id=2 event_id=139 -> phys_id=8331, col_id=7
MAPTI dev_id=2 event_id=140 -> phys_id=8332, col_id=6
MAPTI dev_id=2 event_id=141 -> phys_id=8333, col_id=7
MAPTI dev_id=2 event_id=142 -> phys_id=8334, col_id=6
MAPTI dev_id=2 event_id=143 -> phys_id=8335, col_id=7
MAPTI dev_id=2 event_id=144 -> phys_id=8336, col_id=6
MAPTI dev_id=2 event_id=145 -> phys_id=8337, col_id=7
MAPTI dev_id=2 event_id=146 -> phys_id=8338, col_id=6
MAPTI dev_id=2 event_id=147 -> phys_id=8339, col_id=7
MAPTI dev_id=2 event_id=148 -> phys_id=8340, col_id=6
MAPTI dev_id=2 event_id=149 -> phys_id=8341, col_id=7
MAPTI dev_id=2 event_id=150 -> phys_id=8342, col_id=6
MAPTI dev_id=2 event_id=151 -> phys_id=8343, col_id=7
MAPTI dev_id=2 event_id=152 -> phys_id=8344, col_id=6
MAPTI dev_id=2 event_id=153 -> phys_id=8345, col_id=7
MAPTI dev_id=2 event_id=154 -> phys_id=8346, col_id=6
MAPTI dev_id=2 event_id=155 -> phys_id=8347, col_id=7
MAPTI dev_id=2 event_id=156 -> phys_id=8348, col_id=6
MAPTI dev_id=2 event_id=157 -> phys_id=8349, col_id=7
MAPTI dev_id=2 event_id=158 -> phys_id=8350, col_id=6
MAPTI dev_id=2 event_id=159 -> phys_id=8351, col_id=7
MAPTI dev_id=2 event_id=160 -> phys_id=8352, col_id=6
MAPTI dev_id=2 event_id=161 -> phys_id=8353, col_id=7
MAPTI dev_id=2 event_id=162 -> phys_id=8354, col_id=6
MAPTI dev_id=2 event_id=163 -> phys_id=8355, col_id=7
MAPTI dev_id=2 event_id=164 -> phys_id=8356, col_id=6
MAPTI dev_id=2 event_id=165 -> phys_id=8357, col_id=7
MAPTI dev_id=2 event_id=166 -> phys_id=8358, col_id=6
MAPTI dev_id=2 event_id=167 -> phys_id=8359, col_id=7
MAPTI dev_id=2 event_id=168 -> phys_id=8360, col_id=6
MAPTI dev_id=2 event_id=169 -> phys_id=8361, col_id=7
MAPTI dev_id=2 event_id=170 -> phys_id=8362, col_id=6
MAPTI dev_id=2 event_id=171 -> phys_id=8363, col_id=7
MAPTI dev_id=2 event_id=172 -> phys_id=8364, col_id=6
MAPTI dev_id=2 event_id=173 -> phys_id=8365, col_id=7
MAPTI dev_id=2 event_id=174 -> phys_id=8366, col_id=6
MAPTI dev_id=2 event_id=175 -> phys_id=8367, col_id=7
MAPTI dev_id=2 event_id=176 -> phys_id=8368, col_id=6
MAPTI dev_id=2 event_id=177 -> phys_id=8369, col_id=7
MAPTI dev_id=2 event_id=178 -> phys_id=8370, col_id=6
MAPTI dev_id=2 event_id=179 -> phys_id=8371, col_id=7
MAPTI dev_id=2 event_id=180 -> phys_id=8372, col_id=6
MAPTI dev_id=2 event_id=181 -> phys_id=8373, col_id=7
MAPTI dev_id=2 event_id=182 -> phys_id=8374, col_id=6
MAPTI dev_id=2 event_id=183 -> phys_id=8375, col_id=7
MAPTI dev_id=2 event_id=184 -> phys_id=8376, col_id=6
MAPTI dev_id=2 event_id=185 -> phys_id=8377, col_id=7
MAPTI dev_id=2 event_id=186 -> phys_id=8378, col_id=6
MAPTI dev_id=2 event_id=187 -> phys_id=8379, col_id=7
MAPTI dev_id=2 event_id=188 -> phys_id=8380, col_id=6
MAPTI dev_id=2 event_id=189 -> phys_id=8381, col_id=7
MAPTI dev_id=2 event_id=190 -> phys_id=8382, col_id=6
MAPTI dev_id=2 event_id=191 -> phys_id=8383, col_id=7
MAPTI dev_id=2 event_id=192 -> phys_id=8384, col_id=6
MAPTI dev_id=2 event_id=193 -> phys_id=8385, col_id=7
MAPTI dev_id=2 event_id=194 -> phys_id=8386, col_id=6
MAPTI dev_id=2 event_id=195 -> phys_id=8387, col_id=7
MAPTI dev_id=2 event_id=196 -> phys_id=8388, col_id=6
MAPTI dev_id=2 event_id=197 -> phys_id=8389, col_id=7
MAPTI dev_id=2 event_id=198 -> phys_id=8390, col_id=6
MAPTI dev_id=2 event_id=199 -> phys_id=8391, col_id=7
MAPTI dev_id=2 event_id=200 -> phys_id=8392, col_id=6
MAPTI dev_id=2 event_id=201 -> phys_id=8393, col_id=7
MAPTI dev_id=2 event_id=202 -> phys_id=8394, col_id=6
MAPTI dev_id=2 event_id=203 -> phys_id=8395, col_id=7
MAPTI dev_id=2 event_id=204 -> phys_id=8396, col_id=6
MAPTI dev_id=2 event_id=205 -> phys_id=8397, col_id=7
MAPTI dev_id=2 event_id=206 -> phys_id=8398, col_id=6
MAPTI dev_id=2 event_id=207 -> phys_id=8399, col_id=7
MAPTI dev_id=2 event_id=208 -> phys_id=8400, col_id=6
MAPTI dev_id=2 event_id=209 -> phys_id=8401, col_id=7
MAPTI dev_id=2 event_id=210 -> phys_id=8402, col_id=6
MAPTI dev_id=2 event_id=211 -> phys_id=8403, col_id=7
MAPTI dev_id=2 event_id=212 -> phys_id=8404, col_id=6
MAPTI dev_id=2 event_id=213 -> phys_id=8405, col_id=7
MAPTI dev_id=2 event_id=214 -> phys_id=8406, col_id=6
MAPTI dev_id=2 event_id=215 -> phys_id=8407, col_id=7
MAPTI dev_id=2 event_id=216 -> phys_id=8408, col_id=6
MAPTI dev_id=2 event_id=217 -> phys_id=8409, col_id=7
MAPTI dev_id=2 event_id=218 -> phys_id=8410, col_id=6
MAPTI dev_id=2 event_id=219 -> phys_id=8411, col_id=7
MAPTI dev_id=2 event_id=220 -> phys_id=8412, col_id=6
MAPTI dev_id=2 event_id=221 -> phys_id=8413, col_id=7
MAPTI dev_id=2 event_id=222 -> phys_id=8414, col_id=6
MAPTI dev_id=2 event_id=223 -> phys_id=8415, col_id=7
MAPTI dev_id=2 event_id=224 -> phys_id=8416, col_id=6
MAPTI dev_id=2 event_id=225 -> phys_id=8417, col_id=7
MAPTI dev_id=2 event_id=226 -> phys_id=8418, col_id=6
MAPTI dev_id=2 event_id=227 -> phys_id=8419, col_id=7
MAPTI dev_id=2 event_id=228 -> phys_id=8420, col_id=6
MAPTI dev_id=2 event_id=229 -> phys_id=8421, col_id=7
MAPTI dev_id=2 event_id=230 -> phys_id=8422, col_id=6
MAPTI dev_id=2 event_id=231 -> phys_id=8423, col_id=7
MAPTI dev_id=2 event_id=232 -> phys_id=8424, col_id=6
MAPTI dev_id=2 event_id=233 -> phys_id=8425, col_id=7
MAPTI dev_id=2 event_id=234 -> phys_id=8426, col_id=6
MAPTI dev_id=2 event_id=235 -> phys_id=8427, col_id=7
MAPTI dev_id=2 event_id=236 -> phys_id=8428, col_id=6
MAPTI dev_id=2 event_id=237 -> phys_id=8429, col_id=7
MAPTI dev_id=2 event_id=238 -> phys_id=8430, col_id=6
MAPTI dev_id=2 event_id=239 -> phys_id=8431, col_id=7
MAPTI dev_id=2 event_id=240 -> phys_id=8432, col_id=6
MAPTI dev_id=2 event_id=241 -> phys_id=8433, col_id=7
MAPTI dev_id=2 event_id=242 -> phys_id=8434, col_id=6
MAPTI dev_id=2 event_id=243 -> phys_id=8435, col_id=7
MAPTI dev_id=2 event_id=244 -> phys_id=8436, col_id=6
MAPTI dev_id=2 event_id=245 -> phys_id=8437, col_id=7
MAPTI dev_id=2 event_id=246 -> phys_id=8438, col_id=6
MAPTI dev_id=2 event_id=247 -> phys_id=8439, col_id=7
MAPTI dev_id=2 event_id=248 -> phys_id=8440, col_id=6
MAPTI dev_id=2 event_id=249 -> phys_id=8441, col_id=7
MAPTI dev_id=2 event_id=250 -> phys_id=8442, col_id=6
MAPTI dev_id=2 event_id=251 -> phys_id=8443, col_id=7
MAPTI dev_id=2 event_id=252 -> phys_id=8444, col_id=6
MAPTI dev_id=2 event_id=253 -> phys_id=8445, col_id=7
MAPTI dev_id=2 event_id=254 -> phys_id=8446, col_id=6
MAPTI dev_id=2 event_id=255 -> phys_id=8447, col_id=7
INVALL col_id=7
INVALL col_id=6
Now migrate the VM, then press a key to continue...
INFO: gicv3: its-pending-migration: Migration complete
INFO: gicv3: its-pending-migration: expected 128 LPIs on PE #6, 0 observed
FAIL: gicv3: its-pending-migration: 128 LPIs on both PE0 and PE1 after migration
SUMMARY: 1 tests, 1 unexpected failures

timeout -k 1s --foreground 90s /home/alex/lsrc/qemu.git/builds/arm.all/qemu-system-aarch64 -nodefaults -machine virt,accel=tcg -cpu cortex-a57 -device virtio-serial-device -device virtconsole,chardev=ctd -chardev testdev,id=ctd -device pci-testdev -display none -serial stdio -kernel arm/gic.flat -smp 8 -machine gic-version=3 -append its-trigger # -initrd /tmp/tmp.shXaNoBX3p
ITS: MAPD devid=2 size = 0x8 itt=0x40440000 valid=1
ITS: MAPD devid=7 size = 0x8 itt=0x40450000 valid=1
MAPC col_id=3 target_addr = 0x30000 valid=1
MAPC col_id=2 target_addr = 0x20000 valid=1
INVALL col_id=2
INVALL col_id=3
MAPTI dev_id=2 event_id=20 -> phys_id=8195, col_id=3
MAPTI dev_id=7 event_id=255 -> phys_id=8196, col_id=2
INT dev_id=2 event_id=20
PASS: gicv3: its-trigger: int: dev=2, eventid=20  -> lpi= 8195, col=3
INT dev_id=7 event_id=255
PASS: gicv3: its-trigger: int: dev=7, eventid=255 -> lpi= 8196, col=2
INV dev_id=2 event_id=20
INT dev_id=2 event_id=20
PASS: gicv3: its-trigger: inv/invall: dev2/eventid=20 does not trigger any LPI
INT dev_id=2 event_id=20
INFO: gicv3: its-trigger: inv/invall: Unexpected LPI (cpuid=3, intid=8195)
FAIL: gicv3: its-trigger: inv/invall: dev2/eventid=20 still does not trigger any LPI
INVALL col_id=3
INT dev_id=2 event_id=20
PASS: gicv3: its-trigger: inv/invall: dev2/eventid=20 now triggers an LPI
ITS: MAPD devid=2 size = 0x8 itt=0x40440000 valid=0
INT dev_id=2 event_id=20
PASS: gicv3: its-trigger: mapd valid=false: no LPI after device unmap
SUMMARY: 6 tests, 1 unexpected failures

BUILD_HEAD=3054ca26


-- 
Alex Bennée
Re: [PATCH v1 0/8] GICv3 LPI and ITS feature implementation
Posted by Alex Bennée 3 years, 1 month ago 
Shashi Mallela <shashi.mallela@linaro.org> writes:

> This patchset implements qemu device model for enabling physical
> LPI support and ITS functionality in GIC as per GICv3 specification.
> Both flat table and 2 level tables are implemented.The ITS commands
> for adding/deleting ITS table entries,trigerring LPI interrupts are 
> implemented.Translated LPI interrupt ids are processed by redistributor
> to determine priority and set pending state appropriately before
> forwarding the same to cpu interface.
> The ITS feature support has been added to sbsa-ref platform as well as
> virt platform,wherein the emulated functionality co-exists with kvm
> kernel functionality.

OK I've finished my first pass. I didn't want to keep repeating myself
with the later patches. So in summary:

  - use REG/FIELD to avoid the manual mask definition/manipulation
  - define registers in the patch that first uses them
  - check LOG_UNIMP vs LOG_GUEST_ERROR (and possibly assert if it
    shouldn't happen)
  - and of course pass the kvm-unit-tests ITS tests ;-) 

Thanks,

>
> Shashi Mallela (8):
>   hw/intc: GICv3 ITS initial framework
>   hw/intc: GICv3 ITS register definitions added
>   hw/intc: GICv3 ITS command queue framework
>   hw/intc: GICv3 ITS Command processing
>   hw/intc: GICv3 ITS Feature enablement
>   hw/intc: GICv3 redistributor ITS processing
>   hw/arm/sbsa-ref: add ITS support in SBSA GIC
>   hw/arm/virt: add ITS support in virt GIC
>
>  hw/arm/sbsa-ref.c                      |   26 +-
>  hw/arm/virt.c                          |   10 +-
>  hw/intc/arm_gicv3.c                    |    6 +
>  hw/intc/arm_gicv3_common.c             |   16 +
>  hw/intc/arm_gicv3_cpuif.c              |   15 +-
>  hw/intc/arm_gicv3_dist.c               |   22 +-
>  hw/intc/arm_gicv3_its.c                | 1417 ++++++++++++++++++++
>  hw/intc/arm_gicv3_its_common.c         |   17 +-
>  hw/intc/arm_gicv3_its_kvm.c            |    2 +-
>  hw/intc/arm_gicv3_redist.c             |  155 ++-
>  hw/intc/gicv3_internal.h               |  176 ++-
>  hw/intc/meson.build                    |    1 +
>  include/hw/intc/arm_gicv3_common.h     |   14 +
>  include/hw/intc/arm_gicv3_its_common.h |   12 +-
>  target/arm/kvm_arm.h                   |    4 +-
>  15 files changed, 1869 insertions(+), 24 deletions(-)
>  create mode 100644 hw/intc/arm_gicv3_its.c


-- 
Alex Bennée

Patchew 2.1-devel-0870f84

© 2016 - 2024 Red Hat, Inc.