Hi,

While reviewing Richard's original patch, I split it in 3
to make it more digestible to my review taste. I then simply
filled the patch descriptions. Feel free to keep Richard's v1
if this isn't worth it.

What is still missing is adding the new files to a MAINTAINERS
section.

Regards,

Phil.

Supersedes: <20210321211534.2101231-1-richard.henderson@linaro.org>

Richard Henderson (3):
  exec: Rename exec-vary.c as page-vary.c
  exec: Extract 'page-vary.h' header
  exec: Build page-vary-common.c with -fno-lto

 configure                |  19 -------
 meson.build              |  18 ++++++-
 include/exec/cpu-all.h   |  15 ++----
 include/exec/page-vary.h |  34 ++++++++++++
 exec-vary.c              | 108 ---------------------------------------
 page-vary-common.c       |  54 ++++++++++++++++++++
 page-vary.c              |  41 +++++++++++++++
 7 files changed, 150 insertions(+), 139 deletions(-)
 create mode 100644 include/exec/page-vary.h
 delete mode 100644 exec-vary.c
 create mode 100644 page-vary-common.c
 create mode 100644 page-vary.c

-- 
2.26.2

On 22/03/21 12:24, Philippe Mathieu-Daudé wrote:
> Hi,
> 
> While reviewing Richard's original patch, I split it in 3
> to make it more digestible to my review taste. I then simply
> filled the patch descriptions. Feel free to keep Richard's v1
> if this isn't worth it.
> 
> What is still missing is adding the new files to a MAINTAINERS
> section.

Both versions look good, thanks (the split is indeed more digestible)! 
Richard, are you going to queue one of them?

Paolo

> Regards,
> 
> Phil.
> 
> Supersedes: <20210321211534.2101231-1-richard.henderson@linaro.org>
> 
> Richard Henderson (3):
>    exec: Rename exec-vary.c as page-vary.c
>    exec: Extract 'page-vary.h' header
>    exec: Build page-vary-common.c with -fno-lto
> 
>   configure                |  19 -------
>   meson.build              |  18 ++++++-
>   include/exec/cpu-all.h   |  15 ++----
>   include/exec/page-vary.h |  34 ++++++++++++
>   exec-vary.c              | 108 ---------------------------------------
>   page-vary-common.c       |  54 ++++++++++++++++++++
>   page-vary.c              |  41 +++++++++++++++
>   7 files changed, 150 insertions(+), 139 deletions(-)
>   create mode 100644 include/exec/page-vary.h
>   delete mode 100644 exec-vary.c
>   create mode 100644 page-vary-common.c
>   create mode 100644 page-vary.c
> 

On 3/22/21 7:00 AM, Paolo Bonzini wrote:
> On 22/03/21 12:24, Philippe Mathieu-Daudé wrote:
>> Hi,
>>
>> While reviewing Richard's original patch, I split it in 3
>> to make it more digestible to my review taste. I then simply
>> filled the patch descriptions. Feel free to keep Richard's v1
>> if this isn't worth it.
>>
>> What is still missing is adding the new files to a MAINTAINERS
>> section.
> 
> Both versions look good, thanks (the split is indeed more digestible)! Richard, 
> are you going to queue one of them?

Yes, I'll take Phil's split, move the new files into softmmu/, and update 
MAINTAINERS.


r~