[PATCH for 6.0 v1 00/14] fixes for rc1 (kernel-doc, semihosting, testing)

Alex Bennée posted 14 patches 1 month, 2 weeks ago
Test checkpatch failed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20210320133706.21475-1-alex.bennee@linaro.org
docs/devel/style.rst                          |  46 +++--
docs/devel/tcg-plugins.rst                    |   5 +
configure                                     |   6 +-
tests/tcg/aarch64/semicall.h                  |  18 ++
tests/tcg/arm/semicall.h                      |  15 +-
tests/tcg/riscv64/semicall.h                  |  22 +++
linux-user/riscv/cpu_loop.c                   |   5 +
semihosting/arm-compat-semi.c                 |  62 +++----
tests/tcg/arm/semihosting.c                   |  26 ---
.../arm-compat-semi}/semiconsole.c            |   2 +
.../multiarch/arm-compat-semi/semihosting.c   |  71 ++++++++
tests/unit/test-cutils.c                      | 171 +++++++++++++++++-
tools/virtiofsd/fuse_lowlevel.c               |   1 +
util/cutils.c                                 |  33 +++-
.cirrus.yml                                   |   7 +-
.gitlab-ci.yml                                |  30 +--
MAINTAINERS                                   |   1 +
scripts/kernel-doc                            |   3 +
tests/tcg/Makefile.target                     |   3 +
tests/tcg/aarch64/Makefile.target             |  18 --
tests/tcg/arm/Makefile.target                 |  22 +--
tests/tcg/multiarch/Makefile.target           |  31 ++++
22 files changed, 430 insertions(+), 168 deletions(-)
create mode 100644 tests/tcg/aarch64/semicall.h
create mode 100644 tests/tcg/riscv64/semicall.h
delete mode 100644 tests/tcg/arm/semihosting.c
rename tests/tcg/{arm => multiarch/arm-compat-semi}/semiconsole.c (93%)
create mode 100644 tests/tcg/multiarch/arm-compat-semi/semihosting.c

[PATCH for 6.0 v1 00/14] fixes for rc1 (kernel-doc, semihosting, testing)

Posted by Alex Bennée 1 month, 2 weeks ago
Hi,

Here is my current collection of fixes for rc1. We have a couple of
documentation tweaks including the final bit of enabling work for the
plugin API to be included via kernel-doc. We have some semihosting
fixes which have been on the list before which just need the final bit
of review. Finally there is a selection of tweaks for CI issues which
hopefully get BSD (and Cirrus) up and running again.

The following still need review:

 - tests/tcg: add HeapInfo checking to semihosting test
 - linux-user/riscv: initialise the TaskState heap/stack info
 - semihosting: move semihosting tests to multiarch
 - docs/devel: expand style section of memory management
 - scripts/kernel-doc: strip QEMU_ from function definitions

Alex Bennée (9):
  scripts/kernel-doc: strip QEMU_ from function definitions
  docs/devel: include the plugin API information from the headers
  docs/devel: expand style section of memory management
  tools/virtiofsd: include --socket-group in help
  semihosting: move semihosting tests to multiarch
  semihosting/arm-compat-semi: unify GET/SET_ARG helpers
  semihosting/arm-compat-semi: don't use SET_ARG to report SYS_HEAPINFO
  linux-user/riscv: initialise the TaskState heap/stack info
  tests/tcg: add HeapInfo checking to semihosting test

Eric Blake (2):
  utils: Tighter tests for qemu_strtosz
  utils: Work around mingw strto*l bug with 0x

Thomas Huth (3):
  gitlab-ci.yml: Merge the trace-backend testing into other jobs
  configure: Don't use the __atomic_*_16 functions for testing 128-bit
    support
  cirrus.yml: Update the FreeBSD task to version 12.2

 docs/devel/style.rst                          |  46 +++--
 docs/devel/tcg-plugins.rst                    |   5 +
 configure                                     |   6 +-
 tests/tcg/aarch64/semicall.h                  |  18 ++
 tests/tcg/arm/semicall.h                      |  15 +-
 tests/tcg/riscv64/semicall.h                  |  22 +++
 linux-user/riscv/cpu_loop.c                   |   5 +
 semihosting/arm-compat-semi.c                 |  62 +++----
 tests/tcg/arm/semihosting.c                   |  26 ---
 .../arm-compat-semi}/semiconsole.c            |   2 +
 .../multiarch/arm-compat-semi/semihosting.c   |  71 ++++++++
 tests/unit/test-cutils.c                      | 171 +++++++++++++++++-
 tools/virtiofsd/fuse_lowlevel.c               |   1 +
 util/cutils.c                                 |  33 +++-
 .cirrus.yml                                   |   7 +-
 .gitlab-ci.yml                                |  30 +--
 MAINTAINERS                                   |   1 +
 scripts/kernel-doc                            |   3 +
 tests/tcg/Makefile.target                     |   3 +
 tests/tcg/aarch64/Makefile.target             |  18 --
 tests/tcg/arm/Makefile.target                 |  22 +--
 tests/tcg/multiarch/Makefile.target           |  31 ++++
 22 files changed, 430 insertions(+), 168 deletions(-)
 create mode 100644 tests/tcg/aarch64/semicall.h
 create mode 100644 tests/tcg/riscv64/semicall.h
 delete mode 100644 tests/tcg/arm/semihosting.c
 rename tests/tcg/{arm => multiarch/arm-compat-semi}/semiconsole.c (93%)
 create mode 100644 tests/tcg/multiarch/arm-compat-semi/semihosting.c

-- 
2.20.1


Re: [PATCH for 6.0 v1 00/14] fixes for rc1 (kernel-doc, semihosting, testing)

Posted by no-reply@patchew.org 1 month, 2 weeks ago
Patchew URL: https://patchew.org/QEMU/20210320133706.21475-1-alex.bennee@linaro.org/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: 20210320133706.21475-1-alex.bennee@linaro.org
Subject: [PATCH for 6.0 v1 00/14] fixes for rc1 (kernel-doc, semihosting, testing)

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 * [new tag]         patchew/20210320133706.21475-1-alex.bennee@linaro.org -> patchew/20210320133706.21475-1-alex.bennee@linaro.org
Switched to a new branch 'test'
2fe05ca utils: Work around mingw strto*l bug with 0x
c791580 utils: Tighter tests for qemu_strtosz
2b30091 cirrus.yml: Update the FreeBSD task to version 12.2
9a32f92 configure: Don't use the __atomic_*_16 functions for testing 128-bit support
411f58c gitlab-ci.yml: Merge the trace-backend testing into other jobs
f9008ed tests/tcg: add HeapInfo checking to semihosting test
c7fc498 linux-user/riscv: initialise the TaskState heap/stack info
64f8850 semihosting/arm-compat-semi: don't use SET_ARG to report SYS_HEAPINFO
4346991 semihosting/arm-compat-semi: unify GET/SET_ARG helpers
736c595 semihosting: move semihosting tests to multiarch
521038a tools/virtiofsd: include --socket-group in help
7a9f5fc docs/devel: expand style section of memory management
2d7c361 docs/devel: include the plugin API information from the headers
f4fed9c scripts/kernel-doc: strip QEMU_ from function definitions

=== OUTPUT BEGIN ===
1/14 Checking commit f4fed9c2b4ea (scripts/kernel-doc: strip QEMU_ from function definitions)
2/14 Checking commit 2d7c36108cba (docs/devel: include the plugin API information from the headers)
3/14 Checking commit 7a9f5fcce8d9 (docs/devel: expand style section of memory management)
4/14 Checking commit 521038a4b304 (tools/virtiofsd: include --socket-group in help)
5/14 Checking commit 736c59564aea (semihosting: move semihosting tests to multiarch)
6/14 Checking commit 4346991f6330 (semihosting/arm-compat-semi: unify GET/SET_ARG helpers)
7/14 Checking commit 64f885005bcc (semihosting/arm-compat-semi: don't use SET_ARG to report SYS_HEAPINFO)
8/14 Checking commit c7fc498483de (linux-user/riscv: initialise the TaskState heap/stack info)
9/14 Checking commit f9008edfe887 (tests/tcg: add HeapInfo checking to semihosting test)
10/14 Checking commit 411f58c7842f (gitlab-ci.yml: Merge the trace-backend testing into other jobs)
11/14 Checking commit 9a32f927b913 (configure: Don't use the __atomic_*_16 functions for testing 128-bit support)
12/14 Checking commit 2b30091c3c73 (cirrus.yml: Update the FreeBSD task to version 12.2)
13/14 Checking commit c7915804f46b (utils: Tighter tests for qemu_strtosz)
14/14 Checking commit 2fe05ca4258e (utils: Work around mingw strto*l bug with 0x)
ERROR: consider using qemu_strtol in preference to strtol
#144: FILE: util/cutils.c:409:
+        if (strtol(nptr, &tmp, 10) == 0 && errno == 0 &&

total: 1 errors, 0 warnings, 169 lines checked

Patch 14/14 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/20210320133706.21475-1-alex.bennee@linaro.org/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com