[v1] Fix crash if try to remove bitmap on target during migration

[PATCH 0/2] Fix crash if try to remove bitmap on target during migration

Vladimir Sementsov-Ogievskiy posted 2 patches 3 years, 1 month ago

Diff against v1
Download series mbox

Test checkpatch passed

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20210319204124.364312-1-vsementsov@virtuozzo.com

Maintainers: Juan Quintela <quintela@redhat.com>, Eric Blake <eblake@redhat.com>, Max Reitz <mreitz@redhat.com>, Kevin Wolf <kwolf@redhat.com>, John Snow <jsnow@redhat.com>, Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>, Stefan Hajnoczi <stefanha@redhat.com>, "Dr. David Alan Gilbert" <dgilbert@redhat.com>, Fam Zheng <fam@euphon.net>

There is a newer version of this series

migration/block-dirty-bitmap.c                         | 6 ++++++
tests/qemu-iotests/tests/migrate-bitmaps-postcopy-test | 9 +++++++++
2 files changed, 15 insertions(+)

Expand all Fold all

[PATCH 0/2] Fix crash if try to remove bitmap on target during migration

Posted by Vladimir Sementsov-Ogievskiy 3 years, 1 month ago

Hi all!

Bitmaps on source are marked busy during migration.

Enabled bitmaps on target have successor, so they are busy.

But disabled migrated bitmaps are not protected on target. User can
simple remove them and it lead to use-after-free. These bitmaps should
be marked busy.

Vladimir Sementsov-Ogievskiy (2):
  migration/block-dirty-bitmap: make incoming disabled bitmaps busy
  migrate-bitmaps-postcopy-test: check that we can't remove in-flight
    bitmaps

 migration/block-dirty-bitmap.c                         | 6 ++++++
 tests/qemu-iotests/tests/migrate-bitmaps-postcopy-test | 9 +++++++++
 2 files changed, 15 insertions(+)

-- 
2.29.2