[PATCH v4 0/2] Some modification about ram_save_host_page()

Kunkun Jiang posted 2 patches 3 years, 1 month ago
Test checkpatch passed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20210316125716.1243-1-jiangkunkun@huawei.com
Maintainers: Juan Quintela <quintela@redhat.com>, "Dr. David Alan Gilbert" <dgilbert@redhat.com>
migration/ram.c | 34 +++++++++++++++++++---------------
1 file changed, 19 insertions(+), 15 deletions(-)
[PATCH v4 0/2] Some modification about ram_save_host_page()
Posted by Kunkun Jiang 3 years, 1 month ago
Hi all,

This series include patches as below:
Patch 1:
- reduce unnecessary rate limiting in ram_save_host_page()

Patch 2:
- optimized ram_save_host_page() by using migration_bitmap_find_dirty() to find
dirty pages

History:

v3 -> v4:
- Remove the modification to ram_save_host_page() comment [Peter Xu]
- Remove the renaming of tmppages 

v2 -> v3:
- Reduce unnecessary rate limiting if nothing is sent in the current iteration [David Edmondson]
- Invert the body of the loop in ram_save_host_page() [David Edmondson]

v1 -> v2:
- Modify ram_save_host_page() comment [David Edmondson]
- Remove 'goto' [David Edmondson]

Kunkun Jiang (2):
  migration/ram: Reduce unnecessary rate limiting
  migration/ram: Optimize ram_save_host_page()

 migration/ram.c | 34 +++++++++++++++++++---------------
 1 file changed, 19 insertions(+), 15 deletions(-)

-- 
2.23.0


Re: [PATCH v4 0/2] Some modification about ram_save_host_page()
Posted by Kunkun Jiang 3 years, 1 month ago
Kindly ping,

Hi David Alan Gilbert,
Will this series be picked up soon, or is there any other work for me to do?

Best Regards,
Kunkun Jiang

On 2021/3/16 20:57, Kunkun Jiang wrote:
> Hi all,
>
> This series include patches as below:
> Patch 1:
> - reduce unnecessary rate limiting in ram_save_host_page()
>
> Patch 2:
> - optimized ram_save_host_page() by using migration_bitmap_find_dirty() to find
> dirty pages
>
> History:
>
> v3 -> v4:
> - Remove the modification to ram_save_host_page() comment [Peter Xu]
> - Remove the renaming of tmppages
>
> v2 -> v3:
> - Reduce unnecessary rate limiting if nothing is sent in the current iteration [David Edmondson]
> - Invert the body of the loop in ram_save_host_page() [David Edmondson]
>
> v1 -> v2:
> - Modify ram_save_host_page() comment [David Edmondson]
> - Remove 'goto' [David Edmondson]
>
> Kunkun Jiang (2):
>    migration/ram: Reduce unnecessary rate limiting
>    migration/ram: Optimize ram_save_host_page()
>
>   migration/ram.c | 34 +++++++++++++++++++---------------
>   1 file changed, 19 insertions(+), 15 deletions(-)
>


Re: [PATCH v4 0/2] Some modification about ram_save_host_page()
Posted by Dr. David Alan Gilbert 3 years, 1 month ago
* Kunkun Jiang (jiangkunkun@huawei.com) wrote:
> Kindly ping,
> 
> Hi David Alan Gilbert,
> Will this series be picked up soon, or is there any other work for me to do?

You don't need to do anything, but it did miss the cutoff for soft
freeze; since it's an optimisation not a fix; it's still on my list so
it'll go in just as soon as 6.1 opens up.

Dave

> Best Regards,
> Kunkun Jiang
> 
> On 2021/3/16 20:57, Kunkun Jiang wrote:
> > Hi all,
> > 
> > This series include patches as below:
> > Patch 1:
> > - reduce unnecessary rate limiting in ram_save_host_page()
> > 
> > Patch 2:
> > - optimized ram_save_host_page() by using migration_bitmap_find_dirty() to find
> > dirty pages
> > 
> > History:
> > 
> > v3 -> v4:
> > - Remove the modification to ram_save_host_page() comment [Peter Xu]
> > - Remove the renaming of tmppages
> > 
> > v2 -> v3:
> > - Reduce unnecessary rate limiting if nothing is sent in the current iteration [David Edmondson]
> > - Invert the body of the loop in ram_save_host_page() [David Edmondson]
> > 
> > v1 -> v2:
> > - Modify ram_save_host_page() comment [David Edmondson]
> > - Remove 'goto' [David Edmondson]
> > 
> > Kunkun Jiang (2):
> >    migration/ram: Reduce unnecessary rate limiting
> >    migration/ram: Optimize ram_save_host_page()
> > 
> >   migration/ram.c | 34 +++++++++++++++++++---------------
> >   1 file changed, 19 insertions(+), 15 deletions(-)
> > 
> 
-- 
Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK


Re: [PATCH v4 0/2] Some modification about ram_save_host_page()
Posted by Kunkun Jiang 3 years ago
Hi Dave,

On 2021/4/7 1:14, Dr. David Alan Gilbert wrote:
> * Kunkun Jiang (jiangkunkun@huawei.com) wrote:
>> Kindly ping,
>>
>> Hi David Alan Gilbert,
>> Will this series be picked up soon, or is there any other work for me to do?
> You don't need to do anything, but it did miss the cutoff for soft
> freeze; since it's an optimisation not a fix; it's still on my list so
> it'll go in just as soon as 6.1 opens up.
>
> Dave
Okay, I see. Thank you.

Best Regards,
Kunkun Jiang
>> Best Regards,
>> Kunkun Jiang
>>
>> On 2021/3/16 20:57, Kunkun Jiang wrote:
>>> Hi all,
>>>
>>> This series include patches as below:
>>> Patch 1:
>>> - reduce unnecessary rate limiting in ram_save_host_page()
>>>
>>> Patch 2:
>>> - optimized ram_save_host_page() by using migration_bitmap_find_dirty() to find
>>> dirty pages
>>>
>>> History:
>>>
>>> v3 -> v4:
>>> - Remove the modification to ram_save_host_page() comment [Peter Xu]
>>> - Remove the renaming of tmppages
>>>
>>> v2 -> v3:
>>> - Reduce unnecessary rate limiting if nothing is sent in the current iteration [David Edmondson]
>>> - Invert the body of the loop in ram_save_host_page() [David Edmondson]
>>>
>>> v1 -> v2:
>>> - Modify ram_save_host_page() comment [David Edmondson]
>>> - Remove 'goto' [David Edmondson]
>>>
>>> Kunkun Jiang (2):
>>>     migration/ram: Reduce unnecessary rate limiting
>>>     migration/ram: Optimize ram_save_host_page()
>>>
>>>    migration/ram.c | 34 +++++++++++++++++++---------------
>>>    1 file changed, 19 insertions(+), 15 deletions(-)
>>>


Re: [PATCH v4 0/2] Some modification about ram_save_host_page()
Posted by Dr. David Alan Gilbert 2 years, 12 months ago
* Kunkun Jiang (jiangkunkun@huawei.com) wrote:
> Hi all,

Queued; sorry for the delay

> This series include patches as below:
> Patch 1:
> - reduce unnecessary rate limiting in ram_save_host_page()
> 
> Patch 2:
> - optimized ram_save_host_page() by using migration_bitmap_find_dirty() to find
> dirty pages
> 
> History:
> 
> v3 -> v4:
> - Remove the modification to ram_save_host_page() comment [Peter Xu]
> - Remove the renaming of tmppages 
> 
> v2 -> v3:
> - Reduce unnecessary rate limiting if nothing is sent in the current iteration [David Edmondson]
> - Invert the body of the loop in ram_save_host_page() [David Edmondson]
> 
> v1 -> v2:
> - Modify ram_save_host_page() comment [David Edmondson]
> - Remove 'goto' [David Edmondson]
> 
> Kunkun Jiang (2):
>   migration/ram: Reduce unnecessary rate limiting
>   migration/ram: Optimize ram_save_host_page()
> 
>  migration/ram.c | 34 +++++++++++++++++++---------------
>  1 file changed, 19 insertions(+), 15 deletions(-)
> 
> -- 
> 2.23.0
> 
> 
-- 
Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK