[v2] hw/isa/Kconfig: Add missing dependency VIA VT82C686 -> APM

[PATCH v2] hw/isa/Kconfig: Add missing dependency VIA VT82C686 -> APM

Posted by Philippe Mathieu-Daudé 3 years, 1 month ago

TYPE_VIA_PM calls apm_init() in via_pm_realize(), so
requires APM to be selected.

Reported-by: BALATON Zoltan <balaton@eik.bme.hu>
Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
---
Rebased on usb-20210315-pull-request
Based-on: <20210315180240.1597240-1-kraxel@redhat.com>
---
 hw/isa/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/hw/isa/Kconfig b/hw/isa/Kconfig
index 2691eae2f0c..55e0003ce40 100644
--- a/hw/isa/Kconfig
+++ b/hw/isa/Kconfig
@@ -48,6 +48,7 @@ config VT82C686
     select SERIAL_ISA
     select FDC
     select USB_UHCI
+    select APM
 
 config SMC37C669
     bool
-- 
2.26.2

Re: [PATCH-for-6.0? v2] hw/isa/Kconfig: Add missing dependency VIA VT82C686 -> APM

Posted by Philippe Mathieu-Daudé 3 years ago

This patch apparently got lost.

On 3/16/21 12:03 PM, Philippe Mathieu-Daudé wrote:
> TYPE_VIA_PM calls apm_init() in via_pm_realize(), so
> requires APM to be selected.
> 
> Reported-by: BALATON Zoltan <balaton@eik.bme.hu>
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> ---
> Rebased on usb-20210315-pull-request
> Based-on: <20210315180240.1597240-1-kraxel@redhat.com>
> ---
>  hw/isa/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/hw/isa/Kconfig b/hw/isa/Kconfig
> index 2691eae2f0c..55e0003ce40 100644
> --- a/hw/isa/Kconfig
> +++ b/hw/isa/Kconfig
> @@ -48,6 +48,7 @@ config VT82C686
>      select SERIAL_ISA
>      select FDC
>      select USB_UHCI
> +    select APM
>  
>  config SMC37C669
>      bool
>

Re: [PATCH-for-6.0? v2] hw/isa/Kconfig: Add missing dependency VIA VT82C686 -> APM

Posted by BALATON Zoltan 3 years ago

On Thu, 8 Apr 2021, Philippe Mathieu-Daudé wrote:
> This patch apparently got lost.

No, it's queued for 6.1 as part of my pegasos2 series in David's tree:

https://github.com/dgibson/qemu/commits/ppc-for-6.1

Regards,
BALATON Zoltan

> On 3/16/21 12:03 PM, Philippe Mathieu-Daudé wrote:
>> TYPE_VIA_PM calls apm_init() in via_pm_realize(), so
>> requires APM to be selected.
>>
>> Reported-by: BALATON Zoltan <balaton@eik.bme.hu>
>> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
>> ---
>> Rebased on usb-20210315-pull-request
>> Based-on: <20210315180240.1597240-1-kraxel@redhat.com>
>> ---
>>  hw/isa/Kconfig | 1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/hw/isa/Kconfig b/hw/isa/Kconfig
>> index 2691eae2f0c..55e0003ce40 100644
>> --- a/hw/isa/Kconfig
>> +++ b/hw/isa/Kconfig
>> @@ -48,6 +48,7 @@ config VT82C686
>>      select SERIAL_ISA
>>      select FDC
>>      select USB_UHCI
>> +    select APM
>>
>>  config SMC37C669
>>      bool
>>
>
>

Re: [PATCH-for-6.0? v2] hw/isa/Kconfig: Add missing dependency VIA VT82C686 -> APM

Posted by Philippe Mathieu-Daudé 3 years ago

On 4/8/21 3:22 PM, BALATON Zoltan wrote:
> On Thu, 8 Apr 2021, Philippe Mathieu-Daudé wrote:
>> This patch apparently got lost.
> 
> No, it's queued for 6.1 as part of my pegasos2 series in David's tree:
> 
> https://github.com/dgibson/qemu/commits/ppc-for-6.1

Ah great, thank you both.

> 
> Regards,
> BALATON Zoltan
> 
>> On 3/16/21 12:03 PM, Philippe Mathieu-Daudé wrote:
>>> TYPE_VIA_PM calls apm_init() in via_pm_realize(), so
>>> requires APM to be selected.
>>>
>>> Reported-by: BALATON Zoltan <balaton@eik.bme.hu>
>>> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
>>> ---
>>> Rebased on usb-20210315-pull-request
>>> Based-on: <20210315180240.1597240-1-kraxel@redhat.com>
>>> ---
>>>  hw/isa/Kconfig | 1 +
>>>  1 file changed, 1 insertion(+)
>>>
>>> diff --git a/hw/isa/Kconfig b/hw/isa/Kconfig
>>> index 2691eae2f0c..55e0003ce40 100644
>>> --- a/hw/isa/Kconfig
>>> +++ b/hw/isa/Kconfig
>>> @@ -48,6 +48,7 @@ config VT82C686
>>>      select SERIAL_ISA
>>>      select FDC
>>>      select USB_UHCI
>>> +    select APM
>>>
>>>  config SMC37C669
>>>      bool
>>>
>>
>>