[PATCH] include/ui/console.h: Delete is_surface_bgr()

Peter Maydell posted 1 patch 3 years, 1 month ago
Test checkpatch passed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20210314163927.1184-1-peter.maydell@linaro.org
Maintainers: Gerd Hoffmann <kraxel@redhat.com>
include/ui/console.h | 10 ----------
1 file changed, 10 deletions(-)
[PATCH] include/ui/console.h: Delete is_surface_bgr()
Posted by Peter Maydell 3 years, 1 month ago
The function is_surface_bgr() is no longer used anywhere,
so we can delete it.

Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
---
 include/ui/console.h | 10 ----------
 1 file changed, 10 deletions(-)

diff --git a/include/ui/console.h b/include/ui/console.h
index c960b7066cc..810ce7988c0 100644
--- a/include/ui/console.h
+++ b/include/ui/console.h
@@ -267,16 +267,6 @@ PixelFormat qemu_default_pixelformat(int bpp);
 DisplaySurface *qemu_create_displaysurface(int width, int height);
 void qemu_free_displaysurface(DisplaySurface *surface);
 
-static inline int is_surface_bgr(DisplaySurface *surface)
-{
-    if (PIXMAN_FORMAT_BPP(surface->format) == 32 &&
-        PIXMAN_FORMAT_TYPE(surface->format) == PIXMAN_TYPE_ABGR) {
-        return 1;
-    } else {
-        return 0;
-    }
-}
-
 static inline int is_buffer_shared(DisplaySurface *surface)
 {
     return !(surface->flags & QEMU_ALLOCATED_FLAG);
-- 
2.20.1


Re: [PATCH] include/ui/console.h: Delete is_surface_bgr()
Posted by Philippe Mathieu-Daudé 3 years, 1 month ago
On 3/14/21 5:39 PM, Peter Maydell wrote:
> The function is_surface_bgr() is no longer used anywhere,
> so we can delete it.
> 
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
> ---
>  include/ui/console.h | 10 ----------
>  1 file changed, 10 deletions(-)

Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>

Re: [PATCH] include/ui/console.h: Delete is_surface_bgr()
Posted by Gerd Hoffmann 3 years, 1 month ago
On Sun, Mar 14, 2021 at 04:39:27PM +0000, Peter Maydell wrote:
> The function is_surface_bgr() is no longer used anywhere,
> so we can delete it.

Added to (6.1) ui queue.

thanks,
  Gerd