fuzz: add a am53c974 generic-fuzzer config

[PATCH] fuzz: add a am53c974 generic-fuzzer config

Alexander Bulekov posted 1 patch 3 years, 1 month ago

Download mbox

Test checkpatch passed

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20210314055637.5239-1-alxndr@bu.edu

Maintainers: Stefan Hajnoczi <stefanha@redhat.com>, Paolo Bonzini <pbonzini@redhat.com>, Bandan Das <bsd@redhat.com>, Alexander Bulekov <alxndr@bu.edu>, Thomas Huth <thuth@redhat.com>, Laurent Vivier <lvivier@redhat.com>

tests/qtest/fuzz/generic_fuzz_configs.h | 6 ++++++
1 file changed, 6 insertions(+)

Expand all Fold all

[PATCH] fuzz: add a am53c974 generic-fuzzer config

Posted by Alexander Bulekov 3 years, 1 month ago

Signed-off-by: Alexander Bulekov <alxndr@bu.edu>
---

Fuzzing this device might lead to better coverage over the general scsi
code.

 tests/qtest/fuzz/generic_fuzz_configs.h | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/tests/qtest/fuzz/generic_fuzz_configs.h b/tests/qtest/fuzz/generic_fuzz_configs.h
index 5d599765c4..3f4f4d0ec5 100644
--- a/tests/qtest/fuzz/generic_fuzz_configs.h
+++ b/tests/qtest/fuzz/generic_fuzz_configs.h
@@ -208,6 +208,12 @@ const generic_fuzz_config predefined_configs[] = {
         .args = "-machine q35 -nodefaults -device megasas -device scsi-cd,drive=null0 "
         "-blockdev driver=null-co,read-zeroes=on,node-name=null0",
         .objects = "megasas*",
+    },{
+        .name = "am53c974",
+        .args = "-device am53c974,id=scsi -device scsi-hd,drive=disk0 "
+                 "-drive id=disk0,if=none,file=null-co://,format=raw "
+                 "-nodefaults",
+        .objects = "*esp* *scsi* *am53c974*",
     },{
         .name = "ac97",
         .args = "-machine q35 -nodefaults "
-- 
2.27.0

Re: [PATCH] fuzz: add a am53c974 generic-fuzzer config

Posted by Darren Kenny 3 years, 1 month ago

On Sunday, 2021-03-14 at 00:56:37 -05, Alexander Bulekov wrote:
> Signed-off-by: Alexander Bulekov <alxndr@bu.edu>

Code-wise looks fine to me:

Reviewed-by: Darren Kenny <darren.kenny@oracle.com>

Thanks,

Darren

> ---
>
> Fuzzing this device might lead to better coverage over the general scsi
> code.
>
>  tests/qtest/fuzz/generic_fuzz_configs.h | 6 ++++++
>  1 file changed, 6 insertions(+)
>
> diff --git a/tests/qtest/fuzz/generic_fuzz_configs.h b/tests/qtest/fuzz/generic_fuzz_configs.h
> index 5d599765c4..3f4f4d0ec5 100644
> --- a/tests/qtest/fuzz/generic_fuzz_configs.h
> +++ b/tests/qtest/fuzz/generic_fuzz_configs.h
> @@ -208,6 +208,12 @@ const generic_fuzz_config predefined_configs[] = {
>          .args = "-machine q35 -nodefaults -device megasas -device scsi-cd,drive=null0 "
>          "-blockdev driver=null-co,read-zeroes=on,node-name=null0",
>          .objects = "megasas*",
> +    },{
> +        .name = "am53c974",
> +        .args = "-device am53c974,id=scsi -device scsi-hd,drive=disk0 "
> +                 "-drive id=disk0,if=none,file=null-co://,format=raw "
> +                 "-nodefaults",
> +        .objects = "*esp* *scsi* *am53c974*",
>      },{
>          .name = "ac97",
>          .args = "-machine q35 -nodefaults "
> -- 
> 2.27.0