[PATCH v2 0/3] char: Deprecate backend aliases

Kevin Wolf posted 3 patches 3 years, 1 month ago
Test checkpatch passed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20210311164253.338723-1-kwolf@redhat.com
Maintainers: "Marc-André Lureau" <marcandre.lureau@redhat.com>, Paolo Bonzini <pbonzini@redhat.com>
docs/system/deprecated.rst |  6 ++++++
chardev/char.c             | 19 +++++++++++--------
2 files changed, 17 insertions(+), 8 deletions(-)
[PATCH v2 0/3] char: Deprecate backend aliases
Posted by Kevin Wolf 3 years, 1 month ago
A small series from November that has fallen through the cracks...

These aliases only work the command line, but not in QMP. Command line
QAPIfication involves writing some compatibility glue for them, which
I'm doing, but I think it's desirable to unify accepted values of both
paths. So deprecate the aliases so that we can drop the compatibility
glue later.

v2:
- Don't mention deprecated options in the help [Markus]

- Added third patch to simplify the code again. Markus had suggested
  not complicating it in the first place, but then I would have to merge
  patches 1 and 2 even though they address different points, so this
  didn't feel very desirable.

Kevin Wolf (3):
  char: Skip CLI aliases in query-chardev-backends
  char: Deprecate backend aliases 'tty' and 'parport'
  char: Simplify chardev_name_foreach()

 docs/system/deprecated.rst |  6 ++++++
 chardev/char.c             | 19 +++++++++++--------
 2 files changed, 17 insertions(+), 8 deletions(-)

-- 
2.29.2


Re: [PATCH v2 0/3] char: Deprecate backend aliases
Posted by Markus Armbruster 3 years, 1 month ago
Kevin Wolf <kwolf@redhat.com> writes:

> A small series from November that has fallen through the cracks...

Glad you remembered!

> These aliases only work the command line, but not in QMP. Command line
> QAPIfication involves writing some compatibility glue for them, which
> I'm doing, but I think it's desirable to unify accepted values of both
> paths. So deprecate the aliases so that we can drop the compatibility
> glue later.
>
> v2:
> - Don't mention deprecated options in the help [Markus]
>
> - Added third patch to simplify the code again. Markus had suggested
>   not complicating it in the first place, but then I would have to merge
>   patches 1 and 2 even though they address different points, so this
>   didn't feel very desirable.

Complicated review a bit, but I'm not sure the alternative would've been
easier.

Series
Reviewed-by: Markus Armbruster <armbru@redhat.com>

Thanks!