testing/next (hexagon 2, electric boogaloo)

[PATCH v1 0/7] testing/next (hexagon 2, electric boogaloo)

Posted by Alex Bennée 3 years, 2 months ago

Hi,

This is basically the bits I dropped out of the in-flight PR:

  pull-testing-docs-xen-updates-080321-2

In an attempt to avoid docker caching shenanigans I basically took the
fugly hammer to our existing over-engineered docker.py script to grow
new features to handle the case of images we don't want users to build
normally. I'm open to better approaches.

 - docker: Add Hexagon image
 - tests/docker: add "fetch" sub-command
 - tests/docker: allow "update" to add the current user
 - tests/docker: make executable an optional argument to "update"
 - tests/docker: fix copying of executable in "update"


Alessandro Di Federico (2):
  docker: Add Hexagon image
  tests/tcg: Use Hexagon Docker image

Alex Bennée (5):
  tests/docker: fix copying of executable in "update"
  tests/docker: make executable an optional argument to "update"
  tests/docker: allow "update" to add the current user
  tests/docker: add "fetch" sub-command
  gitlab: add build-user-hexagon test

 .gitlab-ci.yml                                |  11 ++
 MAINTAINERS                                   |   2 +
 tests/docker/Makefile.include                 |  24 ++-
 tests/docker/docker.py                        |  78 +++++++---
 .../dockerfiles/debian-hexagon-cross.docker   |  44 ++++++
 .../build-toolchain.sh                        | 141 ++++++++++++++++++
 tests/tcg/configure.sh                        |   4 +
 7 files changed, 282 insertions(+), 22 deletions(-)
 create mode 100644 tests/docker/dockerfiles/debian-hexagon-cross.docker
 create mode 100755 tests/docker/dockerfiles/debian-hexagon-cross.docker.d/build-toolchain.sh

-- 
2.20.1

Re: [PATCH v1 0/7] testing/next (hexagon 2, electric boogaloo)

Posted by no-reply@patchew.org 3 years, 2 months ago

Patchew URL: https://patchew.org/QEMU/20210310192331.29284-1-alex.bennee@linaro.org/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: 20210310192331.29284-1-alex.bennee@linaro.org
Subject: [PATCH  v1 0/7] testing/next (hexagon 2, electric boogaloo)

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 - [tag update]      patchew/20210310002917.8876-1-rebecca@nuviainc.com -> patchew/20210310002917.8876-1-rebecca@nuviainc.com
 * [new tag]         patchew/20210310192331.29284-1-alex.bennee@linaro.org -> patchew/20210310192331.29284-1-alex.bennee@linaro.org
Switched to a new branch 'test'
1033b8c gitlab: add build-user-hexagon test
0a3811b tests/tcg: Use Hexagon Docker image
d98a5bd docker: Add Hexagon image
2bbe59e tests/docker: add "fetch" sub-command
4e01e21 tests/docker: allow "update" to add the current user
06d1e23 tests/docker: make executable an optional argument to "update"
7cb400a tests/docker: fix copying of executable in "update"

=== OUTPUT BEGIN ===
1/7 Checking commit 7cb400a521db (tests/docker: fix copying of executable in "update")
2/7 Checking commit 06d1e23c51b0 (tests/docker: make executable an optional argument to "update")
WARNING: line over 80 characters
#99: FILE: tests/docker/docker.py:562:
+                         print("Couldn't add %s/%s to archive" % (so_path, name))

total: 0 errors, 1 warnings, 79 lines checked

Patch 2/7 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
3/7 Checking commit 4e01e215127c (tests/docker: allow "update" to add the current user)
4/7 Checking commit 2bbe59ed6894 (tests/docker: add "fetch" sub-command)
5/7 Checking commit d98a5bd95e70 (docker: Add Hexagon image)
WARNING: line over 80 characters
#203: FILE: tests/docker/dockerfiles/debian-hexagon-cross.docker.d/build-toolchain.sh:63:
+    -DCMAKE_ASM_FLAGS="-G0 -mlong-calls -fno-pic --target=hexagon-unknown-linux-musl " \

ERROR: line over 90 characters
#230: FILE: tests/docker/dockerfiles/debian-hexagon-cross.docker.d/build-toolchain.sh:90:
+    CROSS_CFLAGS="-G0 -O0 -mv65 -fno-builtin -fno-rounding-math --target=hexagon-unknown-linux-musl" \

ERROR: line over 90 characters
#267: FILE: tests/docker/dockerfiles/debian-hexagon-cross.docker.d/build-toolchain.sh:127:
+    CFLAGS="-G0 -O0 -mv65 -fno-builtin -fno-rounding-math --target=hexagon-unknown-linux-musl" \

total: 2 errors, 1 warnings, 221 lines checked

Patch 5/7 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

6/7 Checking commit 0a3811b8e453 (tests/tcg: Use Hexagon Docker image)
7/7 Checking commit 1033b8cdde1e (gitlab: add build-user-hexagon test)
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/20210310192331.29284-1-alex.bennee@linaro.org/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com