[PATCH] docs: Fix removal text of -show-cursor

Thomas Huth posted 1 patch 4 years, 8 months ago
Test checkpatch passed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20210310045821.1004396-1-thuth@redhat.com
docs/system/removed-features.rst | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
[PATCH] docs: Fix removal text of -show-cursor
Posted by Thomas Huth 4 years, 8 months ago
We should say now when it was removed, not when it was deprecated.

Signed-off-by: Thomas Huth <thuth@redhat.com>
---
 docs/system/removed-features.rst | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/docs/system/removed-features.rst b/docs/system/removed-features.rst
index f8db76d0b5..13f9dd3014 100644
--- a/docs/system/removed-features.rst
+++ b/docs/system/removed-features.rst
@@ -26,8 +26,8 @@ The ``-no-kvm`` argument was a synonym for setting ``-machine accel=tcg``.
 The ``-realtime mlock=on|off`` argument has been replaced by the
 ``-overcommit mem-lock=on|off`` argument.
 
-``-show-cursor`` option (since 5.0)
-'''''''''''''''''''''''''''''''''''
+``-show-cursor`` option (removed in 6.0)
+''''''''''''''''''''''''''''''''''''''''
 
 Use ``-display sdl,show-cursor=on``, ``-display gtk,show-cursor=on``
 or ``-display default,show-cursor=on`` instead.
-- 
2.27.0


Re: [PATCH] docs: Fix removal text of -show-cursor
Posted by Markus Armbruster 4 years, 8 months ago
Thomas Huth <thuth@redhat.com> writes:

> We should say now when it was removed, not when it was deprecated.
>
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
>  docs/system/removed-features.rst | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/docs/system/removed-features.rst b/docs/system/removed-features.rst
> index f8db76d0b5..13f9dd3014 100644
> --- a/docs/system/removed-features.rst
> +++ b/docs/system/removed-features.rst
> @@ -26,8 +26,8 @@ The ``-no-kvm`` argument was a synonym for setting ``-machine accel=tcg``.
>  The ``-realtime mlock=on|off`` argument has been replaced by the
>  ``-overcommit mem-lock=on|off`` argument.
>  
> -``-show-cursor`` option (since 5.0)
> -'''''''''''''''''''''''''''''''''''
> +``-show-cursor`` option (removed in 6.0)
> +''''''''''''''''''''''''''''''''''''''''
>  
>  Use ``-display sdl,show-cursor=on``, ``-display gtk,show-cursor=on``
>  or ``-display default,show-cursor=on`` instead.

Reviewed-by: Markus Armbruster <armbru@redhat.com>


Re: [PATCH] docs: Fix removal text of -show-cursor
Posted by Gerd Hoffmann 4 years, 8 months ago
On Wed, Mar 10, 2021 at 05:58:21AM +0100, Thomas Huth wrote:
> We should say now when it was removed, not when it was deprecated.
> 
> Signed-off-by: Thomas Huth <thuth@redhat.com>

Added to UI queue.

thanks,
  Gerd