[PATCH v4 3/6] net/eth: Initialize input_size variable earlier

Philippe Mathieu-Daudé posted 6 patches 4 years, 8 months ago
There is a newer version of this series
[PATCH v4 3/6] net/eth: Initialize input_size variable earlier
Posted by Philippe Mathieu-Daudé 4 years, 8 months ago
Initialize the 'input_size' variable earlier to make the
next commit easier to review.

Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
---
 net/eth.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/net/eth.c b/net/eth.c
index 6a5a1d04e0b..77af2b673bb 100644
--- a/net/eth.c
+++ b/net/eth.c
@@ -405,11 +405,10 @@ _eth_get_rss_ex_dst_addr(const struct iovec *pkt, int pkt_frags,
                         struct ip6_ext_hdr *ext_hdr,
                         struct in6_address *dst_addr)
 {
+    size_t input_size = iov_size(pkt, pkt_frags);
     struct ip6_ext_hdr_routing *rthdr = (struct ip6_ext_hdr_routing *) ext_hdr;
 
     if ((rthdr->rtype == 2) && (rthdr->segleft == 1)) {
-
-        size_t input_size = iov_size(pkt, pkt_frags);
         size_t bytes_read;
 
         if (input_size < ext_hdr_offset + sizeof(*ext_hdr)) {
-- 
2.26.2

Re: [PATCH v4 3/6] net/eth: Initialize input_size variable earlier
Posted by Stefano Garzarella 4 years, 8 months ago
On Tue, Mar 09, 2021 at 07:27:06PM +0100, Philippe Mathieu-Daudé wrote:
>Initialize the 'input_size' variable earlier to make the
>next commit easier to review.
>
>Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
>---
> net/eth.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)

Reviewed-by: Stefano Garzarella <sgarzare@redhat.com>